From patchwork Fri Jan 20 16:40:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Milard X-Patchwork-Id: 92093 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp122126obz; Fri, 20 Jan 2017 07:40:58 -0800 (PST) X-Received: by 10.237.59.28 with SMTP id p28mr12372101qte.222.1484926858883; Fri, 20 Jan 2017 07:40:58 -0800 (PST) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id o123si5106818qkd.196.2017.01.20.07.40.58; Fri, 20 Jan 2017 07:40:58 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 7114260BE3; Fri, 20 Jan 2017 15:40:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 86C6160B11; Fri, 20 Jan 2017 15:40:54 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 4971760B4E; Fri, 20 Jan 2017 15:40:52 +0000 (UTC) Received: from mail-lf0-f47.google.com (mail-lf0-f47.google.com [209.85.215.47]) by lists.linaro.org (Postfix) with ESMTPS id 1F2E360AF2 for ; Fri, 20 Jan 2017 15:40:50 +0000 (UTC) Received: by mail-lf0-f47.google.com with SMTP id v186so60691699lfa.1 for ; Fri, 20 Jan 2017 07:40:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bgXQGhrPurLvt3EhR/GCCBwUBGb8XHyYPUXseoaGwlI=; b=F8IyZmgGkgSgxS5XKPXPW+r+B53wePKlizcw0WxHIKW1kg3ATV0C5QP9eBT8tnnaki M9MjcspRqMDFvjGfgZqjelWFyGqEMiHtGMtqt/Cl874vKjhjkne1WNTXSI+pDiURFdZm k0+SNQ3HP2rcjjoa+f1Z283UBg8BeNv5ZJQkUwaffBjjEvMVtYBAJus3FtNp3l25uJbi XDZTuq5Vo7X1C52CkT/0i6IfVe4CIqMDWdj7PVzeBBSVH+aRuyHNB5dQixonMeOkWk/X wCWAmTurVRhO9H9Pxb0U5yganZrY1m/laqzpOVSkbw+3ZXUtMTtwzNsjD611+F20vjZx Uibw== X-Gm-Message-State: AIkVDXJRX5nX2HGmRJsw+LGeWh1607y8OS1AMxEqtJ5OT6DcZJC5g61JHhduLH4wLhD5jeC7jaY= X-Received: by 10.46.77.17 with SMTP id a17mr7252060ljb.2.1484926849738; Fri, 20 Jan 2017 07:40:49 -0800 (PST) Received: from erachmi-ericsson.ki.sw.ericsson.se (c-83-233-76-66.cust.bredband2.com. [83.233.76.66]) by smtp.gmail.com with ESMTPSA id k7sm3674302lfe.26.2017.01.20.07.40.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 20 Jan 2017 07:40:49 -0800 (PST) From: Christophe Milard To: mike.holmes@linaro.org, bill.fischofer@linaro.org, lng-odp@lists.linaro.org Date: Fri, 20 Jan 2017 17:40:02 +0100 Message-Id: <1484930402-41533-1-git-send-email-christophe.milard@linaro.org> X-Mailer: git-send-email 2.7.4 Subject: [lng-odp] [PATCH] linux-gen: _ishm: checking fstat return value. X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" Hence fixing CID 174663 Signed-off-by: Christophe Milard --- platform/linux-generic/_ishm.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.7.4 diff --git a/platform/linux-generic/_ishm.c b/platform/linux-generic/_ishm.c index f889834..8da64a1 100644 --- a/platform/linux-generic/_ishm.c +++ b/platform/linux-generic/_ishm.c @@ -818,7 +818,12 @@ int _odp_ishm_reserve(const char *name, uint64_t size, int fd, /* If a file descriptor is provided, get the real size and map: */ if (fd >= 0) { - fstat(fd, &statbuf); + if (fstat(fd, &statbuf) < 0) { + close(fd); + odp_spinlock_unlock(&ishm_tbl->lock); + ODP_ERR("_ishm_reserve failed (fstat failed).\n"); + return -1; + } len = statbuf.st_size; /* note that the huge page flag is meningless here as huge * page is determined by the provided file descriptor: */