From patchwork Tue Jan 16 11:00:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 124655 Delivered-To: patch@linaro.org Received: by 10.46.64.148 with SMTP id r20csp972594lje; Tue, 16 Jan 2018 03:03:02 -0800 (PST) X-Google-Smtp-Source: ACJfBou5lgKXTjT0y7AsHsXskztuTYywL3YOrRxWp0P/WR+NCilTxdpt/P+jwpXTeBwpFEOwzqg/ X-Received: by 10.237.62.81 with SMTP id m17mr35969212qtf.88.1516100582496; Tue, 16 Jan 2018 03:03:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516100582; cv=none; d=google.com; s=arc-20160816; b=Dw5CjKJ4U8gDcfSrGwnke6OZF+FszbiMoPxo0wVzQoqWWq6izupbkFSf9btLchFetH +1jjeHeldf54Yk4ZCIfT6qsnMUfueYIXKqmKp1YUPOXaYB6AwHliNh3Hh9oFchEmiEnR Ago+qrel5vVAdysSk+SEFnGukIFkAqWLTplfufJVVdwsPVWyjUStZoR8aFzr+bTZRLtf qZ+/Z1oyU3xpIenYDTtkUqZ/GwN2ZOCpbxF5NSIdPiEUdKIozCnKZfFDSpIgWuDm6bWp WX1uZZH2gk+NapPaVVXkbHu+Bg1L5G+cbVbSeI3WEsO4hBoXZzYaqc/bHS0uZHdizyC+ 871g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=d5VMhU9vX4c/ibJwTuW1Mx5dIdEcO//b7Z97QHFwWfk=; b=GlkVnQtsWoYEQ9y1EKSwUKU9m6Y/MBMYD13s5PbP5pZdPqS0ZR7tCg4rm6Hw90u/6a IFXBLfi4WxGXF9ILRq6GrpoF7i1Pm5qPTQazucHPx/zxBFSKpA/9yqY7hmH+NustwWML g7GQeDMj2QxpCkCYXhOuK2B5oSheUc6ixXQblShnwjgXaPzUrCuBREh/2a750G3HkHJR vbdW70siv9Ng7r2dmJUuS9Wh/mWWNzdepN3dsmk1cbzHLbR/0MZTlpLzSdmd4byIQ07C lmo9PqeswZkHKOoMl9J2zesoUy07Qaa7cBlek6wgu3PzirjCoqh6PEXXqrP7sY945oRa vhog== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id y9si1909891qtf.353.2018.01.16.03.03.02; Tue, 16 Jan 2018 03:03:02 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 26C95617B2; Tue, 16 Jan 2018 11:03:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 906EC61797; Tue, 16 Jan 2018 11:00:37 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 754A76174B; Tue, 16 Jan 2018 11:00:24 +0000 (UTC) Received: from forward103j.mail.yandex.net (forward103j.mail.yandex.net [5.45.198.246]) by lists.linaro.org (Postfix) with ESMTPS id 1E9D36174B for ; Tue, 16 Jan 2018 11:00:15 +0000 (UTC) Received: from mxback6j.mail.yandex.net (mxback6j.mail.yandex.net [IPv6:2a02:6b8:0:1619::10f]) by forward103j.mail.yandex.net (Yandex) with ESMTP id 0D98434C19C1 for ; Tue, 16 Jan 2018 14:00:13 +0300 (MSK) Received: from smtp4o.mail.yandex.net (smtp4o.mail.yandex.net [2a02:6b8:0:1a2d::28]) by mxback6j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id mRogguijeu-0CGOF0cn; Tue, 16 Jan 2018 14:00:13 +0300 Received: by smtp4o.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id 7uRxxYxlfl-0C6mC9cL; Tue, 16 Jan 2018 14:00:12 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Tue, 16 Jan 2018 14:00:06 +0300 Message-Id: <1516100408-8246-5-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1516100408-8246-1-git-send-email-odpbot@yandex.ru> References: <1516100408-8246-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 392 Subject: [lng-odp] [PATCH API-NEXT v1 4/6] api: packet: initialize user ptr to NULL X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Petri Savolainen Require that implementation initializes the pointer value to NULL. Application can use the pointer more robustly when it can tell if the pointer has been set previously or not. Signed-off-by: Petri Savolainen --- /** Email created from pull request 392 (psavol:next-user-ptr-init-rebase) ** https://github.com/Linaro/odp/pull/392 ** Patch: https://github.com/Linaro/odp/pull/392.patch ** Base sha: f6dab2bfa90ef5d3146cb76f86bc8782666f0f3e ** Merge commit sha: 7244f46bcf5e4a0fce4048e306f224f31e9a4d2f **/ include/odp/api/spec/packet.h | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/include/odp/api/spec/packet.h b/include/odp/api/spec/packet.h index 3655f5899..8aca552f6 100644 --- a/include/odp/api/spec/packet.h +++ b/include/odp/api/spec/packet.h @@ -1341,7 +1341,10 @@ int odp_packet_input_index(odp_packet_t pkt); /** * User context pointer * - * Return previously stored user context pointer. + * Return previously stored user context pointer. If not otherwise documented, + * the pointer value is maintained over packet manipulating operations. + * Implementation initializes the pointer value to NULL during new packet + * creation (e.g. alloc and packet input) and reset. * * @param pkt Packet handle * @@ -1357,10 +1360,10 @@ void *odp_packet_user_ptr(odp_packet_t pkt); * value of type intptr_t. ODP may use the pointer for data prefetching, but * must ignore any invalid addresses. * - * @param pkt Packet handle - * @param ctx User context pointer + * @param pkt Packet handle + * @param user_ptr User context pointer */ -void odp_packet_user_ptr_set(odp_packet_t pkt, const void *ctx); +void odp_packet_user_ptr_set(odp_packet_t pkt, const void *user_ptr); /** * User area address