diff mbox series

[API-NEXT,v2,6/16] validation: crypto: drop obsolete GMAC-related hack

Message ID 1517130009-11837-7-git-send-email-odpbot@yandex.ru
State Superseded
Headers show
Series [API-NEXT,v2,1/16] api: crypto: clarify special nature of gcm and gmac | expand

Commit Message

Github ODP bot Jan. 28, 2018, 8:59 a.m. UTC 
From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>


Checking that cipher is not NULL was required because GMAC used NULL
cipher to specify it's IV. Now it is obosolete, as auths has their own
IV.

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

---
/** Email created from pull request 434 (lumag:crypto-upd)
 ** https://github.com/Linaro/odp/pull/434
 ** Patch: https://github.com/Linaro/odp/pull/434.patch
 ** Base sha: 0bdad6d2562166eec4abeb957b6bb5067de9fe94
 ** Merge commit sha: 8947b874421e06f87f32ec66357967a71e46e986
 **/
 test/validation/api/crypto/odp_crypto_test_inp.c | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c
index 2b0ba1cd9..0448972b8 100644
--- a/test/validation/api/crypto/odp_crypto_test_inp.c
+++ b/test/validation/api/crypto/odp_crypto_test_inp.c
@@ -580,9 +580,6 @@  static void check_alg(odp_crypto_op_t op,
 	for (i = 0; i < cipher_num; i++) {
 		cipher_ok |= cipher_tested[i];
 		if (!cipher_tested[i]) {
-			/* GMAC-related hacks */
-			if (cipher_alg == ODP_CIPHER_ALG_NULL)
-				continue;
 			printf("\n    Untested: alg=%s, key_len=%" PRIu32 ", "
 			       "iv_len=%" PRIu32 "\n",
 			       cipher_alg_name(cipher_alg),