From patchwork Sun Jan 28 08:59:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 126063 Delivered-To: patch@linaro.org Received: by 10.46.84.92 with SMTP id y28csp1558279ljd; Sun, 28 Jan 2018 01:04:32 -0800 (PST) X-Google-Smtp-Source: AH8x227rTmxKUcyiKWU8AKjxJeGdUjSZ/fkKaR8mI/t2oBBuuXhkzM5ILkJidBnK3lGXylIriw5y X-Received: by 10.237.44.98 with SMTP id f89mr32107712qtd.94.1517130272673; Sun, 28 Jan 2018 01:04:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517130272; cv=none; d=google.com; s=arc-20160816; b=eXlXko4xh6+ZPcBg38ilB3fSL1yC6V0TwhQcg1vPV55kUPvpLa174mKOaUYCze3WCV zCIkM78Y+XpMnccNrhcDyddHZvfzqQOc5zgghh+ga1uT3Z4dXygAL/S1EOy3LSzGwOb8 bDmATqqDwicOb/JkjWo/egG+93GBo5YFnSng4vKmP0gejE4tRJCZUPIMESAl8TB8Do7o 0eJpjQI0fwK/VlodCSm5YfrAOrmDGszs7cFJJqEtO4P8QC1dOtiSyosFw1TBBJj7UpKL ll+sDIYBN/dTKAirWfI+W2Hz7CHY2vViPRzsWzfuD1MejO4zEeCjAIW+MVexr0smcNAY SevA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=1R/8aryKAiiP83k0EbZuTlFXo/q81fzqkNrJbqn3n8w=; b=Qh2RhQgD5JfGVQatzMmOCA+6MG8KBQvp3EwvUgm4wPztLPIDcrGutPrjieTBryGJi+ AWrgaY0JsgN85Rs0YceAwVsUuPjhBNgcZuV2WgRLpmoubr89dQxfp+kfAGwUiSiwzzzG 8Br1xuEymfap3r/zg8FW18ATAgsKaStrxPIehxLW5NojDTAFGoteD3gvTKrg1YK3lXdw o9d7a32Xd3UL+AQMnGP9OsGbt1+S/8z+5/MV2dNgvf0IGCCs5vGV+Z5GQgL+0IcboA+j Zjg4Gj3h4CC/naW5ujM9XchHej4Y4VuUQVwFYqXJlrww3OokBO9m3Ipy/zrUNhCrWH66 fMgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id c72si2035097qkb.394.2018.01.28.01.04.32; Sun, 28 Jan 2018 01:04:32 -0800 (PST) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id 4ECFD617F3; Sun, 28 Jan 2018 09:04:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2 autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id A5C1261802; Sun, 28 Jan 2018 09:00:43 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 2B87B61736; Sun, 28 Jan 2018 09:00:20 +0000 (UTC) Received: from forward104o.mail.yandex.net (forward104o.mail.yandex.net [37.140.190.179]) by lists.linaro.org (Postfix) with ESMTPS id 328826173A for ; Sun, 28 Jan 2018 09:00:16 +0000 (UTC) Received: from mxback5g.mail.yandex.net (mxback5g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:166]) by forward104o.mail.yandex.net (Yandex) with ESMTP id E231F703821 for ; Sun, 28 Jan 2018 12:00:14 +0300 (MSK) Received: from smtp3p.mail.yandex.net (smtp3p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:8]) by mxback5g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id hvBA9v5mZt-0EoeevAU; Sun, 28 Jan 2018 12:00:14 +0300 Received: by smtp3p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id kBi2pciDaV-0EXeF2HH; Sun, 28 Jan 2018 12:00:14 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Sun, 28 Jan 2018 11:59:59 +0300 Message-Id: <1517130009-11837-7-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1517130009-11837-1-git-send-email-odpbot@yandex.ru> References: <1517130009-11837-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 434 Subject: [lng-odp] [PATCH API-NEXT v2 6/16] validation: crypto: drop obsolete GMAC-related hack X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Dmitry Eremin-Solenikov Checking that cipher is not NULL was required because GMAC used NULL cipher to specify it's IV. Now it is obosolete, as auths has their own IV. Signed-off-by: Dmitry Eremin-Solenikov --- /** Email created from pull request 434 (lumag:crypto-upd) ** https://github.com/Linaro/odp/pull/434 ** Patch: https://github.com/Linaro/odp/pull/434.patch ** Base sha: 0bdad6d2562166eec4abeb957b6bb5067de9fe94 ** Merge commit sha: 8947b874421e06f87f32ec66357967a71e46e986 **/ test/validation/api/crypto/odp_crypto_test_inp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/test/validation/api/crypto/odp_crypto_test_inp.c b/test/validation/api/crypto/odp_crypto_test_inp.c index 2b0ba1cd9..0448972b8 100644 --- a/test/validation/api/crypto/odp_crypto_test_inp.c +++ b/test/validation/api/crypto/odp_crypto_test_inp.c @@ -580,9 +580,6 @@ static void check_alg(odp_crypto_op_t op, for (i = 0; i < cipher_num; i++) { cipher_ok |= cipher_tested[i]; if (!cipher_tested[i]) { - /* GMAC-related hacks */ - if (cipher_alg == ODP_CIPHER_ALG_NULL) - continue; printf("\n Untested: alg=%s, key_len=%" PRIu32 ", " "iv_len=%" PRIu32 "\n", cipher_alg_name(cipher_alg),