From patchwork Thu Aug 9 13:00:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Github ODP bot X-Patchwork-Id: 143839 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp2064666ljj; Thu, 9 Aug 2018 06:00:44 -0700 (PDT) X-Google-Smtp-Source: AA+uWPyxuLxi4oiJluSfX2WhjfmP6nirncBh2vpTf5AhJKgO0YZtHFyHCmLIBt1yEL7KV4B2NgVk X-Received: by 2002:a37:c3cf:: with SMTP id r76-v6mr1709278qkl.150.1533819644231; Thu, 09 Aug 2018 06:00:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533819644; cv=none; d=google.com; s=arc-20160816; b=OVYRSueb38zlQK8FZwRpN5wImmVKNZ+MPvZdRgbnziMShplK/WG0b03ylRVVcqnTMi laQhuH5YpxJk4KMUhictebeN/3bAMWclVYTc/nsApoxS/m9tKqBRcTu3ufOP1zUQAeKs LzeyQCJ50sFi/C8yGZWJ1Yc4fNMb5lFs9KNJrRNNkqEW06l/3bgNTfZvyAvOICw7rUDb cT5iNEfZTVH0DHshUFeqcIcJa2r5/AkRnd1mrWLEYSqPVR5xVYuGijv27sRMLbWCe+O4 EhAU4oW9qaqJooxJGP76H8sHZj1u6ByIOCCubRUUDenUhAIHWoLDPe8qsLWIeHDuAH4w e6DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:github-pr-num :references:in-reply-to:message-id:date:to:from:delivered-to :arc-authentication-results; bh=fg4o5gkIZvx4IdP8r24MMCz1fLR6CaMbjSE2ihbuQ8U=; b=XUGN3qoyrmuxjx60bl10OZ6XObR8vyTFuFV2wQyoTZPc0wjYtc7bAVGiGYsKPsdhNl vWLfF4zbcSxFk8zsiWG2CqDg2EUrTVQLOisHRXVz0guUAul+OuTlY2ZNJoWsDSz12sKv JOxc9zvKetqweA5VZiZcmneSWEOS+SpKpmkT1Og4kF5hTpqg0QSQ7EBmpjaAkgqn7u9b Xrhj6ERr0EZbqIVtH8XTPOEbW+mgWgkrThvNxCWqGENn9v8LhxkKaw73e86tovsTdAf1 hNpICaP39RWlYjFm5KfEhGjXdmB+xpjsBBQtgX21+CLsiYYiNR4ZDTARjGAcV6ZTSw6Z oIWw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Return-Path: Received: from lists.linaro.org (ec2-54-197-127-237.compute-1.amazonaws.com. [54.197.127.237]) by mx.google.com with ESMTP id p42-v6si6879150qtf.121.2018.08.09.06.00.43; Thu, 09 Aug 2018 06:00:44 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) client-ip=54.197.127.237; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.197.127.237 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=yandex.ru Received: by lists.linaro.org (Postfix, from userid 109) id B579D68625; Thu, 9 Aug 2018 13:00:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 30502600CE; Thu, 9 Aug 2018 13:00:37 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id B09BC6860D; Thu, 9 Aug 2018 13:00:29 +0000 (UTC) Received: from forward100p.mail.yandex.net (forward100p.mail.yandex.net [77.88.28.100]) by lists.linaro.org (Postfix) with ESMTPS id BC9DC6860D for ; Thu, 9 Aug 2018 13:00:13 +0000 (UTC) Received: from mxback11j.mail.yandex.net (mxback11j.mail.yandex.net [IPv6:2a02:6b8:0:1619::84]) by forward100p.mail.yandex.net (Yandex) with ESMTP id 46D4651051BC for ; Thu, 9 Aug 2018 16:00:12 +0300 (MSK) Received: from smtp1p.mail.yandex.net (smtp1p.mail.yandex.net [2a02:6b8:0:1472:2741:0:8b6:6]) by mxback11j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id FAeY4hb6MM-0C0iZxeb; Thu, 09 Aug 2018 16:00:12 +0300 Received: by smtp1p.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id NB1Fb3jYn0-0BJO9i7D; Thu, 09 Aug 2018 16:00:11 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client certificate not present) From: Github ODP bot To: lng-odp@lists.linaro.org Date: Thu, 9 Aug 2018 13:00:07 +0000 Message-Id: <1533819610-30956-2-git-send-email-odpbot@yandex.ru> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1533819610-30956-1-git-send-email-odpbot@yandex.ru> References: <1533819610-30956-1-git-send-email-odpbot@yandex.ru> Github-pr-num: 670 Subject: [lng-odp] [PATCH v1 1/4] linux-gen: odp_tm_queue_destroy should not take care about params X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" From: Maxim Uvarov params are set by application, we should not take care about them in implementation function. Signed-off-by: Maxim Uvarov --- /** Email created from pull request 670 (muvarov:devel/master_tm) ** https://github.com/Linaro/odp/pull/670 ** Patch: https://github.com/Linaro/odp/pull/670.patch ** Base sha: 7c87b66edc84e8c713fefc68d46464660adaf71e ** Merge commit sha: 37f8e9b0f4297cc96c5271e3e082cf0f39454538 **/ platform/linux-generic/odp_traffic_mngr.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/platform/linux-generic/odp_traffic_mngr.c b/platform/linux-generic/odp_traffic_mngr.c index af403b4b6..0d01c0ea5 100644 --- a/platform/linux-generic/odp_traffic_mngr.c +++ b/platform/linux-generic/odp_traffic_mngr.c @@ -3967,12 +3967,9 @@ odp_tm_queue_t odp_tm_queue_create(odp_tm_t odp_tm, int odp_tm_queue_destroy(odp_tm_queue_t tm_queue) { - tm_wred_params_t *wred_params; tm_shaper_obj_t *shaper_obj; tm_queue_obj_t *tm_queue_obj; - tm_wred_node_t *tm_wred_node; tm_system_t *tm_system; - uint32_t color; /* First lookup tm_queue. */ tm_queue_obj = GET_TM_QUEUE_OBJ(tm_queue); @@ -3990,23 +3987,6 @@ int odp_tm_queue_destroy(odp_tm_queue_t tm_queue) (tm_queue_obj->pkt != ODP_PACKET_INVALID)) return -1; - /* Check that there is no shaper profile, threshold profile or wred - * profile currently associated with this tm_queue. */ - if (shaper_obj->shaper_params != NULL) - return -1; - - tm_wred_node = tm_queue_obj->tm_wred_node; - if (tm_wred_node != NULL) { - if (tm_wred_node->threshold_params != NULL) - return -1; - - for (color = 0; color < ODP_NUM_PACKET_COLORS; color++) { - wred_params = tm_wred_node->wred_params[color]; - if (wred_params != NULL) - return -1; - } - } - /* Now that all of the checks are done, time to so some freeing. */ odp_ticketlock_lock(&tm_system->tm_system_lock); tm_system->queue_num_tbl[tm_queue_obj->queue_num - 1] = NULL;