From patchwork Wed Jan 28 09:56:30 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anders Roxell X-Patchwork-Id: 43877 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f70.google.com (mail-ee0-f70.google.com [74.125.83.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0990B23FFF for ; Wed, 28 Jan 2015 09:56:52 +0000 (UTC) Received: by mail-ee0-f70.google.com with SMTP id c13sf10388630eek.1 for ; Wed, 28 Jan 2015 01:56:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:message-id:references :mime-version:content-disposition:in-reply-to:user-agent:cc:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:content-type:content-transfer-encoding :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=TgVe2pk84KcwxYtv3hriE0/dTsppPq8z7/UgB/o3eCw=; b=V38fGZxJfKv8VwJlNGPbf6JFQl++/7fkL9gWCdeuoFU6otkB8DXP9S4bogubqbGkNA OJcQt2RScACGTNqnfekmokuf62ljaWMYJniKdB29cR8bT9PH4XVuwTuxOlfI1PdEhEUT cYEuV32m1dnbabAj2yubuFul1g7C5zdxOEL9UVOtkSO0tTS2cqz4iI5eX0tfAGz0eRt4 1Sa5Yx5jEbRP2r0SmiuCVSOEoMGNrFN9xX5oXKeHMiLCfmnVYQoOX1RU7q3um1eSX7oL QFgk8lWlryRUrYT9QF9QOURT/WtxW2uCRqs5ZqB0otxsZ9L152OgcXPT3b0YcI+Dmc0v g/GA== X-Gm-Message-State: ALoCoQkUBXP8wTSBAy2aXO/hdGB3O/5l8Rg8gT35qfz/WHYrft9o6TM6S+4zkqSKyWy9Jl6aMisx X-Received: by 10.112.181.198 with SMTP id dy6mr895319lbc.22.1422439010795; Wed, 28 Jan 2015 01:56:50 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.245.43 with SMTP id xl11ls142157lac.54.gmail; Wed, 28 Jan 2015 01:56:50 -0800 (PST) X-Received: by 10.152.21.228 with SMTP id y4mr6881258lae.72.1422439010624; Wed, 28 Jan 2015 01:56:50 -0800 (PST) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com. [209.85.217.179]) by mx.google.com with ESMTPS id tf9si3836077lbb.67.2015.01.28.01.56.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 Jan 2015 01:56:50 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) client-ip=209.85.217.179; Received: by mail-lb0-f179.google.com with SMTP id 10so17704931lbg.10 for ; Wed, 28 Jan 2015 01:56:50 -0800 (PST) X-Received: by 10.152.3.70 with SMTP id a6mr6743293laa.71.1422439010503; Wed, 28 Jan 2015 01:56:50 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp1381150lbj; Wed, 28 Jan 2015 01:56:49 -0800 (PST) X-Received: by 10.140.23.84 with SMTP id 78mr10590721qgo.93.1422439008776; Wed, 28 Jan 2015 01:56:48 -0800 (PST) Received: from ip-10-35-177-41.ec2.internal (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTPS id w5si5383239qge.81.2015.01.28.01.56.47 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 28 Jan 2015 01:56:48 -0800 (PST) Received-SPF: none (google.com: lng-odp-bounces@lists.linaro.org does not designate permitted sender hosts) client-ip=54.225.227.206; Received: from localhost ([127.0.0.1] helo=ip-10-35-177-41.ec2.internal) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YGPMa-0005zt-UB; Wed, 28 Jan 2015 09:56:44 +0000 Received: from mail-lb0-f170.google.com ([209.85.217.170]) by ip-10-35-177-41.ec2.internal with esmtp (Exim 4.76) (envelope-from ) id 1YGPMW-0005zo-Hs for lng-odp@lists.linaro.org; Wed, 28 Jan 2015 09:56:40 +0000 Received: by mail-lb0-f170.google.com with SMTP id w7so17726446lbi.1 for ; Wed, 28 Jan 2015 01:56:34 -0800 (PST) X-Received: by 10.152.88.104 with SMTP id bf8mr5390002lab.65.1422438994844; Wed, 28 Jan 2015 01:56:34 -0800 (PST) Received: from 8074w.roxell.se (sestofw01.enea.se. [192.36.1.252]) by mx.google.com with ESMTPSA id pn7sm1200091lbb.6.2015.01.28.01.56.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jan 2015 01:56:34 -0800 (PST) Date: Wed, 28 Jan 2015 10:56:30 +0100 From: Anders Roxell To: Bill Fischofer Message-ID: <20150128095630.GI14949@8074w.roxell.se> References: <1421259883-6239-1-git-send-email-Geoffrey.Blake@arm.com> <1422398642-3293-1-git-send-email-Geoffrey.Blake@arm.com> <1422398642-3293-2-git-send-email-Geoffrey.Blake@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Topics: patch Cc: Geoffrey Blake , LNG ODP Mailman List Subject: Re: [lng-odp] [PATCH v7 2/3] linux-generic: Implement 32bit version of _odp_atomic_tptr_t X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: lng-odp-bounces@lists.linaro.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: anders.roxell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 2015-01-27 21:41, Bill Fischofer wrote: > On Tue, Jan 27, 2015 at 4:44 PM, Geoffrey Blake > wrote: > > > From: Geoffrey Blake > > > > Signed-off-by: Geoffrey Blake > > > > Reviewed-and-tested-by: Bill Fischofer > I wasn't able to build: make distcheck... I think we can add something like this (see below)... We need to figure out a better name than config.h and a better name than I used as well... =) Maybe this file should be placed in the platform/linux-generic/include/ directory with some sensible name Or should we place this file in the ROOT_DIR/include/ directory after the reorganisation? Do we want to expose this file to the users? If we agree on doing this, I think this should go in as a separate prior too this patch. Cheers, Anders diff --git a/configure.ac b/configure.ac index 7f689de..37f2e2e 100644 --- a/configure.ac +++ b/configure.ac @@ -1,8 +1,8 @@ AC_PREREQ([2.5]) AC_INIT([OpenDataPlane], m4_esyscmd(./scripts/odp_version.sh), [lng-odp@lists.linaro.org]) AM_INIT_AUTOMAKE([subdir-objects]) -AC_CONFIG_SRCDIR([helper/config.h.in]) -AM_CONFIG_HEADER([helper/config.h]) +AC_CONFIG_SRCDIR([platform/linux-generic/include/odp_gen_config.h.in]) +AM_CONFIG_HEADER([platform/linux-generic/include/odp_gen_config.h]) AC_USE_SYSTEM_EXTENSIONS AC_SYS_LARGEFILE diff --git a/helper/.gitignore b/helper/.gitignore deleted file mode 100644 index f282c15..0000000 --- a/helper/.gitignore +++ /dev/null @@ -1,3 +0,0 @@ -config.h.in -config.h -stamp-h1 diff --git a/platform/linux-generic/.gitignore b/platform/linux-generic/.gitignore new file mode 100644 index 0000000..5e8e32f --- /dev/null +++ b/platform/linux-generic/.gitignore @@ -0,0 +1,3 @@ +odp_gen_config.h.in +odp_gen_config.h +stamp-h1 diff --git a/platform/linux-generic/Makefile.am b/platform/linux-generic/Makefile.am index 4c226a8..fae586a 100644 --- a/platform/linux-generic/Makefile.am +++ b/platform/linux-generic/Makefile.am @@ -3,7 +3,7 @@ include $(top_srcdir)/platform/Makefile.inc AM_CFLAGS += -I$(srcdir)/include AM_CFLAGS += -I$(srcdir)/include/api -AM_CFLAGS += -I$(top_srcdir)/helper/include -I$(top_srcdir)/helper +AM_CFLAGS += -I$(top_srcdir)/helper/include include_HEADERS = \ $(top_srcdir)/platform/linux-generic/include/api/odp.h \ @@ -49,6 +49,7 @@ noinst_HEADERS = \ ${top_srcdir}/platform/linux-generic/include/odp_classification_datamodel.h \ ${top_srcdir}/platform/linux-generic/include/odp_classification_inlines.h \ ${top_srcdir}/platform/linux-generic/include/odp_classification_internal.h \ + $(top_srcdir)/platform/linux-generic/include/odp_gen_config.h \ ${top_srcdir}/platform/linux-generic/include/odp_crypto_internal.h \ ${top_srcdir}/platform/linux-generic/include/odp_debug_internal.h \ ${top_srcdir}/platform/linux-generic/include/odp_internal.h \ diff --git a/platform/linux-generic/include/odp_atomic_internal.h b/platform/linux-generic/include/odp_atomic_internal.h index 90a515a..611f6d4 100644 --- a/platform/linux-generic/include/odp_atomic_internal.h +++ b/platform/linux-generic/include/odp_atomic_internal.h @@ -16,7 +16,7 @@ #ifndef ODP_ATOMIC_INTERNAL_H_ #define ODP_ATOMIC_INTERNAL_H_ -#include +#include #include #include #include