From patchwork Tue Aug 11 17:57:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zoltan Kiss X-Patchwork-Id: 52319 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by patches.linaro.org (Postfix) with ESMTPS id 0DCAA22DD6 for ; Tue, 11 Aug 2015 17:58:15 +0000 (UTC) Received: by lbck9 with SMTP id k9sf23207500lbc.0 for ; Tue, 11 Aug 2015 10:58:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:delivered-to:message-id:date:from :user-agent:mime-version:to:references:in-reply-to:subject :precedence:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:content-transfer-encoding:content-type :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=8H5T1l3GdUT3uSndN8j872tv5dh712t/xl+bcZnit8s=; b=Efw/XpQp/NxXdqHhj5S+/bHJVd1SbfYvPtJu/bWMnRCc5qjjMNxWuiNkLeeh3AmZiE NWLJLUdBfHAh8+pwUa1T85+p3OGdbJ1SdlY2fEr0+IU1ltWA/4emRAphhpqhnTViyFr4 ajuAOq6uB79C35lgzC766bJ04jzxuYPsrqDeBh0+MyNAP15Fe6AulGtSn/AdyiydJyEG wQMqmBF73htX/9fenab64vzroZQr3Ly4Z33JZIoBokcVRiUmefO6KFXGStfSpDOkQ1Pn ZNWtFBcTGJUwMzF9oL6J8stgEJmytaD2q1axyvRyVx8eX1L3DGF/nAk+lblKqP5qjpws UzPQ== X-Gm-Message-State: ALoCoQmH1n7unb0NGzYmMuLdSTAXgpZ2V9+r2vNHu9VbN5PCW1ObkxH3MSrQ5SfWntgMlUlMD+Jc X-Received: by 10.152.120.138 with SMTP id lc10mr2674100lab.3.1439315893603; Tue, 11 Aug 2015 10:58:13 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.120.40 with SMTP id kz8ls916983lab.24.gmail; Tue, 11 Aug 2015 10:58:13 -0700 (PDT) X-Received: by 10.152.22.168 with SMTP id e8mr27485400laf.40.1439315893450; Tue, 11 Aug 2015 10:58:13 -0700 (PDT) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com. [209.85.215.44]) by mx.google.com with ESMTPS id dl8si1881538lad.72.2015.08.11.10.58.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Aug 2015 10:58:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) client-ip=209.85.215.44; Received: by labd1 with SMTP id d1so61880615lab.1 for ; Tue, 11 Aug 2015 10:58:13 -0700 (PDT) X-Received: by 10.152.4.163 with SMTP id l3mr27955490lal.35.1439315893157; Tue, 11 Aug 2015 10:58:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp2673861lba; Tue, 11 Aug 2015 10:58:12 -0700 (PDT) X-Received: by 10.55.16.209 with SMTP id 78mr50119225qkq.81.1439315891637; Tue, 11 Aug 2015 10:58:11 -0700 (PDT) Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id j2si4684193qgj.0.2015.08.11.10.58.10; Tue, 11 Aug 2015 10:58:11 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received: by lists.linaro.org (Postfix, from userid 109) id 7225E6208E; Tue, 11 Aug 2015 17:58:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252.ec2.internal X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from ip-10-142-244-252.ec2.internal (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 0D27462053; Tue, 11 Aug 2015 17:58:06 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id CACD462083; Tue, 11 Aug 2015 17:58:02 +0000 (UTC) Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by lists.linaro.org (Postfix) with ESMTPS id A4E5062053 for ; Tue, 11 Aug 2015 17:58:01 +0000 (UTC) Received: by wijp15 with SMTP id p15so186811800wij.0 for ; Tue, 11 Aug 2015 10:58:00 -0700 (PDT) X-Received: by 10.180.218.227 with SMTP id pj3mr37462226wic.59.1439315880381; Tue, 11 Aug 2015 10:58:00 -0700 (PDT) Received: from [192.168.0.101] ([90.152.119.35]) by smtp.googlemail.com with ESMTPSA id fn8sm4463328wib.2.2015.08.11.10.57.59 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 11 Aug 2015 10:57:59 -0700 (PDT) Message-ID: <55CA37A7.50701@linaro.org> Date: Tue, 11 Aug 2015 18:57:59 +0100 From: Zoltan Kiss User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: lng-odp , lng-odp-dpdk References: <55C8BA7A.7010909@linaro.org> In-Reply-To: <55C8BA7A.7010909@linaro.org> Subject: Re: [lng-odp] "make check" runs tests twice X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: zoltan.kiss@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On 10/08/15 15:51, Zoltan Kiss wrote: > Hi, > > I've noticed that in ODP-DPDK "make check" runs the tests twice. I think > it's because of the Makefile.am we get from linux-generic: > > #@with_platform@ works alone in subdir but not as part of a path??? > SUBDIRS = @platform_with_platform@ \ > helper \ > test \ > @platform_with_platform_test@ \ > helper/test \ > doc \ > example \ > scripts > > So "make check" will run in @platform_with_platform@ and > @platform_with_platform_test@, and the former will also go into test to > run the tests. I think it's not necessary, can we do anything to avoid > this double run? this bit will sort it out: > I've just ran make check on latest odp.git, and it doesn't seem to run > the testcases at all, am I the only one seeing that problem? This last bit was my issue, I forgot to configure them. > > Regards, > > Zoltan diff --git a/platform/linux-dpdk/Makefile.am b/platform/linux-dpdk/Makefile.am index 71470fb..345c874 100644 --- a/platform/linux-dpdk/Makefile.am +++ b/platform/linux-dpdk/Makefile.am @@ -18,7 +18,6 @@ AM_CFLAGS += -I$(top_srcdir)/helper/include DPDK_LIBS="-ldpdk -ldl -lm -lpcap" LIBS += $(DPDK_LIBS) -SUBDIRS = test include_HEADERS = \ $(top_srcdir)/include/odp.h