From patchwork Wed Mar 23 07:20:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Uvarov X-Patchwork-Id: 64216 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp2506106lbc; Wed, 23 Mar 2016 00:21:04 -0700 (PDT) X-Received: by 10.140.138.209 with SMTP id 200mr1458991qhk.100.1458717664414; Wed, 23 Mar 2016 00:21:04 -0700 (PDT) Return-Path: Received: from lists.linaro.org (lists.linaro.org. [54.225.227.206]) by mx.google.com with ESMTP id m69si1090395qkl.67.2016.03.23.00.21.03; Wed, 23 Mar 2016 00:21:04 -0700 (PDT) Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Authentication-Results: mx.google.com; spf=pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) smtp.mailfrom=lng-odp-bounces@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id B582A6161B; Wed, 23 Mar 2016 07:21:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on ip-10-142-244-252 X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by lists.linaro.org (Postfix) with ESMTP id 82975615F4; Wed, 23 Mar 2016 07:20:58 +0000 (UTC) X-Original-To: lng-odp@lists.linaro.org Delivered-To: lng-odp@lists.linaro.org Received: by lists.linaro.org (Postfix, from userid 109) id 1813B615FB; Wed, 23 Mar 2016 07:20:56 +0000 (UTC) Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com [209.85.215.53]) by lists.linaro.org (Postfix) with ESMTPS id 1C9A7615F1 for ; Wed, 23 Mar 2016 07:20:55 +0000 (UTC) Received: by mail-lf0-f53.google.com with SMTP id o73so4597234lfe.0 for ; Wed, 23 Mar 2016 00:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=+AQv+HIV+wb/ilzS6cCibngX1AiFUam7LT60e+4MQ0E=; b=bNqyh0DR/unce4aYPXdzDVifnrPwfGd1tCw67UF2q4YHJDGgu/G/pW46MuQmty9rhE YEDIGn0YUMRxSCXno2pB+llrwuEYOg0UvCC1Ka6RA10rxTtXfWw24zctnIpbGUm6xUxR 9Qam7pf74MbzdFOu9gCPlE4+0XfOzBSa0/s0c521aYkk7DDFe/SiZ0+mLbLL0U+O1hc8 b254iQW/uLcpJaHztFhebU+bJb3Pc/TYGS9GCI52wUkbp1wjQIg90uQb0NFAla8GFNYg A/q4StcI2Z4WvbaqpIUl6BHV6+hpMe/wR5xpXhz0vLSxAJS4A3QIRZ9OozewEZ6eSNZo 51aw== X-Gm-Message-State: AD7BkJJgrPJaWbv0nlDlBEcUZ0ylZM4/pTDo2b7PfbEV8C4RIemVeENwL3j9sxQLV56Yp0oCzxk= X-Received: by 10.25.143.141 with SMTP id r135mr565140lfd.100.1458717653909; Wed, 23 Mar 2016 00:20:53 -0700 (PDT) Received: from [193.168.1.37] (ppp91-77-172-79.pppoe.mtu-net.ru. [91.77.172.79]) by smtp.gmail.com with ESMTPSA id f184sm189216lfe.6.2016.03.23.00.20.52 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Mar 2016 00:20:53 -0700 (PDT) To: Bill Fischofer References: <1456930323-45141-1-git-send-email-christophe.milard@linaro.org> <56EFEE9D.5070601@linaro.org> From: Maxim Uvarov Message-ID: <56F243D7.1060508@linaro.org> Date: Wed, 23 Mar 2016 10:20:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: X-Topics: patch Cc: LNG ODP Mailman List Subject: Re: [lng-odp] [PATCHv2 0/2] linux test for shared memory X-BeenThere: lng-odp@lists.linaro.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: "The OpenDataPlane \(ODP\) List" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" On 03/23/16 03:04, Bill Fischofer wrote: > Maxim, I had added my review in my March 2nd reply. > CC shmem_linux.o ../../../../../platform/linux-generic/test/shmem/shmem_linux.c:48:25: fatal error: shmem_linux.h: No such file or directory #include "shmem_linux.h" So final fix for latest patch is: Merged with corresponding fixes. Maxim. > On Mon, Mar 21, 2016 at 7:52 AM, Maxim Uvarov > wrote: > > does somebody also want to review that test? > > Maxim. > > > On 03/02/16 17:52, Christophe Milard wrote: > > (Note: requires: linux-generic: shmem: odp scope in /dev/shmem) > Adding a platform side test to test sharing memory between ODP > and linux. > This test is more interresting for its side effects: > *first complete test on the platform side building ODP and > platform > programs (other platform tests so far were just wrappers to > generic > platform-agnostic test) > *tests that the shared memory device name (under /dev/shm/) is > scoped > (under linux) > > Christophe Milard (2): > linux-generic: test: adding odp includes > linux-generic: test: ODP_SHM_PROC test > > platform/linux-generic/m4/configure.m4 | 1 + > platform/linux-generic/test/Makefile.am | 4 +- > platform/linux-generic/test/Makefile.inc | 16 +++ > platform/linux-generic/test/shmem/.gitignore | 2 + > platform/linux-generic/test/shmem/Makefile.am | 18 +++ > platform/linux-generic/test/shmem/shmem.h | 21 +++ > platform/linux-generic/test/shmem/shmem_common.h | 23 ++++ > platform/linux-generic/test/shmem/shmem_linux.c | 156 > +++++++++++++++++++++++ > platform/linux-generic/test/shmem/shmem_linux.h | 9 ++ > platform/linux-generic/test/shmem/shmem_odp.c | 74 > +++++++++++ > platform/linux-generic/test/shmem/shmem_odp.h | 7 + > 11 files changed, 330 insertions(+), 1 deletion(-) > create mode 100644 platform/linux-generic/test/Makefile.inc > create mode 100644 platform/linux-generic/test/shmem/.gitignore > create mode 100644 platform/linux-generic/test/shmem/Makefile.am > create mode 100644 platform/linux-generic/test/shmem/shmem.h > create mode 100644 > platform/linux-generic/test/shmem/shmem_common.h > create mode 100644 > platform/linux-generic/test/shmem/shmem_linux.c > create mode 100644 > platform/linux-generic/test/shmem/shmem_linux.h > create mode 100644 platform/linux-generic/test/shmem/shmem_odp.c > create mode 100644 platform/linux-generic/test/shmem/shmem_odp.h > > > --- a/platform/linux-generic/test/shmem/Makefile.am +++ b/platform/linux-generic/test/shmem/Makefile.am @@ -16,3 +16,5 @@ shmem_odp_CFLAGS = $(AM_CFLAGS) \ $(INCODP) shmem_odp_LDFLAGS = $(AM_LDFLAGS) shmem_odp_LDADD = $(LIBCUNIT_COMMON) $(LIBODP) + +noinst_HEADERS = shmem_common.h shmem_linux.h shmem_odp.h diff --git a/platform/linux-generic/test/shmem/shmem_linux.c b/platform/linux-generic/test/shmem/shmem_linux.c index 516bbe4..12266cc 100644 --- a/platform/linux-generic/test/shmem/shmem_linux.c +++ b/platform/linux-generic/test/shmem/shmem_linux.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2014, Linaro Limited +/* Copyright (c) 2016, Linaro Limited * All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause