mbox series

[bpf,v3,0/6] sockmap fixes

Message ID 160556562395.73229.12161576665124541961.stgit@john-XPS-13-9370
Headers show
Series sockmap fixes | expand

Message

John Fastabend Nov. 16, 2020, 10:27 p.m. UTC
This includes fixes for sockmap found after I started running skmsg and
verdict programs on systems that I use daily. To date with attached
series I've been running for multiple weeks without seeing any issues
on systems doing calls, mail, movies, etc.

Also I started running packetdrill and after this series last remaining
fix needed is to handle MSG_EOR correctly. This will come as a follow
up to this, but because we use sendpage to pass pages into TCP stack
we need to enable TCP side some.

v3:
 - Simplify patch5 as suggested by Jakub
v2:
 - Added patch3 to use truesize in sk_rmem_schedule (Daniel)
 - cleaned up some small nits... goto and extra set of brackets (Daniel)


---

John Fastabend (6):
      bpf, sockmap: fix partial copy_page_to_iter so progress can still be made
      bpf, sockmap: Ensure SO_RCVBUF memory is observed on ingress redirect
      bpf, sockmap: Use truesize with sk_rmem_schedule()
      bpf, sockmap: Avoid returning unneeded EAGAIN when redirecting to self
      bpf, sockmap: Handle memory acct if skb_verdict prog redirects to self
      bpf, sockmap: Avoid failures from skb_to_sgvec when skb has frag_list


 net/core/skmsg.c   | 87 +++++++++++++++++++++++++++++++++++++++-------
 net/ipv4/tcp_bpf.c |  3 +-
 2 files changed, 76 insertions(+), 14 deletions(-)

--
Signature

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 17, 2020, 11:20 p.m. UTC | #1
Hello:

This series was applied to bpf/bpf.git (refs/heads/master):

On Mon, 16 Nov 2020 14:27:23 -0800 you wrote:
> This includes fixes for sockmap found after I started running skmsg and

> verdict programs on systems that I use daily. To date with attached

> series I've been running for multiple weeks without seeing any issues

> on systems doing calls, mail, movies, etc.

> 

> Also I started running packetdrill and after this series last remaining

> fix needed is to handle MSG_EOR correctly. This will come as a follow

> up to this, but because we use sendpage to pass pages into TCP stack

> we need to enable TCP side some.

> 

> [...]


Here is the summary with links:
  - [bpf,v3,1/6] bpf, sockmap: fix partial copy_page_to_iter so progress can still be made
    https://git.kernel.org/bpf/bpf/c/c9c89dcd872e
  - [bpf,v3,2/6] bpf, sockmap: Ensure SO_RCVBUF memory is observed on ingress redirect
    https://git.kernel.org/bpf/bpf/c/36cd0e696a83
  - [bpf,v3,3/6] bpf, sockmap: Use truesize with sk_rmem_schedule()
    https://git.kernel.org/bpf/bpf/c/70796fb751f1
  - [bpf,v3,4/6] bpf, sockmap: Avoid returning unneeded EAGAIN when redirecting to self
    https://git.kernel.org/bpf/bpf/c/6fa9201a8989
  - [bpf,v3,5/6] bpf, sockmap: Handle memory acct if skb_verdict prog redirects to self
    https://git.kernel.org/bpf/bpf/c/2443ca66676d
  - [bpf,v3,6/6] bpf, sockmap: Avoid failures from skb_to_sgvec when skb has frag_list
    https://git.kernel.org/bpf/bpf/c/4363023d2668

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html