From patchwork Wed Jul 8 23:04:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Desaulniers X-Patchwork-Id: 235117 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp865187ilg; Wed, 8 Jul 2020 16:04:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysWqtbdgTD7flrtY19Sa9xfjKylYOpb/QxN5Jai20CoNSE0Lkce3InLywCHQvdVakOUioG X-Received: by 2002:a17:906:3152:: with SMTP id e18mr55697765eje.137.1594249455938; Wed, 08 Jul 2020 16:04:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594249455; cv=none; d=google.com; s=arc-20160816; b=qo3oSSMQutRAYhFSLHjgAUxarKLLDBTEtE+V/CqQSTPLX8mL30g3tODtgVaZALvzqt yZ3vqQeh5Wpha+OErtU0MrVghN31v1gXSzqmxOYN3QGtVPzP+xsvQX8umQf9IlbyI7nB nYhmXKY4gBU0omgQaQhpeYLAyBo11iXpcDg80anDMyP3koUkn6Ys+w1tXo9Fv9FFbTGE 3Fo4f30amx+SA9nzX2DOBkivjvBBuDIoiUD/keMfnicQuOOg9yp7wB0U/niZB+CZP+YD BXAu/DCoNYFDwGylK/jxed9Xo+gXu9cL0+HTTurkwSo23MrSkF1J/GpDXYyga37yVqeY FAYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:from:subject:mime-version :message-id:date:dkim-signature; bh=DGZPPrMYqbRCPGw2ruf3jlWhBumhoZFbDjrq5vO0KsU=; b=v4FddyTeALweUf5dCmQcoA3GDDdvpAP/qASQOlThRTO8cURPQ9XXyF1qdRakQtFcBq qHQjLeG9m9qiZWQYxILHRExuQ2xs2ViRUwTqryLpwAYJa1/hc1juxY63jNJoz8jI426s G21gZlQWdEdxGFFMBAKKeqPS5RMD+7P1GEcC33rf/+NtipjTKZbk5cpd0Js3JDr9vNB6 ZT0pszX5C8Ek7HvbDlLu8EIGiMGm9ISscpq6qyPnT7jeIPrrX0QuC1wgGqQrd3vaTZB9 kdK+zrHnzbV3QMA1Jc+AcEuccKXXJ1Nyg+uHK8BSj/gRyQKxROq8GzpbU+b722NzXmRS 5ymQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=e81AHB0M; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx8si814683ejb.415.2020.07.08.16.04.15; Wed, 08 Jul 2020 16:04:15 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=e81AHB0M; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726283AbgGHXEL (ORCPT + 9 others); Wed, 8 Jul 2020 19:04:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbgGHXEL (ORCPT ); Wed, 8 Jul 2020 19:04:11 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBFE4C061A0B for ; Wed, 8 Jul 2020 16:04:10 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 132so547778ybg.8 for ; Wed, 08 Jul 2020 16:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=DGZPPrMYqbRCPGw2ruf3jlWhBumhoZFbDjrq5vO0KsU=; b=e81AHB0M7I/PdrDpXEVdir4Vbd2bU0r/si3mFB3blJtI3pLFKCRIMOWgDXge/ue+Pg qYMCtAzEHc/TnYqS3FckXRo4TTLF49ulJwEY9oSO5TF0AfMoEr7V5dcwR1y8wS6lPznS NEvSB5AsHTo7YUNns1DjLZ/1vsDFhzSl9bmksVrTUsc0qIg7jzO5RCUIXC1oxR19td+i 38ZWOu8vlpyysjcXSnH6KzmMYAPXHdVWxRLFjLptT9E+Ub2w8o2Prbr6ihRrfsCMarI9 r2B7LDw3CtCIWWuwHPXj6kj4yXFmECdBYD9JMQe/ApU1+I5kCFFMmbt+c9OsSGoz0Nsx LzyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=DGZPPrMYqbRCPGw2ruf3jlWhBumhoZFbDjrq5vO0KsU=; b=IKSK1NbgL8vymNl9owtWISMkjvNhlT9sLrzTB3AwsVLK+6Tl0/DlkWguAb3yr+cHnL Pd+wVRZFLZHnIw7Kn6YA7pXbXHXKp61q3FPrLM9O/WVw2P+dfVIissXSZyv8UswrTglu K8XTPdUvjEMqpX8E1nDchp1yJ5qxUlLAQTwby0z2FEjuJfcsHCsymiH/PeHTJjNknRj1 NwmMWAY1aC07Rec1+mZcinCoK3HQSaW72/oSf8VQ6apmggPgxjJQ//Bwe73Pmi3lQ7H4 A142YnSSSBBOsyOozsFXnDq9OEU8UvnL72zWQTBt4rK3TCV0OKcV2m7yckto+G8dUZ7P kVbw== X-Gm-Message-State: AOAM53026ONhZzL1HUTmAkaCCDFCXG/e6JDa6/CwoVNf7I7HbVgb0ptD H9trdWk8VauHTSXe16U6rBBJmJsewrS0kNAHqsY= X-Received: by 2002:a05:6902:102e:: with SMTP id x14mr46384111ybt.461.1594249450038; Wed, 08 Jul 2020 16:04:10 -0700 (PDT) Date: Wed, 8 Jul 2020 16:04:00 -0700 Message-Id: <20200708230402.1644819-1-ndesaulniers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.27.0.383.g050319c2ae-goog Subject: [PATCH v2 0/2 net] bitfield.h cleanups From: Nick Desaulniers To: "David S . Miller" Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski , Alex Elder , Nick Desaulniers Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Two patches, one that removes a BUILD_BUG_ON for a case that is not a compile time bug (exposed by compiler optimization). The second is a general cleanup in the area. I decided to leave the BUILD_BUG_ON case first, as I hope it will simplify being able to backport it to stable, and because I don't think there's any type promotion+conversion bugs there. Though it would be nice to use consistent types widths and signedness, equality against literal zero is not an issue. Jakub Kicinski (1): bitfield.h: don't compile-time validate _val in FIELD_FIT Nick Desaulniers (1): bitfield.h: split up __BF_FIELD_CHECK macro .../netronome/nfp/nfpcore/nfp_nsp_eth.c | 11 ++++---- include/linux/bitfield.h | 26 +++++++++++++------ 2 files changed, 24 insertions(+), 13 deletions(-) -- 2.27.0.383.g050319c2ae-goog