| Message ID | 20200907101208.1223-1-pbarker@konsulko.com |
|---|---|
| Headers | show |
| Series | ksz9477 dsa switch driver improvements | expand |
On 9/7/2020 3:12 AM, Paul Barker wrote: > Always print the selected phy mode for the CPU port when using the > ksz9477 driver. If the phy mode was changed, also print the previous > mode to aid in debugging. > > To make the message more clear, prefix it with the port number which it > applies to and improve the language a little. > > Signed-off-by: Paul Barker <pbarker@konsulko.com> Once you fix the kbuild robot complaint about prev_mode not being a const char *: Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
These changes were made while debugging the ksz9477 driver for use on a custom board which uses the ksz9893 switch supported by this driver. The patches have been runtime tested on top of Linux 5.8.4, I couldn't runtime test them on top of 5.9-rc3 due to unrelated issues. They have been build tested on top of net-next. Changes from v1: * Rebased onto net-next. * Dropped unnecessary `#include <linux/printk.h>`. * Instead of printing the phy mode in `ksz9477_port_setup()`, modify the existing print in `ksz9477_config_cpu_port()` to always produce output and to be more clear. * Include Reviewed-by tag from v1 series so it isn't lost (is this correct?). Paul Barker (4): net: dsa: microchip: Make switch detection more informative net: dsa: microchip: Improve phy mode message net: dsa: microchip: Disable RGMII in-band status on KSZ9893 net: dsa: microchip: Implement recommended reset timing drivers/net/dsa/microchip/ksz9477.c | 25 ++++++++++++++++++++----- drivers/net/dsa/microchip/ksz_common.c | 3 ++- 2 files changed, 22 insertions(+), 6 deletions(-)