mbox series

[v2,bpf-next,0/4] bpf: Make the verifier recognize llvm register allocation patterns.

Message ID 20201009011240.48506-1-alexei.starovoitov@gmail.com
Headers show
Series bpf: Make the verifier recognize llvm register allocation patterns. | expand

Message

Alexei Starovoitov Oct. 9, 2020, 1:12 a.m. UTC
From: Alexei Starovoitov <ast@kernel.org>

v1->v2:
- fixed 32-bit mov issue spotted by John.
- allowed r2=r1; r3=r2; sequence as suggested by John.
- added comments, acks, more tests.

Make two verifier improvements:
- The llvm register allocator may use two different registers representing the
  same virtual register. Teach the verifier to recognize that.
- Track bounded scalar spill/fill.

The profiler[123] test in patch 3 will fail to load without patches 1 and 2.
The profiler[23] test may fail to load on older llvm due to speculative
code motion nd instruction combining optimizations that are fixed in
https://reviews.llvm.org/D85570

Alexei Starovoitov (3):
  bpf: Propagate scalar ranges through register assignments.
  selftests/bpf: Add profiler test
  selftests/bpf: Asm tests for the verifier regalloc tracking.

Yonghong Song (1):
  bpf: Track spill/fill of bounded scalars.

 kernel/bpf/verifier.c                         |  66 +-
 tools/testing/selftests/bpf/README.rst        |  38 +
 .../testing/selftests/bpf/prog_tests/align.c  |  16 +-
 .../selftests/bpf/prog_tests/test_profiler.c  |  72 ++
 tools/testing/selftests/bpf/progs/profiler.h  | 177 ++++
 .../selftests/bpf/progs/profiler.inc.h        | 969 ++++++++++++++++++
 tools/testing/selftests/bpf/progs/profiler1.c |   6 +
 tools/testing/selftests/bpf/progs/profiler2.c |   6 +
 tools/testing/selftests/bpf/progs/profiler3.c |   6 +
 .../bpf/verifier/direct_packet_access.c       |   2 +-
 .../testing/selftests/bpf/verifier/regalloc.c | 243 +++++
 11 files changed, 1591 insertions(+), 10 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/test_profiler.c
 create mode 100644 tools/testing/selftests/bpf/progs/profiler.h
 create mode 100644 tools/testing/selftests/bpf/progs/profiler.inc.h
 create mode 100644 tools/testing/selftests/bpf/progs/profiler1.c
 create mode 100644 tools/testing/selftests/bpf/progs/profiler2.c
 create mode 100644 tools/testing/selftests/bpf/progs/profiler3.c
 create mode 100644 tools/testing/selftests/bpf/verifier/regalloc.c

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 9, 2020, 8:10 p.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (refs/heads/master):

On Thu,  8 Oct 2020 18:12:36 -0700 you wrote:
> From: Alexei Starovoitov <ast@kernel.org>
> 
> v1->v2:
> - fixed 32-bit mov issue spotted by John.
> - allowed r2=r1; r3=r2; sequence as suggested by John.
> - added comments, acks, more tests.
> 
> [...]

Here is the summary with links:
  - [v2,bpf-next,1/4] bpf: Propagate scalar ranges through register assignments.
    https://git.kernel.org/bpf/bpf-next/c/75748837b7e5
  - [v2,bpf-next,2/4] bpf: Track spill/fill of bounded scalars.
    https://git.kernel.org/bpf/bpf-next/c/5689d49b71ad
  - [v2,bpf-next,3/4] selftests/bpf: Add profiler test
    https://git.kernel.org/bpf/bpf-next/c/03d4d13fab3f
  - [v2,bpf-next,4/4] selftests/bpf: Asm tests for the verifier regalloc tracking.
    https://git.kernel.org/bpf/bpf-next/c/54fada41e8a1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html