mbox series

[net-next,00/15] net/smc: extend diagnostic netlink interface

Message ID 20201102193409.70901-1-kgraul@linux.ibm.com
Headers show
Series net/smc: extend diagnostic netlink interface | expand

Message

Karsten Graul Nov. 2, 2020, 7:33 p.m. UTC 
Please apply the following patch series for smc to netdev's net-next tree.

This patch series refactors the current netlink API in smc_diag module
which is used for diagnostic purposes and extends the netlink API in a
backward compatible way so that the extended API can provide information
about SMC linkgroups, links and devices (both for SMC-R and SMC-D) and
can still work with the legacy netlink API.

Please note that patch 9 triggers a checkpatch warning because a comment
line was added using the style of the already existing comment block.

Guvenc Gulce (14):
  net/smc: Use active link of the connection
  net/smc: Add connection counters for links
  net/smc: Add link counters for IB device ports
  net/smc: Add diagnostic information to smc ib-device
  net/smc: Add diagnostic information to link structure
  net/smc: Refactor the netlink reply processing routine
  net/smc: Add ability to work with extended SMC netlink API
  net/smc: Introduce SMCR get linkgroup command
  net/smc: Introduce SMCR get link command
  net/smc: Add SMC-D Linkgroup diagnostic support
  net/smc: Add support for obtaining SMCD device list
  net/smc: Add support for obtaining SMCR device list
  net/smc: Refactor smc ism v2 capability handling
  net/smc: Add support for obtaining system information

Karsten Graul (1):
  net/smc: use helper smc_conn_abort() in listen processing

 include/net/smc.h             |   2 +-
 include/uapi/linux/smc.h      |   8 +
 include/uapi/linux/smc_diag.h | 108 +++++
 net/smc/af_smc.c              |  29 +-
 net/smc/smc.h                 |   5 +-
 net/smc/smc_clc.c             |   6 +
 net/smc/smc_clc.h             |   1 +
 net/smc/smc_core.c            |  32 +-
 net/smc/smc_core.h            |  32 +-
 net/smc/smc_diag.c            | 766 +++++++++++++++++++++++++++++-----
 net/smc/smc_ib.c              |  49 +++
 net/smc/smc_ib.h              |   4 +-
 net/smc/smc_ism.c             |  12 +-
 net/smc/smc_ism.h             |   5 +-
 net/smc/smc_pnet.c            |   3 +
 15 files changed, 938 insertions(+), 124 deletions(-)

Comments

Jakub Kicinski Nov. 2, 2020, 10:12 p.m. UTC | #1 
On Mon,  2 Nov 2020 20:34:04 +0100 Karsten Graul wrote:
> +	__u8 netdev[IFNAMSIZ];		/* ethernet device name */


In file included from <command-line>:32:
./usr/include/linux/smc_diag.h:135:14: error: ‘IFNAMSIZ’ undeclared here (not in a function)
  135 |  __u8 netdev[IFNAMSIZ];  /* ethernet device name */
      |              ^~~~~~~~
make[3]: *** [usr/include/linux/smc_diag.hdrtest] Error 1
make[2]: *** [usr/include] Error 2
make[1]: *** [usr] Error 2
make[1]: *** Waiting for unfinished jobs....
make[1]: *** wait: No child processes.  Stop.
make: *** [__sub-make] Error 2
In file included from <command-line>:32:
./usr/include/linux/smc_diag.h:135:14: error: ‘IFNAMSIZ’ undeclared here (not in a function)
  135 |  __u8 netdev[IFNAMSIZ];  /* ethernet device name */
      |              ^~~~~~~~