| Message ID | 20201209140501.17415-1-i.mikhaylov@yadro.com |
|---|---|
| Headers | show |
| Series | Add LED mode behavior/select properties and handle | expand |
On Wed, Dec 09, 2020 at 05:04:59PM +0300, Ivan Mikhaylov wrote: > In KSZ9131 PHY it is possible to control LEDs blink behavior via > LED mode behavior and select registers. Add DTS properties plus handles > of them inside micrel PHY driver. > > I've some concerns about passing raw register values into LED mode > select and behavior. There was been some work done allowing PHY LEDs to be controlled just like other LEDs in Linux. That is how this should be done. Please go look back in the netdev and LED mailing list archives, and join that work. Andrew
Hi! > In KSZ9131 PHY it is possible to control LEDs blink behavior via > LED mode behavior and select registers. Add DTS properties plus handles > of them inside micrel PHY driver. > > I've some concerns about passing raw register values into LED mode > select and behavior. It can be passed via array like in microchip > driver(Documentation/devicetree/bindings/net/microchip,lan78xx.txt). > There is the problem in this particular driver - there is a lot of other PHYs > and led mode behavior/select states may intersect, that's the reason why > I did it this way. Is there any good ways to make it look more > properly? Lets... not do this? We have a LED subsystem which should probably control the LEDs... so user can specify behaviours at run-time, instead of them being hard-coded in the device tree. Plus, LED subsystem will use same interface for networks LEDs as for ... other LEDs. Best regards, Pavel
In KSZ9131 PHY it is possible to control LEDs blink behavior via LED mode behavior and select registers. Add DTS properties plus handles of them inside micrel PHY driver. I've some concerns about passing raw register values into LED mode select and behavior. It can be passed via array like in microchip driver(Documentation/devicetree/bindings/net/microchip,lan78xx.txt). There is the problem in this particular driver - there is a lot of other PHYs and led mode behavior/select states may intersect, that's the reason why I did it this way. Is there any good ways to make it look more properly? Ivan Mikhaylov (2): net: phy: micrel: add LED control on KSZ9131 dt-bindings: net: phy: micrel: add LED mode behavior and select properties .../devicetree/bindings/net/micrel.txt | 7 ++ drivers/net/phy/micrel.c | 69 ++++++++++++++++++- 2 files changed, 75 insertions(+), 1 deletion(-)