mbox series

[net-next,0/7] a set of fixes of coding style

Message ID 20210112064305.31606-1-lijunp213@gmail.com
Headers show
Series a set of fixes of coding style | expand

Message

Lijun Pan Jan. 12, 2021, 6:42 a.m. UTC 
This series address several coding style problems.

Lijun Pan (7):
  ibmvnic: prefer 'unsigned long' over 'unsigned long int'
  ibmvnic: fix block comments
  ibmvnic: fix braces
  ibmvnic: avoid multiple line dereference
  ibmvnic: fix miscellaneous checks
  ibmvnic: add comments for spinlock_t definitions
  ibmvnic: remove unused spinlock_t stats_lock definition

 drivers/net/ethernet/ibm/ibmvnic.c | 65 +++++++++++++-----------------
 drivers/net/ethernet/ibm/ibmvnic.h | 11 ++---
 2 files changed, 35 insertions(+), 41 deletions(-)

Comments

Jakub Kicinski Jan. 12, 2021, 11:54 p.m. UTC | #1 
On Tue, 12 Jan 2021 00:42:58 -0600 Lijun Pan wrote:
> This series address several coding style problems.


Erm, are you sure this series will not conflict with the fixes
Sukadev is sending?
Lijun Pan Jan. 13, 2021, 6:04 a.m. UTC | #2 
On Tue, Jan 12, 2021 at 5:54 PM Jakub Kicinski <kuba@kernel.org> wrote:
>

> On Tue, 12 Jan 2021 00:42:58 -0600 Lijun Pan wrote:

> > This series address several coding style problems.

>

> Erm, are you sure this series will not conflict with the fixes

> Sukadev is sending?


Maybe one or two if the fixes go to net. And not if they all
go to net-next. It looks like they going to net-next would be
a simpler solution for both of us.
It seems to me Suka's patches are more of refactoring and feature
changes (a new approach) though some of them claim to fix some bugs.