mbox series

[net,0/8,pull,request] Intel Wired LAN Driver Updates 2021-02-18

Message ID 20210218232504.2422834-1-anthony.l.nguyen@intel.com
Headers show
Series Intel Wired LAN Driver Updates 2021-02-18 | expand

Message

Tony Nguyen Feb. 18, 2021, 11:24 p.m. UTC
This series contains updates to i40e driver only.

Slawomir resolves an issue with the IPv6 extension headers being
processed incorrectly.

Keita Suzuki fixes a memory leak on probe failure.

Mateusz initializes AQ command structures to zero to comply with
spec, fixes FW flow control settings being overwritten and resolves an
issue with adding VLAN filters after enabling FW LLDP. He also adds
an additional check when adding TC filter as the current check doesn't
properly distinguish between IPv4 and IPv6.

Sylwester removes setting disabled bit when syncing filters as this
prevents VFs from completing setup.

Norbert cleans up sparse warnings.

The following are changes since commit 3af409ca278d4a8d50e91f9f7c4c33b175645cf3:
  net: enetc: fix destroyed phylink dereference during unbind
and are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue 40GbE

Keita Suzuki (1):
  i40e: Fix memory leak in i40e_probe

Mateusz Palczewski (4):
  i40e: Add zero-initialization of AQ command structures
  i40e: Fix overwriting flow control settings during driver loading
  i40e: Fix addition of RX filters after enabling FW LLDP agent
  i40e: Fix add TC filter for IPv6

Norbert Ciosek (1):
  i40e: Fix endianness conversions

Slawomir Laba (1):
  i40e: Fix flow for IPv6 next header (extension header)

Sylwester Dziedziuch (1):
  i40e: Fix VFs not created

 .../net/ethernet/intel/i40e/i40e_ethtool.c    | 16 +++--
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 64 +++++++------------
 drivers/net/ethernet/intel/i40e/i40e_txrx.c   | 11 ++--
 drivers/net/ethernet/intel/i40e/i40e_xsk.c    |  2 +-
 4 files changed, 39 insertions(+), 54 deletions(-)

Comments

Jakub Kicinski Feb. 19, 2021, 5:31 p.m. UTC | #1
On Thu, 18 Feb 2021 15:25:03 -0800 Tony Nguyen wrote:
> From: Mateusz Palczewski <mateusz.palczewski@intel.com>

> 

> Fix insufficient distinction between IPv4 and IPv6 addresses

> when creating a filter.

> IPv4 and IPv6 are kept in the same memory area. If IPv6 is added,

> then it's caught by IPv4 check, which leads to err -95.

> 

> Fixes: 2f4b411a3d67("i40e: Enable cloud filters via tc-flower")


Small issue with the fixes tag here - missing space after hash.

Dave said he can't take any patches until Linus gets power back and
pulls so since we're waiting perhaps you could fix and repost?

The patches look good to me.
Tony Nguyen Feb. 19, 2021, 6:06 p.m. UTC | #2
On Fri, 2021-02-19 at 09:31 -0800, Jakub Kicinski wrote:
> On Thu, 18 Feb 2021 15:25:03 -0800 Tony Nguyen wrote:

> > From: Mateusz Palczewski <mateusz.palczewski@intel.com>

> > 

> > Fix insufficient distinction between IPv4 and IPv6 addresses

> > when creating a filter.

> > IPv4 and IPv6 are kept in the same memory area. If IPv6 is added,

> > then it's caught by IPv4 check, which leads to err -95.

> > 

> > Fixes: 2f4b411a3d67("i40e: Enable cloud filters via tc-flower")

> 

> Small issue with the fixes tag here - missing space after hash.

> 

> Dave said he can't take any patches until Linus gets power back and

> pulls so since we're waiting perhaps you could fix and repost?

> 

> The patches look good to me.


Thanks for the review Jakub. Sure, I'll fix and repost.

- Tony