mbox series

[v1,0/2] net: xfrm: Use seqcount_spinlock_t

Message ID 20210316105630.1020270-1-a.darwish@linutronix.de
Headers show
Series net: xfrm: Use seqcount_spinlock_t | expand

Message

Ahmed S. Darwish March 16, 2021, 10:56 a.m. UTC 
Hi,

This is a small series to trasform xfrm_state_hash_generation sequence
counter to seqcount_spinlock_t, instead of plain seqcount_t.

In general, seqcount_LOCKNAME_t sequence counters allows to associate
the lock used for write serialization with the seqcount. This enables
lockdep to verify that the write serialization lock is always held
before entering the seqcount write section.

If lockdep is disabled, this lock association is compiled out and has
neither storage size nor runtime overhead.

The first patch is a general mainline fix, and has a Fixes tag.

Thanks,

8<----------

Ahmed S. Darwish (2):
  net: xfrm: Localize sequence counter per network namespace
  net: xfrm: Use sequence counter with associated spinlock

 include/net/netns/xfrm.h |  4 +++-
 net/xfrm/xfrm_state.c    | 11 ++++++-----
 2 files changed, 9 insertions(+), 6 deletions(-)

base-commit: 1e28eed17697bcf343c6743f0028cc3b5dd88bf0
--
2.30.2

Comments

Steffen Klassert March 23, 2021, 8:13 a.m. UTC | #1 
On Tue, Mar 16, 2021 at 11:56:28AM +0100, Ahmed S. Darwish wrote:
> Hi,

> 

> This is a small series to trasform xfrm_state_hash_generation sequence

> counter to seqcount_spinlock_t, instead of plain seqcount_t.

> 

> In general, seqcount_LOCKNAME_t sequence counters allows to associate

> the lock used for write serialization with the seqcount. This enables

> lockdep to verify that the write serialization lock is always held

> before entering the seqcount write section.

> 

> If lockdep is disabled, this lock association is compiled out and has

> neither storage size nor runtime overhead.

> 

> The first patch is a general mainline fix, and has a Fixes tag.

> 

> Thanks,

> 

> 8<----------

> 

> Ahmed S. Darwish (2):

>   net: xfrm: Localize sequence counter per network namespace

>   net: xfrm: Use sequence counter with associated spinlock


Applied to the ipsec tree, thanks a lot!