mbox series

[v3,bpf-next,0/2] Provide NULL and KERNEL_VERSION macros in bpf_helpers.h

Message ID 20210317200510.1354627-1-andrii@kernel.org
Headers show
Series Provide NULL and KERNEL_VERSION macros in bpf_helpers.h | expand

Message

Andrii Nakryiko March 17, 2021, 8:05 p.m. UTC
Provide NULL and KERNEL_VERSION macros in bpf_helpers.h. Patch #2 removes such
custom NULL definition from one of the selftests.

v2->v3:
  - instead of vmlinux.h, do this in bpf_helpers.h;
  - added KERNEL_VERSION, which comes up periodically as well;
  - I dropped strict compilation patches for now, because we run into new
    warnings (e.g., not checking read() result) in kernel-patches CI, which
    I can't even reproduce locally. Also -Wdiscarded-qualifiers pragma for
    jit_disasm.c is not supported by Clang, it needs to be
    -Wincompatible-pointer-types-discards-qualifiers for Clang; we don't have
    to deal with that in this patch set;
v1->v2:
  - fix few typos and wrong copy/paste;
  - fix #pragma push -> pop.

Andrii Nakryiko (2):
  libbpf: provide NULL and KERNEL_VERSION macros in bpf_helpers.h
  selftests/bpf: drop custom NULL #define in skb_pkt_end selftest

 tools/lib/bpf/bpf_helpers.h                     | 16 +++++++++++++++-
 tools/testing/selftests/bpf/progs/skb_pkt_end.c |  1 -
 2 files changed, 15 insertions(+), 2 deletions(-)

Comments

Alexei Starovoitov March 18, 2021, 3:28 a.m. UTC | #1
On 3/17/21 1:05 PM, Andrii Nakryiko wrote:
> Provide NULL and KERNEL_VERSION macros in bpf_helpers.h. Patch #2 removes such

> custom NULL definition from one of the selftests.

> 

> v2->v3:

>    - instead of vmlinux.h, do this in bpf_helpers.h;

>    - added KERNEL_VERSION, which comes up periodically as well;

>    - I dropped strict compilation patches for now, because we run into new

>      warnings (e.g., not checking read() result) in kernel-patches CI, which

>      I can't even reproduce locally. Also -Wdiscarded-qualifiers pragma for

>      jit_disasm.c is not supported by Clang, it needs to be

>      -Wincompatible-pointer-types-discards-qualifiers for Clang; we don't have

>      to deal with that in this patch set;

> v1->v2:

>    - fix few typos and wrong copy/paste;

>    - fix #pragma push -> pop.


Applied.