| Message ID | 20210423100446.15412-1-magnus.karlsson@gmail.com |
|---|---|
| Headers | show |
| Series | i40e: ice: ixgbe: ixgbevf: igb: add correct exception tracing for XDP | expand |
On Fri, 2021-04-23 at 12:04 +0200, Magnus Karlsson wrote: > Add missing exception tracing to XDP when a number of different > errors > can occur. The support was only partial. Several errors where not > logged which would confuse the user quite a lot not knowing where and > why the packets disappeared. > > This patch set fixes this for all Intel drivers with XDP support. > > Thanks: Magnus This doesn't apply anymore with the 5.13 patches. It looks like your "optimize for XDP_REDIRECT in xsk path" patches are conflicting with some of these. Did you want to rework them? Thanks, Tony > Magnus Karlsson (5): > i40e: add correct exception tracing for XDP > ice: add correct exception tracing for XDP > ixgbe: add correct exception tracing for XDP > igb add correct exception tracing for XDP > ixgbevf: add correct exception tracing for XDP > > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++++- > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 7 ++++++- > drivers/net/ethernet/intel/ice/ice_txrx.c | 12 +++++++++--- > drivers/net/ethernet/intel/ice/ice_xsk.c | 7 ++++++- > drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++---- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++---- > ---- > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 13 ++++++++----- > .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++ > 8 files changed, 52 insertions(+), 23 deletions(-) > > > base-commit: bb556de79f0a9e647e8febe15786ee68483fa67b > -- > 2.29.0
On Sat, May 8, 2021 at 12:58 AM Nguyen, Anthony L <anthony.l.nguyen@intel.com> wrote: > > On Fri, 2021-04-23 at 12:04 +0200, Magnus Karlsson wrote: > > Add missing exception tracing to XDP when a number of different > > errors > > can occur. The support was only partial. Several errors where not > > logged which would confuse the user quite a lot not knowing where and > > why the packets disappeared. > > > > This patch set fixes this for all Intel drivers with XDP support. > > > > Thanks: Magnus > > This doesn't apply anymore with the 5.13 patches. It looks like your > "optimize for XDP_REDIRECT in xsk path" patches are conflicting with > some of these. Did you want to rework them? I will rebase them and resubmit. > Thanks, > Tony > > > Magnus Karlsson (5): > > i40e: add correct exception tracing for XDP > > ice: add correct exception tracing for XDP > > ixgbe: add correct exception tracing for XDP > > igb add correct exception tracing for XDP > > ixgbevf: add correct exception tracing for XDP > > > > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 7 ++++++- > > drivers/net/ethernet/intel/i40e/i40e_xsk.c | 7 ++++++- > > drivers/net/ethernet/intel/ice/ice_txrx.c | 12 +++++++++--- > > drivers/net/ethernet/intel/ice/ice_xsk.c | 7 ++++++- > > drivers/net/ethernet/intel/igb/igb_main.c | 10 ++++++---- > > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++---- > > ---- > > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 13 ++++++++----- > > .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 3 +++ > > 8 files changed, 52 insertions(+), 23 deletions(-) > > > > > > base-commit: bb556de79f0a9e647e8febe15786ee68483fa67b > > -- > > 2.29.0
On Mon, 10 May 2021 08:06:00 +0200 Magnus Karlsson <magnus.karlsson@gmail.com> wrote: > On Sat, May 8, 2021 at 12:58 AM Nguyen, Anthony L > <anthony.l.nguyen@intel.com> wrote: > > > > On Fri, 2021-04-23 at 12:04 +0200, Magnus Karlsson wrote: > > > Add missing exception tracing to XDP when a number of different errors > > > can occur. The support was only partial. Several errors where not > > > logged which would confuse the user quite a lot not knowing where and > > > why the packets disappeared. > > > > > > This patch set fixes this for all Intel drivers with XDP support. > > > > > > Thanks: Magnus > > > > This doesn't apply anymore with the 5.13 patches. It looks like your > > "optimize for XDP_REDIRECT in xsk path" patches are conflicting with > > some of these. Did you want to rework them? > > I will rebase them and resubmit. Thanks for working on this Magnus, highly appreciated. This should help end-users troubleshoot these kind of 'exception' packet drops. We have people that will look at updating the sample/bpf/ programs (that does XDP redirect) to report on these exception errors/drops. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Magnus Karlsson > Sent: Friday, April 23, 2021 3:35 PM > To: Karlsson, Magnus <magnus.karlsson@intel.com>; intel-wired- > lan@lists.osuosl.org; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; > Fijalkowski, Maciej <maciej.fijalkowski@intel.com> > Cc: netdev@vger.kernel.org; brouer@redhat.com > Subject: [Intel-wired-lan] [PATCH intel-net 3/5] ixgbe: add correct exception > tracing for XDP > > From: Magnus Karlsson <magnus.karlsson@intel.com> > > Add missing exception tracing to XDP when a number of different errors can > occur. The support was only partial. Several errors where not logged which > would confuse the user quite a lot not knowing where and why the packets > disappeared. > > Fixes: 33fdc82f0883 ("ixgbe: add support for XDP_TX action") > Fixes: d0bcacd0a130 ("ixgbe: add AF_XDP zero-copy Rx support") > Reported-by: Jesper Dangaard Brouer <brouer@redhat.com> > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 16 ++++++++-------- > drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c | 13 ++++++++----- > 2 files changed, 16 insertions(+), 13 deletions(-) > Tested-by: Vishakha Jambekar<vishakha.jambekar@intel.com>