mbox series

[PACTH,ethtool-next,v3,0/7] ethtool: support FEC and standard stats

Message ID 20210503160830.555241-1-kuba@kernel.org
Headers show
Series ethtool: support FEC and standard stats | expand

Message

Jakub Kicinski May 3, 2021, 4:08 p.m. UTC 
This series adds support for FEC requests via netlink
and new "standard" stats.

Changes from v2:
 - update headers
 - fix --disable-netlink build
 - rename equivalency groups to alternatives
Changes from v1:
 - rebase on next, only conflicts in uAPI update
 - fix the trailing "and" in patch 6
Changes compared to RFC:
 - improve commit messages
 - fix Rx vs Tx histogram in JSON
 - make histograms less hardcoded to RMON
 - expand man page entry for -S a little
 - add --all-groups (last patch)

Jakub Kicinski (7):
  update UAPI header copies
  json: improve array print API
  netlink: add FEC support
  netlink: fec: support displaying statistics
  ethtool: add nlchk for redirecting to netlink
  netlink: add support for standard stats
  netlink: stats: add an --all-groups option

 Makefile.am                  |   3 +-
 ethtool.8.in                 |  23 ++-
 ethtool.c                    |  12 +-
 json_print.c                 |  20 +-
 json_print.h                 |   4 +-
 netlink/desc-ethtool.c       |  51 +++++
 netlink/extapi.h             |  14 +-
 netlink/fec.c                | 359 +++++++++++++++++++++++++++++++++++
 netlink/monitor.c            |   4 +
 netlink/netlink.c            |   9 +-
 netlink/netlink.h            |   1 +
 netlink/parser.c             |  17 +-
 netlink/parser.h             |   4 +
 netlink/stats.c              | 319 +++++++++++++++++++++++++++++++
 uapi/linux/ethtool.h         | 109 +++++++----
 uapi/linux/ethtool_netlink.h | 187 ++++++++++++++++++
 uapi/linux/if_link.h         |   2 +-
 uapi/linux/rtnetlink.h       |  13 ++
 18 files changed, 1096 insertions(+), 55 deletions(-)
 create mode 100644 netlink/fec.c
 create mode 100644 netlink/stats.c

Comments

Jakub Kicinski May 18, 2021, 10:42 p.m. UTC | #1 
On Mon,  3 May 2021 09:08:23 -0700 Jakub Kicinski wrote:
> This series adds support for FEC requests via netlink

> and new "standard" stats.


Anything I can do to help with those? They disappeared from 
patchwork due to auto archiving being set to 2 weeks.
patchwork-bot+netdevbpf@kernel.org May 20, 2021, 3:30 p.m. UTC | #2 
Hello:

This series was applied to ethtool/ethtool.git (refs/heads/master):

On Mon,  3 May 2021 09:08:23 -0700 you wrote:
> This series adds support for FEC requests via netlink

> and new "standard" stats.

> 

> Changes from v2:

>  - update headers

>  - fix --disable-netlink build

>  - rename equivalency groups to alternatives

> Changes from v1:

>  - rebase on next, only conflicts in uAPI update

>  - fix the trailing "and" in patch 6

> Changes compared to RFC:

>  - improve commit messages

>  - fix Rx vs Tx histogram in JSON

>  - make histograms less hardcoded to RMON

>  - expand man page entry for -S a little

>  - add --all-groups (last patch)

> 

> [...]


Here is the summary with links:
  - [PACTH,ethtool-next,v3,1/7] update UAPI header copies
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=eb2d0a980c46
  - [PACTH,ethtool-next,v3,2/7] json: improve array print API
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=8a6250926b52
  - [PACTH,ethtool-next,v3,3/7] netlink: add FEC support
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=38cd721796f8
  - [PACTH,ethtool-next,v3,4/7] netlink: fec: support displaying statistics
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=8145f9521b75
  - [PACTH,ethtool-next,v3,5/7] ethtool: add nlchk for redirecting to netlink
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=67a9ef551661
  - [PACTH,ethtool-next,v3,6/7] netlink: add support for standard stats
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=f8d2bc2ccd8b
  - [PACTH,ethtool-next,v3,7/7] netlink: stats: add an --all-groups option
    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=02255f29f38d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Michal Kubecek May 20, 2021, 3:44 p.m. UTC | #3 
On Tue, May 18, 2021 at 03:42:14PM -0700, Jakub Kicinski wrote:
> On Mon,  3 May 2021 09:08:23 -0700 Jakub Kicinski wrote:

> > This series adds support for FEC requests via netlink

> > and new "standard" stats.

> 

> Anything I can do to help with those? They disappeared from 

> patchwork due to auto archiving being set to 2 weeks.


Sorry for the delay, the series is applied now (with one additional
commit masking spurious "make check" failure).

Michal
Jakub Kicinski May 20, 2021, 3:47 p.m. UTC | #4 
On Thu, 20 May 2021 17:44:18 +0200 Michal Kubecek wrote:
> On Tue, May 18, 2021 at 03:42:14PM -0700, Jakub Kicinski wrote:

> > On Mon,  3 May 2021 09:08:23 -0700 Jakub Kicinski wrote:  

> > > This series adds support for FEC requests via netlink

> > > and new "standard" stats.  

> > 

> > Anything I can do to help with those? They disappeared from 

> > patchwork due to auto archiving being set to 2 weeks.  

> 

> Sorry for the delay, the series is applied now (with one additional

> commit masking spurious "make check" failure).


Thank you!