mbox series

[net-next,v4,0/2] bnxt: add rx discards stats for oom and netpool

Message ID 20210827152745.68812-1-kuba@kernel.org
Headers show
Series bnxt: add rx discards stats for oom and netpool | expand

Message

Jakub Kicinski Aug. 27, 2021, 3:27 p.m. UTC 
Drivers should avoid silently dropping frames. This set adds two
stats for previously unaccounted events to bnxt - packets dropped
due to allocation failures and packets dropped during emergency
ring polling.

v4: drop patch 1, not needed after simplifications

Jakub Kicinski (2):
  bnxt: count packets discarded because of netpoll
  bnxt: count discards due to memory allocation errors

 drivers/net/ethernet/broadcom/bnxt/bnxt.c      | 18 +++++++++++++++++-
 drivers/net/ethernet/broadcom/bnxt/bnxt.h      |  2 ++
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c  |  4 ++++
 3 files changed, 23 insertions(+), 1 deletion(-)

Comments

Michael Chan Aug. 27, 2021, 6:23 p.m. UTC | #1 
On Fri, Aug 27, 2021 at 8:27 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Drivers should avoid silently dropping frames. This set adds two
> stats for previously unaccounted events to bnxt - packets dropped
> due to allocation failures and packets dropped during emergency
> ring polling.
>
> v4: drop patch 1, not needed after simplifications

Thanks.
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Edwin Peer Aug. 27, 2021, 7 p.m. UTC | #2 
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>

Regards,
Edwin Peer


On Fri, Aug 27, 2021 at 8:27 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Drivers should avoid silently dropping frames. This set adds two
> stats for previously unaccounted events to bnxt - packets dropped
> due to allocation failures and packets dropped during emergency
> ring polling.
>
> v4: drop patch 1, not needed after simplifications
>
> Jakub Kicinski (2):
>   bnxt: count packets discarded because of netpoll
>   bnxt: count discards due to memory allocation errors
>
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c      | 18 +++++++++++++++++-
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h      |  2 ++
>  .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c  |  4 ++++
>  3 files changed, 23 insertions(+), 1 deletion(-)
>
> --
> 2.31.1
>
Jakub Kicinski Aug. 28, 2021, 12:16 a.m. UTC | #3 
On Fri, 27 Aug 2021 11:23:47 -0700 Michael Chan wrote:
> On Fri, Aug 27, 2021 at 8:27 AM Jakub Kicinski <kuba@kernel.org> wrote:

> > Drivers should avoid silently dropping frames. This set adds two

> > stats for previously unaccounted events to bnxt - packets dropped

> > due to allocation failures and packets dropped during emergency

> > ring polling.

> >

> > v4: drop patch 1, not needed after simplifications  

> 

> Reviewed-by: Michael Chan <michael.chan@broadcom.com>


Thank you for the reviews, applied!