| Message ID | 20210914112738.358627-1-idosch@idosch.org |
|---|---|
| Headers | show |
| Series | ethtool: Module EEPROM fixes | expand |
Hello: This series was applied to ethtool/ethtool.git (refs/heads/master): On Tue, 14 Sep 2021 14:27:33 +0300 you wrote: > From: Ido Schimmel <idosch@nvidia.com> > > This patchset contains fixes for various issues I noticed while working > on the module EEPROM parsing code. > > In addition to these fixes, I have the following submissions ready for > the next branch [1]: > > [...] Here is the summary with links: - [ethtool,1/5] sff-8636: Fix parsing of Page 03h in IOCTL path https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=769a50e66b11 - [ethtool,2/5] cmis: Fix invalid memory access in IOCTL path https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=7e153a7da4f1 - [ethtool,3/5] netlink: eeprom: Fallback to IOCTL when a complete hex/raw dump is requested https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=2ddb1a1f06e2 - [ethtool,4/5] ethtool: Fix compilation warning when pretty dump is disabled https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=d02409cc1788 - [ethtool,5/5] netlink: eeprom: Fix compilation when pretty dump is disabled https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=a7431bc5ab09 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
From: Ido Schimmel <idosch@nvidia.com> This patchset contains fixes for various issues I noticed while working on the module EEPROM parsing code. In addition to these fixes, I have the following submissions ready for the next branch [1]: * Trivial coding style / documentation changes * Reworking the EEPROM parsing code to use a memory map with pointers to individual pages as the current state is sub-optimal. In the IOCTL path, one large buffer is passed to parsers (e.g., SFF-8636, CMIS). In the netlink path, individual pages are passed, some of which might not be valid. With the proposed changes, the IOCTL and netlink paths only differ in the way they initialize the memory map. The parsing code is completely shared * Extending the CMIS parser to request and parse diagnostic information (already present in SFF-8636) from optional / banked pages [1] https://github.com/idosch/ethtool/commits/submit/cmis_dump_v1 Ido Schimmel (5): sff-8636: Fix parsing of Page 03h in IOCTL path cmis: Fix invalid memory access in IOCTL path netlink: eeprom: Fallback to IOCTL when a complete hex/raw dump is requested ethtool: Fix compilation warning when pretty dump is disabled netlink: eeprom: Fix compilation when pretty dump is disabled cmis.c | 2 +- ethtool.c | 13 ++++++++----- netlink/module-eeprom.c | 14 ++++++++++++++ qsfp.c | 2 +- 4 files changed, 24 insertions(+), 7 deletions(-)