mbox series

[0/3] net: macb: add support for MII on RGMII interface

Message ID 20210915064721.5530-1-claudiu.beznea@microchip.com
Headers show
Series net: macb: add support for MII on RGMII interface | expand

Message

Claudiu Beznea Sept. 15, 2021, 6:47 a.m. UTC 
Hi,

This series adds support for MII mode on RGMII interface (patch 3/3).
Along with this the series also contains minor cleanups (patches 1/3, 2/3)
on macb.h.

Thank you,
Claudiu Beznea

Claudiu Beznea (3):
  net: macb: add description for SRTSM
  net: macb: align for OSSMODE offset
  net: macb: add support for mii on rgmii

 drivers/net/ethernet/cadence/macb.h      | 7 +++++--
 drivers/net/ethernet/cadence/macb_main.c | 3 +++
 2 files changed, 8 insertions(+), 2 deletions(-)

Comments

Andrew Lunn Sept. 16, 2021, 1:03 p.m. UTC | #1 
On Wed, Sep 15, 2021 at 09:47:21AM +0300, Claudiu Beznea wrote:
> Cadence IP has option to enable MII support on RGMII interface. This

> could be selected though bit 28 of network control register. This option

> is not enabled on all the IP versions thus add a software capability to

> be selected by the proper implementation of this IP.


Hi Claudiu

You are adding a feature without a user. That is generally not
accepted. Could you please also extend one of the macb_config structs
to make use of this?

Thanks
	Andrew
Claudiu Beznea Sept. 17, 2021, 1:29 p.m. UTC | #2 
Hi Andrew,

On 16.09.2021 16:03, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

> 

> On Wed, Sep 15, 2021 at 09:47:21AM +0300, Claudiu Beznea wrote:

>> Cadence IP has option to enable MII support on RGMII interface. This

>> could be selected though bit 28 of network control register. This option

>> is not enabled on all the IP versions thus add a software capability to

>> be selected by the proper implementation of this IP.

> 

> Hi Claudiu

> 

> You are adding a feature without a user. That is generally not

> accepted.


That's true. For whatever reason I haven't added proper flags to
macb_config objects. I've send a new version with updates.

Thank you for your review,
Claudiu Beznea

> Could you please also extend one of the macb_config structs

> to make use of this?

> 

> Thanks

>         Andrew

>