| Message ID | cover.1627404470.git.paskripkin@gmail.com |
|---|---|
| Headers | show |
| Series | can: fix same memory leaks in can drivers | expand |
On 27.07.2021 19:59:12, Pavel Skripkin wrote: > Hi, Marc and can drivers maintainers/reviewers! > > A long time ago syzbot reported memory leak in mcba_usb can driver[1]. It was > using strange pattern for allocating coherent buffers, which was leading to > memory leaks. I fixed this wrong pattern in mcba_usb driver and yesterday I got > a report, that mcba_usb stopped working since my commit. I came up with quick fix > and all started working well. > > There are at least 3 more drivers with this pattern, I decided to fix leaks > in them too, since code is actually the same (I guess, driver authors just copy pasted > code parts). Each of following patches is combination of 91c02557174b > ("can: mcba_usb: fix memory leak in mcba_usb") and my yesterday fix [2]. > > > Dear maintainers/reviewers, if You have one of these hardware pieces, please, test > these patches and report any errors you will find. Added to linux-can-next/testing. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hi, Marc and can drivers maintainers/reviewers! A long time ago syzbot reported memory leak in mcba_usb can driver[1]. It was using strange pattern for allocating coherent buffers, which was leading to memory leaks. I fixed this wrong pattern in mcba_usb driver and yesterday I got a report, that mcba_usb stopped working since my commit. I came up with quick fix and all started working well. There are at least 3 more drivers with this pattern, I decided to fix leaks in them too, since code is actually the same (I guess, driver authors just copy pasted code parts). Each of following patches is combination of 91c02557174b ("can: mcba_usb: fix memory leak in mcba_usb") and my yesterday fix [2]. Dear maintainers/reviewers, if You have one of these hardware pieces, please, test these patches and report any errors you will find. [1] https://syzkaller.appspot.com/bug?id=c94c1c23e829d5ac97995d51219f0c5a0cd1fa54 [2] https://lore.kernel.org/netdev/20210725103630.23864-1-paskripkin@gmail.com/ v1 -> v2 Fixed compilation error in 3rd patch Fixed cover letter With regards, Pavel Skripkin Pavel Skripkin (3): can: usb_8dev: fix memory leak can: ems_usb: fix memory leak can: esd_usb2: fix memory leak drivers/net/can/usb/ems_usb.c | 14 +++++++++++++- drivers/net/can/usb/esd_usb2.c | 16 +++++++++++++++- drivers/net/can/usb/usb_8dev.c | 15 +++++++++++++-- 3 files changed, 41 insertions(+), 4 deletions(-)