From patchwork Mon Oct 12 09:10:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 288565 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, MIME_HEADER_CTYPE_ONLY, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, T_TVD_MIME_NO_HEADERS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87C9DC43457 for ; Mon, 12 Oct 2020 09:11:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 300FA2076D for ; Mon, 12 Oct 2020 09:11:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e2qPQeSy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729286AbgJLJLU (ORCPT ); Mon, 12 Oct 2020 05:11:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729259AbgJLJLS (ORCPT ); Mon, 12 Oct 2020 05:11:18 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88E73C0613CE for ; Mon, 12 Oct 2020 02:11:18 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id n9so200565pgt.8 for ; Mon, 12 Oct 2020 02:11:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nXlPfikK8eog6RN7v2pmBeQAfT23cQtLP0EZqe7O05I=; b=e2qPQeSybGdmeCZ7HYcVarmR8oSDqCcIMwtp2YSoRVEdCXqfyiWdD4o9lq95KQJ0lh oNw4qY5aDS6UG82KJSSxoi4MsNS2AnHNVq2fVsQ0fQ77wkq5omwXe6QU4r5M41Gd+2b0 46Uhh+Dn2OXuv8HF5JH8wFJEQJuqydOTDfzEY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=nXlPfikK8eog6RN7v2pmBeQAfT23cQtLP0EZqe7O05I=; b=CK+fjLcSyNEBLKIyGxZXd1AtfIPM4R378Y6Q6wBQHkY8+VoRntVxOv6b4K6UTj5vcf zTFsN8AGTTWboO+NDLbh9HoWhI0qoRr77KSwVhMaB5JABjt6ZBOD4KsoKUEgKJ3WZT50 IYA83JJGi7P3+IEL1kt8mfwR+avnWQwPhwtj0cQJU5jCAxQrJEReu3qqf+65HMEonO4a YJugTLUMS9w5zmW90rJmF/noVJyGqOSVUD7cmIJiZJBLBCUKjuQ3dJz84+Z3su8dp5YZ gUanKHEcK6ohv1HdNXqO57EwNo1rNp5hBmNQyImO0aSUDCFI+k7uZlTTAqIjNeulXrk1 e+GQ== X-Gm-Message-State: AOAM530NyXp+8LSwQ7PIZh1lsfgQImqxCFlBjIw+0iJxe0oMPofj0/ML GzLZ6XDsSV3o0u2+zVGzitk3zmGYpdeRoA== X-Google-Smtp-Source: ABdhPJy8KI+r5Vu/VcJvtSMZ20Oo5grZLgkHVITTGYcGU5oE+Xl8Lu6YpTcKWcgV84fT6x0HWUkq3A== X-Received: by 2002:a17:90b:90c:: with SMTP id bo12mr18372195pjb.7.1602493877964; Mon, 12 Oct 2020 02:11:17 -0700 (PDT) Received: from localhost.swdvt.lab.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id jy19sm1275932pjb.9.2020.10.12.02.11.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2020 02:11:17 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, kuba@kernel.org, gospo@broadcom.com Subject: [PATCH net-next v2 3/9] bnxt_en: Set driver default message level. Date: Mon, 12 Oct 2020 05:10:48 -0400 Message-Id: <1602493854-29283-4-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1602493854-29283-1-git-send-email-michael.chan@broadcom.com> References: <1602493854-29283-1-git-send-email-michael.chan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently, bp->msg_enable has default value of 0. It is more useful to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by default. v2: Change the fall back bnxt_reset_task() inside bnxt_rx_ring_reset() to silent mode. With older fw, we would take the fall back path and it would be very noisy. Reviewed-by: Edwin Peer Reviewed-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index d4402a2cd07f..bac1b713786c 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -69,6 +69,7 @@ #include "bnxt_debugfs.h" #define BNXT_TX_TIMEOUT (5 * HZ) +#define BNXT_DEF_MSG_ENABLE (NETIF_MSG_DRV | NETIF_MSG_HW) MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Broadcom BCM573xx network driver"); @@ -10753,7 +10754,7 @@ static void bnxt_rx_ring_reset(struct bnxt *bp) else netdev_warn(bp->dev, "RX ring reset failed, rc = %d, falling back to global reset\n", rc); - bnxt_reset_task(bp, false); + bnxt_reset_task(bp, true); break; } bnxt_free_one_rx_ring_skbs(bp, i); @@ -12510,6 +12511,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) return -ENOMEM; bp = netdev_priv(dev); + bp->msg_enable = BNXT_DEF_MSG_ENABLE; bnxt_set_max_func_irqs(bp, max_irqs); if (bnxt_vf_pciid(ent->driver_data))