From patchwork Fri Dec 9 10:24:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pablo Neira Ayuso X-Patchwork-Id: 87412 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp230516qgi; Fri, 9 Dec 2016 02:24:51 -0800 (PST) X-Received: by 10.98.214.20 with SMTP id r20mr82519144pfg.59.1481279091838; Fri, 09 Dec 2016 02:24:51 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si33210121plj.170.2016.12.09.02.24.51; Fri, 09 Dec 2016 02:24:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933115AbcLIKYs (ORCPT + 5 others); Fri, 9 Dec 2016 05:24:48 -0500 Received: from mail.us.es ([193.147.175.20]:46266 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933105AbcLIKYr (ORCPT ); Fri, 9 Dec 2016 05:24:47 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D40D41395C2 for ; Fri, 9 Dec 2016 11:24:44 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C170C7E082 for ; Fri, 9 Dec 2016 11:24:44 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id B69367E085; Fri, 9 Dec 2016 11:24:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-107.2 required=7.5 tests=BAYES_50, HEADER_FROM_DIFFERENT_DOMAINS, SMTPAUTH_US, SPF_HELO_FAIL, URIBL_BLOCKED, USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 571127E07F for ; Fri, 9 Dec 2016 11:24:41 +0100 (CET) Received: from 192.168.1.13 (192.168.1.13) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/540/antivirus1-rhel7.int); Fri, 09 Dec 2016 11:24:41 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/540/antivirus1-rhel7.int) Received: (qmail 29789 invoked from network); 9 Dec 2016 11:24:41 +0100 Received: from 77.166.216.87.static.jazztel.es (HELO us.es) (1984lsi@87.216.166.77) by mail.us.es with AES128-SHA encrypted SMTP; 9 Dec 2016 11:24:41 +0100 Date: Fri, 9 Dec 2016 11:24:32 +0100 From: Pablo Neira Ayuso To: Paul Gortmaker Cc: netfilter-devel@vger.kernel.org, David Miller , netdev , "linux-next@vger.kernel.org" Subject: Re: [PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects Message-ID: <20161209102432.GA986@salvia> References: <1481147576-5690-1-git-send-email-pablo@netfilter.org> <1481147576-5690-38-git-send-email-pablo@netfilter.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Paul, On Thu, Dec 08, 2016 at 07:40:14PM -0500, Paul Gortmaker wrote: > On Wed, Dec 7, 2016 at 4:52 PM, Pablo Neira Ayuso wrote: > > This patch adds a new NFT_MSG_GETOBJ_RESET command perform an atomic > > dump-and-reset of the stateful object. This also comes with add support > > for atomic dump and reset for counter and quota objects. > > This triggered a new build failure in linux-next on parisc-32, which a > hands-off bisect > run lists as resulting from this: > > ERROR: "__cmpxchg_u64" [net/netfilter/nft_counter.ko] undefined! > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make: *** [sub-make] Error 2 > 43da04a593d8b2626f1cf4b56efe9402f6b53652 is the first bad commit > commit 43da04a593d8b2626f1cf4b56efe9402f6b53652 > Author: Pablo Neira Ayuso > Date: Mon Nov 28 00:05:44 2016 +0100 > > netfilter: nf_tables: atomic dump and reset for stateful objects > > This patch adds a new NFT_MSG_GETOBJ_RESET command perform an atomic > dump-and-reset of the stateful object. This also comes with add support > for atomic dump and reset for counter and quota objects. > > Signed-off-by: Pablo Neira Ayuso > > :040000 040000 6cd4554f69247e5c837db52342f26888beda1623 > 5908aca93c89e7922336546c3753bfcf2aceefba M include > :040000 040000 f25d5831eb30972436bd198c5bb237a0cb0b4856 > 4ee5751c8de02bb5a8dcaadb2a2df7986d90f8e9 M net > bisect run success > > Guessing this is more an issue with parisc than it is with netfilter, but I > figured I'd mention it anyway. I'm planning to submit this patch to parisc, I'm attaching it to this email. >From c9d320ac0be2a32a7b2bfad398be549865088ecf Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Thu, 8 Dec 2016 22:55:33 +0100 Subject: [PATCH] parisc: export symbol __cmpxchg_u64() kbuild test robot reports: >> ERROR: "__cmpxchg_u64" [net/netfilter/nft_counter.ko] undefined! Commit 43da04a593d8 ("netfilter: nf_tables: atomic dump and reset for stateful objects") introduces the first client of cmpxchg64() from modules. Patch 54b668009076 ("parisc: Add native high-resolution sched_clock() implementation") removed __cmpxchg_u64() dependency on CONFIG_64BIT. So, let's fix this problem by exporting this symbol unconditionally. Reported-by: kbuild test robot Signed-off-by: Pablo Neira Ayuso --- arch/parisc/kernel/parisc_ksyms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/kernel/parisc_ksyms.c b/arch/parisc/kernel/parisc_ksyms.c index 3cad8aadc69e..cfa704548cf3 100644 --- a/arch/parisc/kernel/parisc_ksyms.c +++ b/arch/parisc/kernel/parisc_ksyms.c @@ -40,8 +40,8 @@ EXPORT_SYMBOL(__atomic_hash); #endif #ifdef CONFIG_64BIT EXPORT_SYMBOL(__xchg64); -EXPORT_SYMBOL(__cmpxchg_u64); #endif +EXPORT_SYMBOL(__cmpxchg_u64); #include EXPORT_SYMBOL(lclear_user); -- 2.1.4