From patchwork Fri Jun 1 16:52:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Salil Mehta X-Patchwork-Id: 137568 Delivered-To: patch@linaro.org Received: by 2002:a2e:9706:0:0:0:0:0 with SMTP id r6-v6csp1181762lji; Fri, 1 Jun 2018 09:57:52 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIhp1UGTovANg8JSlRxXqC8D992TDXXJFvtiVmrFUN5cazxE0qIQjOwCAIofCY9ok6i7PjO X-Received: by 2002:a63:77c9:: with SMTP id s192-v6mr9519289pgc.140.1527872271968; Fri, 01 Jun 2018 09:57:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1527872271; cv=none; d=google.com; s=arc-20160816; b=vTwIqAb4BukycfXjILY1F+fvVIxD2jR7WihA9rWqFi42K7N2FeuIjvpnY5Ka58xX1B 0E3WvOkQ5uZaXM6wgjKRve4SpF/b7mPFRJl8LqXyhy5B3c1LkWyQ5yptqeUNhPjZ6VvJ ZDhz6OB2DdcFs+whSimBtu9wLhWjMB1/syEaqCSU3SIg++NmWLqkFV/O+/hXPRHXEwnS Lht89wzns0z5AkfTuatcqg8VXpgexC1iu+vaf4S9oVWcwRHvTsQFsnQrirHlBnTaAe25 LYwZu5BWFz7C2RQzPxajbR664HcUOd/qOr9XTEdd6so+WyRXGTKtQUAwu28ciXs07u6Z zs7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=k9+iTWEIgeFtjwE7ImOXdVi9wrXKE0paih8wxL26KB8=; b=UxQy2NcypgcVZqkItUjhP49aUygI4/Dthc2lPrbBdATuRR6Tb+jSaasTmWWFsr38PD /s+KoSUCsvmz4DG74bnthnwFn984WDtGwINRHC5uf2WkT/BoZerCbM5//yDhR3rsC8nU Ec69oKVGhZOkZyTvOEyxaeqLGAEZp0O7HxtMEzotnW/qL9DMCee7jNdN3NHWqv+boMT5 H6xPhXCJ/HMyc/EX+ujRwFpSvkgHssz6vX6XqACsnDt1j+gXMENabPhnyGn40sSpVxtS dbwyH+gVdyrKpdm3plqKAr0aIzES2VFsWuQmxdsqFx+XfhLRJwhGzX5k68SofpdrvSoO 7y8g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c2-v6si19454891pgp.147.2018.06.01.09.57.51; Fri, 01 Jun 2018 09:57:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753483AbeFAQ5s (ORCPT + 9 others); Fri, 1 Jun 2018 12:57:48 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:8624 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752429AbeFAQxz (ORCPT ); Fri, 1 Jun 2018 12:53:55 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5CC972E238772; Sat, 2 Jun 2018 00:53:41 +0800 (CST) Received: from S00293818-DELL1.china.huawei.com (10.202.227.234) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.382.0; Sat, 2 Jun 2018 00:53:35 +0800 From: Salil Mehta To: CC: , , , , , , , Jian Shen Subject: [PATCH net-next 03/11] net: hns3: Add repeat address checking for setting mac address Date: Fri, 1 Jun 2018 17:52:03 +0100 Message-ID: <20180601165211.46372-4-salil.mehta@huawei.com> X-Mailer: git-send-email 2.8.3 In-Reply-To: <20180601165211.46372-1-salil.mehta@huawei.com> References: <20180601165211.46372-1-salil.mehta@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.202.227.234] X-CFilter-Loop: Reflected Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jian Shen Add checking for new mac address. It doesn't need to config the mac vlan table if it's already in use. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.7.4 diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 0a6876a..fe54564 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1132,6 +1132,12 @@ static int hns3_nic_net_set_mac_address(struct net_device *netdev, void *p) if (!mac_addr || !is_valid_ether_addr((const u8 *)mac_addr->sa_data)) return -EADDRNOTAVAIL; + if (ether_addr_equal(netdev->dev_addr, mac_addr->sa_data)) { + netdev_info(netdev, "already using mac address %pM\n", + mac_addr->sa_data); + return 0; + } + ret = h->ae_algo->ops->set_mac_addr(h, mac_addr->sa_data, false); if (ret) { netdev_err(netdev, "set_mac_address fail, ret=%d!\n", ret);