From patchwork Thu Mar 19 01:29:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 222257 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10322C4332B for ; Thu, 19 Mar 2020 01:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A431920767 for ; Thu, 19 Mar 2020 01:29:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="JE4H85XM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726866AbgCSB3n (ORCPT ); Wed, 18 Mar 2020 21:29:43 -0400 Received: from mail.nic.cz ([217.31.204.67]:39740 "EHLO mail.nic.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgCSB3n (ORCPT ); Wed, 18 Mar 2020 21:29:43 -0400 Received: from dellmb.labs.office.nic.cz (unknown [IPv6:2001:1488:fffe:6:cac7:3539:7f1f:463]) by mail.nic.cz (Postfix) with ESMTP id E23D1141B54; Thu, 19 Mar 2020 02:29:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1584581382; bh=smPg6bUN9iYsjOGsgMn5scMwqFNNXz6iBZhhcj1gDdE=; h=From:To:Date; b=JE4H85XMcYVZ1IdcD+NCNJHg8Do5/EwI4had+P/22q7end3aHKjpJhwfz3mgC7qCU 6nwPG0Q8czxgZQl3X1MnT5H5zP3voaCl0x9LNmo5O9ZqeHJDaRp41/lsscxL64rXqJ 0hhLZGvoAQglzfQwsbMHZ+pyNhOmfk2PsSntPPxI= From: =?utf-8?q?Marek_Beh=C3=BAn?= To: netdev@vger.kernel.org Cc: =?utf-8?q?Marek_Beh=C3=BAn?= , Chris Packham , Andrew Lunn Subject: [PATCH net-next] net: mvmdio: fix driver probe on missing irq Date: Thu, 19 Mar 2020 02:29:40 +0100 Message-Id: <20200319012940.14490-1-marek.behun@nic.cz> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-Spamd-Bar: / X-Virus-Scanned: clamav-milter 0.101.4 at mail X-Virus-Status: Clean Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Commit e1f550dc44a4 made the use of platform_get_irq_optional, which can return -ENXIO when interrupt is missing. Handle this as non-error, otherwise the driver won't probe. Fixes: e1f550dc44a4 ("net: mvmdio: avoid error message for optional...") Signed-off-by: Marek Behún Cc: Chris Packham Cc: Andrew Lunn --- drivers/net/ethernet/marvell/mvmdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index d2e2dc538428..f9f09da57031 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -364,7 +364,7 @@ static int orion_mdio_probe(struct platform_device *pdev) writel(MVMDIO_ERR_INT_SMI_DONE, dev->regs + MVMDIO_ERR_INT_MASK); - } else if (dev->err_interrupt < 0) { + } else if (dev->err_interrupt < 0 && dev->err_interrupt != -ENXIO) { ret = dev->err_interrupt; goto out_mdio; }