From patchwork Sat May 9 04:35:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 219583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51DD8C54E7E for ; Sat, 9 May 2020 04:36:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32EAE2184D for ; Sat, 9 May 2020 04:36:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588998974; bh=bHG4LlHQK+q57Ev5jCD4Q1hDTtJoIOGQzXC8SCXSye0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nBGTvbyDn0FKJxYmth190G9cVE4AbJ9LnAsNOUU/NMYzVzaTR2tb5oi6UgK1gJzOK 5kwQj1P5f6NRBN3bie3I4WqIj1gAeMbwCLRm9EpCkVyroN8vKs3MCIuvgZ7IZWpnz/ DIs5rdstNVJcoM31iw7+OHADHs3z5Z/+Q1ExUxZ8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728810AbgEIEgN (ORCPT ); Sat, 9 May 2020 00:36:13 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:33450 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728777AbgEIEgK (ORCPT ); Sat, 9 May 2020 00:36:10 -0400 Received: by mail-pj1-f67.google.com with SMTP id 7so5932064pjo.0; Fri, 08 May 2020 21:36:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MiQNjcOpznNHJIwN/vJ7Wo/YnTDk8aSjxv7fQy7u2y8=; b=lj3luMkOFKQ6cvW2o87kLMdzWKSobF8LVSQeZVveeXbFlTssYOBB+JZ36k9wEupdLR A+OWE/27n04f6grfjCSPXlciSaM+d7uaX9OfsCJv++NQwcUmyKjDowopkWpM5EUOXHWx YnAX5052oHQ+rpTO2+KKyIYBRxJ/IFPo1JZNI0RqlRSQPD0AcBOXsqzf+aebqNwnhmBC 1Vz4V7L4P7W0mlf2kdfmBBKbVLmEeUcdZRLi3GqcWEo30Xoa2PwTTS0/LW3gtLIc1miX qv0WqwOEDshnfvceeZF4Ft35Q36C8K56dd8EMGyPK9SE5ngT/V+EUA6Tmd2vz5KubXtw WruA== X-Gm-Message-State: AGi0PuYbi8N6nakOQ4M+NPvFvWQObbOyyid1GqcR8Llp/gx9oLbUkKY4 ULceZOm0h0VPjiqhnWRjpI8= X-Google-Smtp-Source: APiQypLiur3keFVKRwB2MQgmwWD89BCGfVHpMjRj2wvjmigHkcG0FJgVA9QEo1AVCFJZLcU3k/L7gg== X-Received: by 2002:a17:90a:2450:: with SMTP id h74mr9662376pje.57.1588998970163; Fri, 08 May 2020 21:36:10 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id p24sm3281813pff.92.2020.05.08.21.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 21:36:07 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id 1208142000; Sat, 9 May 2020 04:36:01 +0000 (UTC) From: Luis Chamberlain To: jeyu@kernel.org Cc: akpm@linux-foundation.org, arnd@arndb.de, rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com, cai@lca.pw, dyoung@redhat.com, bhe@redhat.com, peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com, pmladek@suse.com, tiwai@suse.de, schlad@suse.de, andriy.shevchenko@linux.intel.com, keescook@chromium.org, daniel.vetter@ffwll.ch, will@kernel.org, mchehab+samsung@kernel.org, kvalo@codeaurora.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Derek Chickles , Satanand Burla , Felix Manlunas Subject: [PATCH 06/15] liquidio: use new module_firmware_crashed() Date: Sat, 9 May 2020 04:35:43 +0000 Message-Id: <20200509043552.8745-7-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 In-Reply-To: <20200509043552.8745-1-mcgrof@kernel.org> References: <20200509043552.8745-1-mcgrof@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to annotate when this happens clearly. Cc: Derek Chickles Cc: Satanand Burla Cc: Felix Manlunas Signed-off-by: Luis Chamberlain --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/liquidio/lio_main.c b/drivers/net/ethernet/cavium/liquidio/lio_main.c index 66d31c018c7e..f18085262982 100644 --- a/drivers/net/ethernet/cavium/liquidio/lio_main.c +++ b/drivers/net/ethernet/cavium/liquidio/lio_main.c @@ -801,6 +801,7 @@ static int liquidio_watchdog(void *param) continue; WRITE_ONCE(oct->cores_crashed, true); + module_firmware_crashed(); other_oct = get_other_octeon_device(oct); if (other_oct) WRITE_ONCE(other_oct->cores_crashed, true);