From patchwork Wed Jun 10 16:14:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Biggers X-Patchwork-Id: 217860 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 568C1C433E0 for ; Wed, 10 Jun 2020 16:15:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28DD92063A for ; Wed, 10 Jun 2020 16:15:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591805719; bh=tFLtFU9slykfm4dIs2excokQc97ZcoVyyfzMpnBhZms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=muXABdVfKilk7iIm4A/Gs+XNZPCsVxfu8rIuMxGxjDQW+juWUgzIePYXSEQA+AUTn rtDeivhJ7zX/iSkd0nWG6XdfG6cn9/ucx7SeNL6ziFc1GkmbHFN9G8sKRqifubpfRd 5ui4oaUn3hw33DwTho48jKvzs0e+dsw+ygmftclM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728566AbgFJQPR (ORCPT ); Wed, 10 Jun 2020 12:15:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:60792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727948AbgFJQPO (ORCPT ); Wed, 10 Jun 2020 12:15:14 -0400 Received: from sol.hsd1.ca.comcast.net (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 315C62064C; Wed, 10 Jun 2020 16:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591805714; bh=tFLtFU9slykfm4dIs2excokQc97ZcoVyyfzMpnBhZms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m97IPMjjux5oFq6+hsRk0IPd5o6rGePDP9300wmqcqj2+ZFQ4jrh3smM4T479iPf2 m1BXThEnFcxZyWxswrzzvRT6dijkgdQzNTfywscGYGCPaujosPRlJozIAt7NUbRNeY VUue+2ZAoNA3FcCurG4Jqnb+UVa0emEv9Pp1Jrpg= From: Eric Biggers To: netdev@vger.kernel.org Cc: linux-crypto@vger.kernel.org, Corentin Labbe , Greg Kroah-Hartman , Herbert Xu , Steffen Klassert Subject: [PATCH net v4 2/3] esp: select CRYPTO_SEQIV Date: Wed, 10 Jun 2020 09:14:36 -0700 Message-Id: <20200610161437.4290-3-ebiggers@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610161437.4290-1-ebiggers@kernel.org> References: <20200610161437.4290-1-ebiggers@kernel.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Biggers Commit f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made CRYPTO_CTR stop selecting CRYPTO_SEQIV. This breaks IPsec for most users since GCM and several other encryption algorithms require "seqiv" -- and RFC 8221 lists AES-GCM as "MUST" be implemented. Just make XFRM_ESP select CRYPTO_SEQIV. Fixes: f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") Acked-by: Herbert Xu Cc: Corentin Labbe Cc: Greg Kroah-Hartman Cc: Steffen Klassert Signed-off-by: Eric Biggers --- net/xfrm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index 169c22140709f7..b2ff8df2c836ef 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -86,6 +86,7 @@ config XFRM_ESP select CRYPTO_SHA1 select CRYPTO_DES select CRYPTO_ECHAINIV + select CRYPTO_SEQIV config XFRM_IPCOMP tristate