From patchwork Mon Oct 26 21:29:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 288089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB4F8C2D0A3 for ; Mon, 26 Oct 2020 21:33:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95E23207F7 for ; Mon, 26 Oct 2020 21:33:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603748039; bh=w8ZLzd4kKpLW6ezVVkkijju1OhfgRyCDIckcDfFDoQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BQHne6kuHgPuCbBGWXVYJSbyj6IGbCKNrY8PGkIFANgqvb9UGMGKIa3v932BDTl8W hmbE1+woQpLskxdXUjAnBaOpjTJrvuW65zvggAl/ZgEwfmJdg1bbLfhqnIWmINxl7H PC/HU1xD/YMZeiAXrvNC5G/8maEA2UTLQjEyAFdA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389424AbgJZVd6 (ORCPT ); Mon, 26 Oct 2020 17:33:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:44886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387677AbgJZVd5 (ORCPT ); Mon, 26 Oct 2020 17:33:57 -0400 Received: from localhost.localdomain (unknown [192.30.34.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8687207C4; Mon, 26 Oct 2020 21:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603748036; bh=w8ZLzd4kKpLW6ezVVkkijju1OhfgRyCDIckcDfFDoQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R7lUOX1UZJ8gPL5gL76lDFAc5yeT2Uwhj670BvzUZt4nfhBB+cCTxdRj+uAwaYGzB BnunQzEQ0IOFK/vB2NqpCd8T6sX1G7G918VzhhJuBgL40MggizRj1BFGncfOIBXBmH P5qh+cEHLhrVPkq6H6dNBV4KRIt1718WyA9MaClk= From: Arnd Bergmann To: Kalle Valo , "David S. Miller" , Jakub Kicinski Cc: Arnd Bergmann , Raja Mani , Suraj Sumangala , Jouni Malinen , Vasanthakumar Thiagarajan , Vivek Natarajan , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 09/11] ath6kl: fix enum-conversion warning Date: Mon, 26 Oct 2020 22:29:56 +0100 Message-Id: <20201026213040.3889546-9-arnd@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201026213040.3889546-1-arnd@kernel.org> References: <20201026213040.3889546-1-arnd@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann gcc -Wextra points out a type mismatch drivers/net/wireless/ath/ath6kl/wmi.c: In function 'ath6kl_wmi_cmd_send': drivers/net/wireless/ath/ath6kl/wmi.c:1825:19: warning: implicit conversion from 'enum ' to 'enum wmi_data_hdr_data_type' [-Wenum-conversion] 1825 | false, false, 0, NULL, if_idx); | ^~~~~ As far as I can tell, the numeric value is current here, so just use the correct enum literal instead of 'false'. Fixes: bdcd81707973 ("Add ath6kl cleaned up driver") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath6kl/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath6kl/wmi.c b/drivers/net/wireless/ath/ath6kl/wmi.c index dbc47702a268..b137e7f34397 100644 --- a/drivers/net/wireless/ath/ath6kl/wmi.c +++ b/drivers/net/wireless/ath/ath6kl/wmi.c @@ -1821,8 +1821,8 @@ int ath6kl_wmi_cmd_send(struct wmi *wmi, u8 if_idx, struct sk_buff *skb, /* Only for OPT_TX_CMD, use BE endpoint. */ if (cmd_id == WMI_OPT_TX_FRAME_CMDID) { - ret = ath6kl_wmi_data_hdr_add(wmi, skb, OPT_MSGTYPE, - false, false, 0, NULL, if_idx); + ret = ath6kl_wmi_data_hdr_add(wmi, skb, OPT_MSGTYPE, false, + WMI_DATA_HDR_DATA_TYPE_802_3, 0, NULL, if_idx); if (ret) { dev_kfree_skb(skb); return ret;