From patchwork Wed Dec 23 19:45:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 352237 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29CEC433E0 for ; Wed, 23 Dec 2020 19:47:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53388223E0 for ; Wed, 23 Dec 2020 19:47:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728817AbgLWTqs (ORCPT ); Wed, 23 Dec 2020 14:46:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:59341 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728497AbgLWTqs (ORCPT ); Wed, 23 Dec 2020 14:46:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608752721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hz7m6V9y9LKYDbuYf1YRMJjX+MWq8iR3kXuzC0duUxI=; b=ixdpsCKZTix9zGrqoVSBBDeHcnPiiTI/1x4aYP4m0nyE1TmInT557HzEA0fDc7twM2X7Gr OAoVT18NIzukeM4ZTzJKoGkZF4kJGik49PQohJy0+cHXZuMKdVvqZNeQgxYUcukq1RAIbI mL0396SdqPUwxWuD1YvgOR3Z/GiwDqQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-L-87JRzSOqiz30y6Lvj3vQ-1; Wed, 23 Dec 2020 14:45:19 -0500 X-MC-Unique: L-87JRzSOqiz30y6Lvj3vQ-1 Received: by mail-qv1-f72.google.com with SMTP id cc1so207528qvb.3 for ; Wed, 23 Dec 2020 11:45:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hz7m6V9y9LKYDbuYf1YRMJjX+MWq8iR3kXuzC0duUxI=; b=R/5ebTqDRHsWZnrkBM1nhGIvgHvQXiwUSwB0o9wlyFdcovhOWMb8zb3OLKX011/ZvH 8XChEBSsROjGbvFNyWwLRgiZXQr2b/ycNxa3xYa+MzHIlPnY/al01z2tV7DgcNoKcpSJ ticNsWrdYtXXtpiC4/6LAnKpK1SbI/1sLlfRi+rHDXyYaTucqa+mR6y5Yq2d6Ua5lTkl D6wM0JqICNf5kQNRF5xKHVZqplgE/cpgyCiZoVur3RoMjXR//5jm0YQtRlrFx9RrfFi5 LClv1wakpV/prwtOQuzTGo3j4qGUFdrVNUol9ZirbjvkjDGXMIfP2yoCQFEGFMpCrgVC bU7A== X-Gm-Message-State: AOAM532jdr6p075/X7mR/OOu3PQ7SYuspq/eY/uAxrlLIbzHeT6uXxtj xii+Y0swQ5C921Vc9RseUlVjYCmmeAfhPOF6ljH+Ca0Ussb3Vka2Eh/6NRctHTeG+fiXxGKZ6nz cWlwOsDViy1V+LErc X-Received: by 2002:ac8:5286:: with SMTP id s6mr27092691qtn.22.1608752719378; Wed, 23 Dec 2020 11:45:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvaGHXwGzRvaSpvVyxfxvDK522ewEsI68QgpytD4dBD53dYAsdhkiyCvoclzmTjNngfpObRQ== X-Received: by 2002:ac8:5286:: with SMTP id s6mr27092678qtn.22.1608752719201; Wed, 23 Dec 2020 11:45:19 -0800 (PST) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id u4sm14517904qtv.49.2020.12.23.11.45.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Dec 2020 11:45:18 -0800 (PST) From: trix@redhat.com To: saeedm@nvidia.com, leon@kernel.org, davem@davemloft.net, kuba@kernel.org, vladyslavt@nvidia.com, maximmi@mellanox.com, tariqt@nvidia.com, bjorn.topel@intel.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] net/mlx5e: remove h from printk format specifier Date: Wed, 23 Dec 2020 11:45:12 -0800 Message-Id: <20201223194512.126231-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tom Rix This change fixes the checkpatch warning described in this commit commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary %h[xudi] and %hh[xudi]") Standard integer promotion is already done and %hx and %hhx is useless so do not encourage the use of %hh[xudi] or %h[xudi]. Signed-off-by: Tom Rix --- drivers/net/ethernet/mellanox/mlx5/core/en/params.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c index 43271a3856ca..36381a2ed5a5 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/params.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/params.c @@ -179,7 +179,7 @@ int mlx5e_validate_params(struct mlx5e_priv *priv, struct mlx5e_params *params) stop_room = mlx5e_calc_sq_stop_room(priv->mdev, params); if (stop_room >= sq_size) { - netdev_err(priv->netdev, "Stop room %hu is bigger than the SQ size %zu\n", + netdev_err(priv->netdev, "Stop room %u is bigger than the SQ size %zu\n", stop_room, sq_size); return -EINVAL; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c index 03831650f655..d41bfea85aa2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c @@ -3763,7 +3763,7 @@ static int set_feature_lro(struct net_device *netdev, bool enable) mutex_lock(&priv->state_lock); if (enable && priv->xsk.refcnt) { - netdev_warn(netdev, "LRO is incompatible with AF_XDP (%hu XSKs are active)\n", + netdev_warn(netdev, "LRO is incompatible with AF_XDP (%u XSKs are active)\n", priv->xsk.refcnt); err = -EINVAL; goto out; @@ -4005,7 +4005,7 @@ static bool mlx5e_xsk_validate_mtu(struct net_device *netdev, max_mtu_page = mlx5e_xdp_max_mtu(new_params, &xsk); max_mtu = min(max_mtu_frame, max_mtu_page); - netdev_err(netdev, "MTU %d is too big for an XSK running on channel %hu. Try MTU <= %d\n", + netdev_err(netdev, "MTU %d is too big for an XSK running on channel %u. Try MTU <= %d\n", new_params->sw_mtu, ix, max_mtu); return false; }