From patchwork Fri Jan 15 20:09:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 363749 Delivered-To: patch@linaro.org Received: by 2002:a02:ccad:0:0:0:0:0 with SMTP id t13csp171177jap; Fri, 15 Jan 2021 12:11:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyboagg5q4JxF9LMd6t9FKaNCay1aTGunb8hB3MkDydK3n3sAeuuAovgFRY2NCx/Jua/Sd9 X-Received: by 2002:a17:906:4a04:: with SMTP id w4mr2100605eju.46.1610741513686; Fri, 15 Jan 2021 12:11:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610741513; cv=none; d=google.com; s=arc-20160816; b=lNlBjVlboYuyUZgLHYquEVywZ6L/Hd6DVGNKp651/maAm+Mn1z6NCeQs3It5QZTRMV g1hwajvYnG07v59wIEEyVAR+LoEFEdubvG7wI5KzU4HRzojUDBmxIeDpa20nnqHPW0U8 4KxPtIHy0ByJbaskpb1GYAfi1wgV3V7xsXWVZB7aZ5hUXUwS6jtm/xgTh/cVBIPXiSvJ mDQJugTalTivryAu86OLoshTyoO7+JrQ6wGvkNJFPTbo/nb94hqALn+6AkUctS615oHK pDhrSz01RdyZDeCaDzWeEFSJPQG4q93/hgv5JVsrPFS8kSY8fVzbe10X4Y79bVJ3/R0Q K5dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=GrAFQn1swjCpdP6CJhc/XOA/h/oKighRXn4wLFP75kNWHrFSr9OXBbvVWZMOVGTOPm iM7fJ6M6nKj33SY5DgtdS2QZocNmZR6chS21TftCx/Jr4e2oni5Ux1TwyB89mgawX7Rp RfbeZJMxgCpPSq278Dw7IdXKut4lHPM9hG6sv7X95dfrfIH7WhrKv9lu9OBq8EKfOZVE EV+CwTH7N0NQyZ3HPIb8zm/oaUz0D8lQl0Ah2HgxTJnajAWZn4gruW1iLyRO3ekPXj9i GlTJXNRKsmYfsrS8TiRXX35ACxuJKO657HB+FEqNloAmoCRuZugceWi/A6rAQb77Or8E K+PA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r4oAoo9y; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v3si4089359eje.650.2021.01.15.12.11.53; Fri, 15 Jan 2021 12:11:53 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=r4oAoo9y; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388622AbhAOUKt (ORCPT + 7 others); Fri, 15 Jan 2021 15:10:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728081AbhAOUKp (ORCPT ); Fri, 15 Jan 2021 15:10:45 -0500 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA619C0617A1 for ; Fri, 15 Jan 2021 12:09:24 -0800 (PST) Received: by mail-wm1-x334.google.com with SMTP id e15so2246936wme.0 for ; Fri, 15 Jan 2021 12:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=r4oAoo9yjHlPOAHenr5g1EEQfCJWwxaNTfc1ja5O6o5T1ZICU4yaeYLTltJ1ZwhWt1 hYVV2trVas9eLp1262M7RtfrYIEz7l+5afdXAZLDAVgmpGypz488LOz8xh5YUONIahkt eE1JpBPouAfU6ZbgapMKocnQObleFyJlMh17sdT9uSaDfAJK1H4RLL3fR/jf1vPbZSl2 3ZXGy84XFr6wdgvBhg4tUDvEZEEb9HvFdLNJXx4pfxdQa+bod0l65TCpu6pNojaqfRmz GZBTnODZc6DO9w3kWfCa8POUDB0h8esIyL2gH/Yx7pqneNMukxKM+5ngce4TNsbAFuly uH2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+qXCFwBbPWtbGR33uyQvB+16QfHJsg8zQueyUlEuj0c=; b=JK0G0IQiIGNe8AOKHrxZudn507nWqcWsBXhSQjo0GKLCVKFExNLYOi+bi2kvKMtEOu zt9m0+SDyJc49ZIn29h5M6KWSlXj4cGToqiYFEHgTJZjer3Q4cnjYMMgcBgGj0LSU85t HzYzaLInoIWBVaxzSs0zut/XjkF/jFP0bOeJI3CHf4TpmNNky6qbP+QKn4kaP+dBS8Af ND/NNRL1Y4AFfBdOEdGIxqn7TEl6Hy/5SmrdKzLAvjr+yTFQQ3AkjrY+sIScGG9dOg95 n1q/vYLCdoEuZ3RVX4vZT9JCicTb8BpKEL3ApOgvdaY/Jtm/Hlhi7xfQeDzs2Xx6bB1t GSUA== X-Gm-Message-State: AOAM533pywnaUi/1Nn+w6z2g7ur2VkV4cCwqzS995hdnS6i+Pm7KwCd+ 3LYVdjDYPiz5IFuUhJ30uCO1E6ph86FufXWf X-Received: by 2002:a1c:1f86:: with SMTP id f128mr10246918wmf.174.1610741363617; Fri, 15 Jan 2021 12:09:23 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id d85sm9187863wmd.2.2021.01.15.12.09.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jan 2021 12:09:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Geoff Levand , "David S. Miller" , Jakub Kicinski , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Utz Bacher , Jens Osterkamp , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Andrew Lunn Subject: [PATCH 6/7] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Fri, 15 Jan 2021 20:09:04 +0000 Message-Id: <20210115200905.3470941-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210115200905.3470941-1-lee.jones@linaro.org> References: <20210115200905.3470941-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'irq' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter or member 'ptr' not described in 'gelic_card_interrupt' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter or member 'txqueue' not described in 'gelic_net_tx_timeout' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter or member 'napi' not described in 'gelic_ether_setup_netdev_ops' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_probe' drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter or member 'dev' not described in 'ps3_gelic_driver_remove' Cc: Geoff Levand Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Utz Bacher Cc: Jens Osterkamp Cc: netdev@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Andrew Lunn Signed-off-by: Lee Jones --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c index 3d1fc8d2ca667..55e652624bd76 100644 --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c @@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int budget) return packets_done; } -/** +/* * gelic_card_interrupt - event handler for gelic_net */ static irqreturn_t gelic_card_interrupt(int irq, void *ptr) @@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct *work) /** * gelic_net_tx_timeout - called when the tx timeout watchdog kicks in. * @netdev: interface device structure + * @txqueue: unused * * called, if tx hangs. Schedules a task that resets the interface */ @@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = { /** * gelic_ether_setup_netdev_ops - initialization of net_device operations * @netdev: net_device structure + * @napi: napi structure * * fills out function pointers in the net_device structure */ @@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card *card) dev_info(ctodev(card), "internal vlan %s\n", card->vlan_required? "enabled" : "disabled"); } -/** +/* * ps3_gelic_driver_probe - add a device to the control of this driver */ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) @@ -1787,7 +1789,7 @@ static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev) return result; } -/** +/* * ps3_gelic_driver_remove - remove a device from the control of this driver */