From patchwork Thu Mar 4 22:34:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 393335 Delivered-To: patch@linaro.org Received: by 2002:a17:906:a383:0:0:0:0 with SMTP id k3csp750ejz; Thu, 4 Mar 2021 14:49:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwkCBTxyBbi+nRGerxuZ7DQKpOyS3nFsLBrFC8qy42SDNMJBRHeQhMFCB2EAzNKV5n64tL3 X-Received: by 2002:a17:906:40c7:: with SMTP id a7mr6605080ejk.109.1614897719001; Thu, 04 Mar 2021 14:41:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614897718; cv=none; d=google.com; s=arc-20160816; b=iyHZyudz2s06/lGQepjc3Aymgyv/eS06pSq5Pyk4k8pmCTed/Cwo8g3vsNXwDVighL /pI9hYwfxNwboc3J91ajCzKppHkFpjA27QA7mDDQRf7PJQmlm48YjZBbqjBhRNVxRnkX d6qVMWuGSEXY2fN2hrJ0gk2h9C+NVHXhnuYFTEcOPnJHrQ8GXtc/6Z2QvEikyqr5k8FT KoBY+lMwdbVFWQPYjD1ookHx5OAbXP3XfqZtmpSQWtazX+LftKVk8bi3nhkcxWSv/qQV Ue0tQxDOaEhcy/48Rm0+vqFrSwLEcAh037G2FcXR2CJVVAHuIB/N7S6dwQD1CJ/hmyhI JnNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=82gS3dr1lmNX6eOzYCV4o5GS358gJ/Wk20VCXTc/lZ0=; b=SzDypPFlzOduYgqiDSc6UHpWiEZCB1832NQrieec9aSzJQHMX+m3xV2RasnXDo9Fd5 lJxBzQiioui1bzF0NDllox0LEZZoLSpi8KiIfB84p3EPcwELDf/nkBN2MYY2J0HFAviV bVBOkqzhiF+6FSfAJ+tf8RYYWDJJib0tAjDr/yxGjRxfvw/fxsOS70QghnqL1Y4on8Wb Wxzt5k1LzYc2SWAV76S5C+Sq6Tpy4woR1a1At1E8GCO81hX5IuX2ovmtSToDjrG0PNUp sLH35QSlBFKbKVPv43sjk/sVCGtE31uAMeabMMoWB2haecp5V7DJDrYSryAkj3WuKDU5 fX4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VpU233ld; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si527757edj.545.2021.03.04.14.41.58; Thu, 04 Mar 2021 14:41:58 -0800 (PST) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VpU233ld; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232256AbhCDWet (ORCPT + 9 others); Thu, 4 Mar 2021 17:34:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232115AbhCDWei (ORCPT ); Thu, 4 Mar 2021 17:34:38 -0500 Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49FAAC061574 for ; Thu, 4 Mar 2021 14:34:38 -0800 (PST) Received: by mail-il1-x133.google.com with SMTP id s1so152644ilh.12 for ; Thu, 04 Mar 2021 14:34:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=82gS3dr1lmNX6eOzYCV4o5GS358gJ/Wk20VCXTc/lZ0=; b=VpU233ldeklOSf6A0Pksib3d6P/G5lhb3NWmW+fYuaFZogTCgv7qXAPIeOV0hd495k TX+G2KlO5ePkSX7v1Ode0Xdl92Ny/+0OUrGRT+/QtmQO+D4E0Obuj+8GPlYHOOdjT70X iMdArQH15aJxO8whB9IaYQwolRQ7kraP0EjoKgbWdnjvtpUvYLeJo6HDot61EI/k+Jbz pVa/JW3DYtiIT402uMTbSix4SUcGVisZYJ20o0vnLoq4A/OpKwWN30jN+0alFCS060Wa t3+n32GeofvARRirMIVJ7C7sQu3VdTQbv82SzRKAOuXlUKQgCzEteSmLB06l9C1UX7yr d1yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=82gS3dr1lmNX6eOzYCV4o5GS358gJ/Wk20VCXTc/lZ0=; b=jPGzI8/WFeHLP0Pa5SFA0UjCoDUDfyIvykxXhIlIEAxCGZYeD9vrZQxsOLX9VUbpLR elsbMTzdOqxkj6zhrUUWy77+K8bfXSMvmIFl6g7OAQyGxsmD0Yq2Vi9axkQz2TKL4Zoq Osv+NnxivdmEbbgaxBXVpDnmmIUOXzaoGZ3pXBUugob7IB9ENpKgJTOzGZWxzCgJY+kI /d89cyNovsUKmSiFojCcgYGjMjcc385LSjGKVtsvulf8ehT5JfPGSKq78B5b1YjyZBcp tZCwzQawnpE3NvADOMZK7yooUnV98w/oxq++pAbaeyx68xA+Yf6+Jl+EN2DiFcaHjjN9 U7nw== X-Gm-Message-State: AOAM531yjCj+puONq1AbA1Ey7+QouaZEiclJosooNde5WtXzBEYBivyK cx1pgJw4d5jt6Z7Rrwl0V2GugQ== X-Received: by 2002:a92:4a0e:: with SMTP id m14mr6084223ilf.117.1614897277720; Thu, 04 Mar 2021 14:34:37 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id s18sm399790ilt.9.2021.03.04.14.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 14:34:37 -0800 (PST) From: Alex Elder To: subashab@codeaurora.org, stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: sharathv@codeaurora.org, bjorn.andersson@linaro.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 3/6] net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros Date: Thu, 4 Mar 2021 16:34:28 -0600 Message-Id: <20210304223431.15045-4-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210304223431.15045-1-elder@linaro.org> References: <20210304223431.15045-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The following macros, defined in "rmnet_map.h", assume a socket buffer is provided as an argument without any real indication this is the case. RMNET_MAP_GET_MUX_ID() RMNET_MAP_GET_CD_BIT() RMNET_MAP_GET_PAD() RMNET_MAP_GET_CMD_START() RMNET_MAP_GET_LENGTH() What they hide is pretty trivial accessing of fields in a structure, and it's much clearer to see this if we do these accesses directly. So rather than using these accessor macros, assign a local variable of the map header pointer type to the socket buffer data pointer, and derereference that pointer variable. In "rmnet_map_data.c", use sizeof(object) rather than sizeof(type) in one spot. Also,there's no need to byte swap 0; it's all zeros irrespective of endianness. Signed-off-by: Alex Elder --- drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c | 10 ++++++---- drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h | 12 ------------ .../net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 11 ++++++++--- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c | 4 ++-- 4 files changed, 16 insertions(+), 21 deletions(-) -- 2.20.1 Reviewed-by: Bjorn Andersson diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c index 3d00b32323084..2a6b2a609884c 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_handlers.c @@ -56,20 +56,22 @@ static void __rmnet_map_ingress_handler(struct sk_buff *skb, struct rmnet_port *port) { + struct rmnet_map_header *map_header = (void *)skb->data; struct rmnet_endpoint *ep; u16 len, pad; u8 mux_id; - if (RMNET_MAP_GET_CD_BIT(skb)) { + if (map_header->cd_bit) { + /* Packet contains a MAP command (not data) */ if (port->data_format & RMNET_FLAGS_INGRESS_MAP_COMMANDS) return rmnet_map_command(skb, port); goto free_skb; } - mux_id = RMNET_MAP_GET_MUX_ID(skb); - pad = RMNET_MAP_GET_PAD(skb); - len = RMNET_MAP_GET_LENGTH(skb) - pad; + mux_id = map_header->mux_id; + pad = map_header->pad_len; + len = ntohs(map_header->pkt_len) - pad; if (mux_id >= RMNET_MAX_LOGICAL_EP) goto free_skb; diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h index 576501db2a0bc..2aea153f42473 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h @@ -32,18 +32,6 @@ enum rmnet_map_commands { RMNET_MAP_COMMAND_ENUM_LENGTH }; -#define RMNET_MAP_GET_MUX_ID(Y) (((struct rmnet_map_header *) \ - (Y)->data)->mux_id) -#define RMNET_MAP_GET_CD_BIT(Y) (((struct rmnet_map_header *) \ - (Y)->data)->cd_bit) -#define RMNET_MAP_GET_PAD(Y) (((struct rmnet_map_header *) \ - (Y)->data)->pad_len) -#define RMNET_MAP_GET_CMD_START(Y) ((struct rmnet_map_control_command *) \ - ((Y)->data + \ - sizeof(struct rmnet_map_header))) -#define RMNET_MAP_GET_LENGTH(Y) (ntohs(((struct rmnet_map_header *) \ - (Y)->data)->pkt_len)) - #define RMNET_MAP_COMMAND_REQUEST 0 #define RMNET_MAP_COMMAND_ACK 1 #define RMNET_MAP_COMMAND_UNSUPPORTED 2 diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c index beaee49621287..add0f5ade2e61 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c @@ -12,12 +12,13 @@ static u8 rmnet_map_do_flow_control(struct sk_buff *skb, struct rmnet_port *port, int enable) { + struct rmnet_map_header *map_header = (void *)skb->data; struct rmnet_endpoint *ep; struct net_device *vnd; u8 mux_id; int r; - mux_id = RMNET_MAP_GET_MUX_ID(skb); + mux_id = map_header->mux_id; if (mux_id >= RMNET_MAX_LOGICAL_EP) { kfree_skb(skb); @@ -49,6 +50,7 @@ static void rmnet_map_send_ack(struct sk_buff *skb, unsigned char type, struct rmnet_port *port) { + struct rmnet_map_header *map_header = (void *)skb->data; struct rmnet_map_control_command *cmd; struct net_device *dev = skb->dev; @@ -58,7 +60,8 @@ static void rmnet_map_send_ack(struct sk_buff *skb, skb->protocol = htons(ETH_P_MAP); - cmd = RMNET_MAP_GET_CMD_START(skb); + /* Command data immediately follows the MAP header */ + cmd = (struct rmnet_map_control_command *)(map_header + 1); cmd->cmd_type = type & 0x03; netif_tx_lock(dev); @@ -71,11 +74,13 @@ static void rmnet_map_send_ack(struct sk_buff *skb, */ void rmnet_map_command(struct sk_buff *skb, struct rmnet_port *port) { + struct rmnet_map_header *map_header = (void *)skb->data; struct rmnet_map_control_command *cmd; unsigned char command_name; unsigned char rc = 0; - cmd = RMNET_MAP_GET_CMD_START(skb); + /* Command data immediately follows the MAP header */ + cmd = (struct rmnet_map_control_command *)(map_header + 1); command_name = cmd->command_name; switch (command_name) { diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c index bd1aa11c9ce59..fd55269c2ce3c 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c @@ -321,7 +321,7 @@ struct sk_buff *rmnet_map_deaggregate(struct sk_buff *skb, return NULL; maph = (struct rmnet_map_header *)skb->data; - packet_len = ntohs(maph->pkt_len) + sizeof(struct rmnet_map_header); + packet_len = ntohs(maph->pkt_len) + sizeof(*maph); if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4) packet_len += sizeof(struct rmnet_map_dl_csum_trailer); @@ -330,7 +330,7 @@ struct sk_buff *rmnet_map_deaggregate(struct sk_buff *skb, return NULL; /* Some hardware can send us empty frames. Catch them */ - if (ntohs(maph->pkt_len) == 0) + if (!maph->pkt_len) return NULL; skbn = alloc_skb(packet_len + RMNET_MAP_DEAGGR_SPACING, GFP_ATOMIC);