From patchwork Thu Mar 11 03:33:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hoang Le X-Patchwork-Id: 398234 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF50FC433E0 for ; Thu, 11 Mar 2021 03:34:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9225164FCD for ; Thu, 11 Mar 2021 03:34:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbhCKDd6 (ORCPT ); Wed, 10 Mar 2021 22:33:58 -0500 Received: from mail-eopbgr00108.outbound.protection.outlook.com ([40.107.0.108]:62782 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230468AbhCKDdj (ORCPT ); Wed, 10 Mar 2021 22:33:39 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=doH+xqy93DCk7fU+gKXDYzAcRXn4/gv9kpErBrnK8DJlRAD3zEr5OqD6mfVIb29itCEfBw6OJMRkIaK9lQGJSx/0kgnSoHmTd/riy+WwbVefrixIOpyXdFtDPiP2+RSbrMOFfA2+X9F4Zax8vM0VMmk2PjU5QgPqMmhWoFOxIa0nagniWGXn6+k+bKv3DJfrDAFKLTv2wZu3vsDsoFII3o3RgItUpprRD8DmQCrhMvDDYHBwq6g4pel6PI8f+8OfaQItZ6ZpEeOr18bWqkvQBJPEmek7vKnS1el4dJYHsDFYn98MjRIwPsxRPC3B7rjvCCudgh4fF71HFl9wpTPLcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mf2IMQ5oQssSJiD/7gbnrV+fH2OU6xJAHR1DqReUfFs=; b=YB12pMefku9m1EKKYf+ekC2Xk3BteBqDGSq67OiiXscY48CSNozzRGHxmokQCUFxDI+clQSQ2aRgSfpOi15fOU13y6DIC2rw2JOMa10ziAXnZTLTppcNDd45PQTkulZ8O5SHwXMXt7EKSvb+gbypHujoePRLqTiEXLy7vy2z80D+HJEaCPk500k08gOIjQkR+/Bp7CUJx5F/UWN8C7Uy5CTzr5XWU3dCiruYraOAV9+1KbgkECtUZyJpuOFpU+tVOcxnD+nwarY609fokrmNAzaIZSxIT09ALQR+wpuQxtsfyAJA31tVCiIi4GlswFQQ08z8BsXXh0ts6Qfs37IjRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=dektech.com.au; dmarc=pass action=none header.from=dektech.com.au; dkim=pass header.d=dektech.com.au; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dektech.com.au; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mf2IMQ5oQssSJiD/7gbnrV+fH2OU6xJAHR1DqReUfFs=; b=LYBSfT3KOgXgN4/lCEyswTt7NnHWr3GvNLuFwqVvRJCKrJf0afkDqJgdEqm2yhdrPX3bef3LxFEItJ27ls31A0e7T/4gIDFjy88iV+05HXlpVDKObfF0TVxIyrqEtLr4uMeX+MR+8qXNh/LONCMiaZOV7KWpgLnJVB4iYElfRaU= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none; redhat.com; dmarc=none action=none header.from=dektech.com.au; Received: from VI1PR05MB4605.eurprd05.prod.outlook.com (2603:10a6:802:61::21) by VI1PR05MB6720.eurprd05.prod.outlook.com (2603:10a6:800:139::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31; Thu, 11 Mar 2021 03:33:37 +0000 Received: from VI1PR05MB4605.eurprd05.prod.outlook.com ([fe80::5573:2fb4:56e0:1cc3]) by VI1PR05MB4605.eurprd05.prod.outlook.com ([fe80::5573:2fb4:56e0:1cc3%7]) with mapi id 15.20.3868.041; Thu, 11 Mar 2021 03:33:37 +0000 From: Hoang Huu Le To: jmaloy@redhat.com, maloy@donjonn.com, ying.xue@windriver.com, kuba@kernel.org, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net Cc: Hoang Le Subject: [net-next 1/2] tipc: convert dest node's address to network order Date: Thu, 11 Mar 2021 10:33:22 +0700 Message-Id: <20210311033323.191873-1-hoang.h.le@dektech.com.au> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [14.161.14.188] X-ClientProxiedBy: SG2PR0302CA0003.apcprd03.prod.outlook.com (2603:1096:3:2::13) To VI1PR05MB4605.eurprd05.prod.outlook.com (2603:10a6:802:61::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from dektech.com.au (14.161.14.188) by SG2PR0302CA0003.apcprd03.prod.outlook.com (2603:1096:3:2::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3955.9 via Frontend Transport; Thu, 11 Mar 2021 03:33:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd737322-f434-4a73-dca5-08d8e43e749b X-MS-TrafficTypeDiagnostic: VI1PR05MB6720: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1Mn/DvdEDrmZPKlD81XZhLQCpv+6dh2FIflNrKnvkpal21dqtJKJnIwE1a7p8urYa/EnySUPmAK0q++bLUbVlbeh+RsKQXhlvWf29GxDQGAaB/5fL8rGUCFDr/nnIKohiVugZ9LAYWN06vMeiDdMKhQxbqZwynxRmZ0ZlMLPwx7NxHmbnk8f99GtqpA8/HU2JSnFcAG9wAN2RGgrGeZLiTfWCmLhg5FX4pz74WVfFZQiKhVMWIUNP25gl8JxX5evBAjvivSCSZbsfq3R59/EgqpTD6qNGkD9B7ckE/vHXpXuAhse8pcHE91HOp6Xf/da+p5v2xQC/LPdcGPBI8eZr02bSFAhyuVeFI/jO4LEXpxUrIHJhrPZLxtJy/b54QEE1G41XB3gVmXnqsJ5y4lCKYN5d4sfU6IxYidXzxQtaHYPxzN6JT4MBcL5jMTAQu51wvv8qWumN0RxJUYlhiMmfRzG4tr3VmmxHNHJOyq3Kaayn2K8qXL33/fr6/TdnUY2f7It/xcgCUush1utt6oLS5S0UX8YhX+gvN44tVC4d4zS/ZTqeeOhR5f9wB3Ctx2f X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR05MB4605.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(39840400004)(346002)(396003)(376002)(107886003)(2906002)(36756003)(5660300002)(478600001)(1076003)(16526019)(4326008)(26005)(66476007)(956004)(2616005)(186003)(66556008)(66946007)(8676002)(6666004)(316002)(103116003)(7696005)(52116002)(83380400001)(86362001)(55016002)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: btWCpyhAuQF33S8y6Wqo5ruX7bfDd17Jw5CsO3dQQ0/Dc6wpiFOZK2HAbW8wvpah6+wgHAoM1ZOmLzqh7yOAFt8HeXcsAUFj2kZ492u7EwS963x++Q84BK+w6i2vqHC/c2VMwMI5QLpoHzX94hOjbGvEYRWCJd7uJjx9XFSs0ptvZLte9lAP5W0/mvhWsscRbXxIPcJ/yPyqoXdHabxLShgZXAK+aZ6RFOvbbSHFbcGoONvnYWsbPZLtdob3dQtiD20YzM8vC4H2c7331KioP2MR60q7L6CQj6hBuUKDSNBx6Z09Ba0vMEF+TX8hEJ+v1qXktDotLeoPlwWJVMGDvK9m4Qt/Dsyx29W+gL8RStplr+dn24rPxfOd8GbU2yQK6mFbGvI7SE3j2IuThI9RATbUNJi1TLDRcA2nPj8roDRrq9RSiQ98Qu+Sbz0aXBMSPRhL6PVi74q7evHln0y896KO+nBck9bneNhAf8PWPOn7TaEk83H4yEmqA3vFEqLABHWCX5igkK6d+vI4OfbXWt7qacSIP6NuDngBBMiusq7pExuaeEioP/+KFCg7+21ClsSuewCmAQrWqev0EkSlZeVUn6tV4h9fh2oMGPhDzTBDTcmYHO910rz9UDJk5AcSAi2J2+FDcX9DPI3ullnZNw8eVJ6V94u1xRbOPw/zvLg1axxxwBjc1JqqULx/qjqvGxS7iXlsGmE/KPLLMd50D43goFRz+80EoY9kBfDqHJU6WjoY5jOGwKpaLDbVxweMEvzwfa9Hk4MWWOTtWJZzjzIOhsUdzRrpHNrROl6sPrtDTu/6IWHag1hSPuvhWydTPmr1CwhAJDeamRJ8fh5rKmHTCkjIQEf6hnFQm629S/sGSuvKfeEyy6xJXBXJR96WmYWe6Q3xDfdfpprdna59JQR6M5RnKDW5SayyOxa8H5OJkRsH7KhnJtxlNQr3QOeCEBiVnzomh8g5v03qGRcQYif/GhPhkqqs1IiZp3hAMoB5aJbDCScal9o0jLxdEP7uqEViW8ZtIlRt1TVYoqFf9i9sYlNs1KsKTma6Q67MSd5fAFekIK00NmMAiYCDn0FC8XYCn1Z9mo2RMy2noc6lYxbKvqLFdc341pbJ2GpsRZtwr387bQg917+p32uwKoB3V0YKG7aLSPVobZwgEu29PVvpKO2Z74KaibhniOAX190GA/e14cu4TeBraGHU3gvtg7FSoMAhUPekOrKSzeqjUwDGzhvovknzCp7djcHqQFpgRoJFUzQE4tRFfbAVWlsScU8R7yGzm6HOpxEsretDwGJtyxuFALqi/GilMZCEkT2RvxM/FUK1+Ztb4WJVsSPe X-OriginatorOrg: dektech.com.au X-MS-Exchange-CrossTenant-Network-Message-Id: bd737322-f434-4a73-dca5-08d8e43e749b X-MS-Exchange-CrossTenant-AuthSource: VI1PR05MB4605.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2021 03:33:37.2169 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 1957ea50-0dd8-4360-8db0-c9530df996b2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KAGuraI0tJE7yZEqpDFA0lUDa2rY+gkxf3RMssDb1xiuDWPFDB7o6znBg0ZEpSmtCd4EeU+V7aaQuhczunOenwGGxiPCdNA58bMLiSP9/N0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB6720 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hoang Le (struct tipc_link_info)->dest is in network order (__be32), so we must convert the value to network order before assigning. The problem detected by sparse: net/tipc/netlink_compat.c:699:24: warning: incorrect type in assignment (different base types) net/tipc/netlink_compat.c:699:24: expected restricted __be32 [usertype] dest net/tipc/netlink_compat.c:699:24: got int Acked-by: Jon Maloy Signed-off-by: Hoang Le --- net/tipc/netlink_compat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c index 5a1ce64039f7..0749df80454d 100644 --- a/net/tipc/netlink_compat.c +++ b/net/tipc/netlink_compat.c @@ -696,7 +696,7 @@ static int tipc_nl_compat_link_dump(struct tipc_nl_compat_msg *msg, if (err) return err; - link_info.dest = nla_get_flag(link[TIPC_NLA_LINK_DEST]); + link_info.dest = htonl(nla_get_flag(link[TIPC_NLA_LINK_DEST])); link_info.up = htonl(nla_get_flag(link[TIPC_NLA_LINK_UP])); nla_strscpy(link_info.str, link[TIPC_NLA_LINK_NAME], TIPC_MAX_LINK_NAME);