From patchwork Thu Apr 22 13:34:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 425865 Delivered-To: patch@linaro.org Received: by 2002:a02:c901:0:0:0:0:0 with SMTP id t1csp366645jao; Thu, 22 Apr 2021 06:34:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzKTlPGPfo3Fb1GuVKKLtMeYYAnshIiya7WpDB03DKNDYEG2bkVs3Nt+TiQJGmdFRWxiKjI X-Received: by 2002:a17:90a:8548:: with SMTP id a8mr4057188pjw.48.1619098497790; Thu, 22 Apr 2021 06:34:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1619098497; cv=none; d=google.com; s=arc-20160816; b=D9eoxE+e2MEAW+BXwHsVvLFwqawigVRgOMy77UfmcwImJNJCKirfxHMy2ms6Sb88ou SE8lcwJ/ioZ0RDJRNKCEWlvb4NuUUNZ54BpkvDnfJEcM9U8TAeRhextsblhQxD6g91z/ Q8jd3Wt94QHgsX9xFjCxYNE7CAqeXnwyLdx/ym8Z0g/ImkRfLsRb606VfYYYYesNr/5F 8RarNqOFZEnWV5nsocnqjLiNpFnaCY1STZrpbai5FB8rQE0gTR4OGGo75vxbvbrmWPIz XBWb0B69oc3nQgXg9KuQx0T4bToKtOF9JZA80qUzTYoDs33NYyj+eC2qNl4E7rZqiD8p TM6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=yS9WMuErPYGvHFCCFaCoOo9LVvWED28K3vace7WcnXo=; b=VQXKh/a+4Z3Q5q5mGqdqiyhfG/iQox/YmLHo5gniZqLa9b7GNaM3ym7C8kLRQYofNL ev0hQHwOdZqAQo+5XzbBV7kKGUuuJeU6lM887BD33jo/fMF2XRzQHxOujB/ERuI8nb6p iFXi5PEEDtnVQKgN9zY/6XkreUefdd+wi6M2XJBCnaAlChW/kmVjkQb+DAPbKmcYn7Tz VWpBLPukoPYUDWRI6hVKHny+nlYnZKR9C9oz/FTWWQx2dhKYsERgD7CI5v4tUBBOMJPZ IDNsvlPcZpRyffQxseZ2lQBLgfPBsaILgN+eU8gxbjFhh9f54rBBSLBGusiQhuv8R9A3 qF1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q3JCD4F6; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t66si3209271pgb.204.2021.04.22.06.34.57; Thu, 22 Apr 2021 06:34:57 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q3JCD4F6; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236500AbhDVNf3 (ORCPT + 8 others); Thu, 22 Apr 2021 09:35:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:60198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbhDVNf2 (ORCPT ); Thu, 22 Apr 2021 09:35:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C8AB56145D; Thu, 22 Apr 2021 13:34:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619098493; bh=IS0hEeTiqs7XtMtPtK1m8yhZxLJIwCvBXliPep3errM=; h=From:To:Cc:Subject:Date:From; b=q3JCD4F6Dd/N483qhRLRYC7LbkxO6oCIp2aXl1OH9bHSphEncru6ggEWHy2kheGK+ dOvy5eDPTqSJRWKqC4w0sfwW4fSkfbHULn3aWHt7k0cXEm9mPUyjyr/rhcphE/uM3q LlYAR/s14UQ/QMFeDSbiNeYndIuDG6OwKZiEU9eeXRsEZtYcvHkEamahoKBjEbNLJ8 7kRdCAqR0niaw/YVDUSoh63/T8jDzQUSn2Libqujcj2JoDlq4netcosQzte/w1kC7t U2OC5z5X2u4RPguYuQdvKMtvEy6VnJFCb63eWO8bv+DknJR7xKz/b8uPcN6J6OlW8H aHtd4HFPSa7CA== From: Arnd Bergmann To: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , "David S. Miller" , Jakub Kicinski Cc: Arnd Bergmann , Shachar Raindel , linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: mana: fix PCI_HYPERV dependency Date: Thu, 22 Apr 2021 15:34:34 +0200 Message-Id: <20210422133444.1793327-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann The MANA driver causes a build failure in some configurations when it selects an unavailable symbol: WARNING: unmet direct dependencies detected for PCI_HYPERV Depends on [n]: PCI [=y] && X86_64 [=y] && HYPERV [=n] && PCI_MSI [=y] && PCI_MSI_IRQ_DOMAIN [=y] && SYSFS [=y] Selected by [y]: - MICROSOFT_MANA [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICROSOFT [=y] && PCI_MSI [=y] && X86_64 [=y] drivers/pci/controller/pci-hyperv.c: In function 'hv_irq_unmask': drivers/pci/controller/pci-hyperv.c:1217:9: error: implicit declaration of function 'hv_set_msi_entry_from_desc' [-Werror=implicit-function-declaration] 1217 | hv_set_msi_entry_from_desc(¶ms->int_entry.msi_entry, msi_desc); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ A PCI driver should never depend on a particular host bridge implementation in the first place, but if we have this dependency it's better to express it as a 'depends on' rather than 'select'. Signed-off-by: Arnd Bergmann --- drivers/net/ethernet/microsoft/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.29.2 Reviewed-by: Dexuan Cui diff --git a/drivers/net/ethernet/microsoft/Kconfig b/drivers/net/ethernet/microsoft/Kconfig index e1ac0a5d808d..fe4e7a7d9c0b 100644 --- a/drivers/net/ethernet/microsoft/Kconfig +++ b/drivers/net/ethernet/microsoft/Kconfig @@ -18,7 +18,7 @@ if NET_VENDOR_MICROSOFT config MICROSOFT_MANA tristate "Microsoft Azure Network Adapter (MANA) support" depends on PCI_MSI && X86_64 - select PCI_HYPERV + depends on PCI_HYPERV help This driver supports Microsoft Azure Network Adapter (MANA). So far, the driver is only supported on X86_64.