diff mbox series

net: caif: Drop unnecessary NULL check after container_of

Message ID 20210513165840.1339544-1-linux@roeck-us.net
State New
Headers show
Series net: caif: Drop unnecessary NULL check after container_of | expand

Commit Message

Guenter Roeck May 13, 2021, 4:58 p.m. UTC
The first parameter passed to chnl_recv_cb() can never be NULL since all
callers dereferenced it. Consequently, container_of() on it is also never
NULL, even though the reference into the structure points to the first
element of the structure. The NULL check is therefore unnecessary.
On top of that, it is misleading to perform a NULL check on the result of
container_of() because the position of the contained element could change,
which would make the test invalid. Remove the unnecessary NULL check.

This change was made automatically with the following Coccinelle script.

type t;
identifier v;
statement s;

  t v = container_of(...);
  v = container_of(...);
  when != v
- if (\( !v \| v == NULL \) ) s

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
 net/caif/chnl_net.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series


diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c
index fadc7c8a3107..37b67194c0df 100644
--- a/net/caif/chnl_net.c
+++ b/net/caif/chnl_net.c
@@ -76,8 +76,6 @@  static int chnl_recv_cb(struct cflayer *layr, struct cfpkt *pkt)
 	u8 buf;
 	priv = container_of(layr, struct chnl_net, chnl);
-	if (!priv)
-		return -EINVAL;
 	skb = (struct sk_buff *) cfpkt_tonative(pkt);