diff mbox series

[net,v2,1/3] net: mdio-mux: Delete unnecessary devm_kfree

Message ID 20210817180841.3210484-2-saravanak@google.com
State New
Headers show
Series Clean up and fix error handling in mdio_mux_init() | expand

Commit Message

Saravana Kannan Aug. 17, 2021, 6:08 p.m. UTC
The whole point of devm_* APIs is that you don't have to undo them if you
are returning an error that's going to get propagated out of a probe()
function. So delete unnecessary devm_kfree() call in the error return path.

Signed-off-by: Saravana Kannan <saravanak@google.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Marc Zyngier <maz@kernel.org>
Tested-by: Marc Zyngier <maz@kernel.org>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
 drivers/net/mdio/mdio-mux.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series


diff --git a/drivers/net/mdio/mdio-mux.c b/drivers/net/mdio/mdio-mux.c
index 110e4ee85785..5b37284f54d6 100644
--- a/drivers/net/mdio/mdio-mux.c
+++ b/drivers/net/mdio/mdio-mux.c
@@ -181,7 +181,6 @@  int mdio_mux_init(struct device *dev,
 	dev_err(dev, "Error: No acceptable child buses found\n");
-	devm_kfree(dev, pb);