From patchwork Mon Sep 13 13:01:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 510295 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384C3C433EF for ; Mon, 13 Sep 2021 13:06:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FA6B60FA0 for ; Mon, 13 Sep 2021 13:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240008AbhIMNHX (ORCPT ); Mon, 13 Sep 2021 09:07:23 -0400 Received: from mail-bn8nam08on2055.outbound.protection.outlook.com ([40.107.100.55]:54369 "EHLO NAM04-BN8-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S240214AbhIMNF1 (ORCPT ); Mon, 13 Sep 2021 09:05:27 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nddEfKx6wxTYP3fTe5m7mV5BI7LJnNvAafe3xxKj5mnh18BuXBe2E+DPTYkcERy83C/3eBd9m84yH7vFCetctMQn7sdacwgjWuQ+ATRZtpO3fiZw/aU5ReRhzeZL1hcaxEMpjhl8RQiTh4+C+2nwZYn1M0MXWNnc1hb+3M6oTfpgzSmS5ML2k1fKV3JvJfFbKimkvkBqV1cg7NV1G3zdGtQbDf1/2Q8GYLPHSNXRqANmo717LXckjYHDnVKUq/lw9b8tCvSOYW6ZJl7rsnZF08mVIl0AgtnMmdxbL0sGGy++C8uCf8AbddIFDVExWlCaBhdB087X5zLx4lXuopQp3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NVQa1Hl+G/9t4WPq9A8FoAFRyiuHTVPsPDclPMhrcNY=; b=ldOpjwK9JAnij9f3NaDKGVBYDtLpyCRS7mRJj1TbD9aoj2M6zfaDZnPxxpaWdEOySh8JGH+PVVcoHzqz9Q0dkibxAibKWYh8UXbeuzeyKFxyxoj35+fivogT3MMSuVTL12051LTHFJ17SFVG79m7Tkfi6ITB9b/8loYbURNvFCXhL7DYDf4A7WM8xrshh3gGz7+SqZYNWK36JWSVi8HC2D4U4M1zPiHCyvNv0fGFgYvT5jCK7Em+X/d/tjG7mmXeq54SoTN3DM7khhwZEzaZ41qwRgEXOlbl+bN6W+gXukfVSo2Be8az8Dh21h9m43ZqgGX33kM05IPA8MLNALMCvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NVQa1Hl+G/9t4WPq9A8FoAFRyiuHTVPsPDclPMhrcNY=; b=ad3yuMhsaj9JSnKim0V/rFUCHeOmwwedM0H04cT9NRD0iC1JtaTHdTvIOMGktoJFMvLxWN1mAzFlWLKoFRICuPVKWiRKE0An31YRkVUP7b1WxBqYlyUweln1OIWkBFAqZk9Zy22DNw0o14y0CkpKd0kbTTFHd23ghHqVoHuILe4= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none; driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SA2PR11MB4860.namprd11.prod.outlook.com (2603:10b6:806:11b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Mon, 13 Sep 2021 13:02:49 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Mon, 13 Sep 2021 13:02:49 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v3 17/32] staging: wfx: simplify hif_join() Date: Mon, 13 Sep 2021 15:01:48 +0200 Message-Id: <20210913130203.1903622-18-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> References: <20210913130203.1903622-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (37.71.187.125) by PR2P264CA0021.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Mon, 13 Sep 2021 13:02:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31d99350-ba92-41a0-8d78-08d976b6c96a X-MS-TrafficTypeDiagnostic: SA2PR11MB4860: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gsRKnF0pb0cIQiHjjI/hdnwzII4TGfPCOx9pumC8p6PpIffAn96foX1Vr3lbKr9FW46QubQHtvOpMK/zdgYseo8qsVbBFghB5H89NylSlONuzuRErprHi1K5s//OfJ/D/ZcZ+1jGD5EKHbIp13EqGZgXxP5TxKG5sy30P4ZdBLozgaqZguvA58cNj3P/2E7y4nm7ccqgbBjTDmi8P87FZqomD4Hu5OIYtpzoIv3F9gsE1xe9hxg6ftQqRPgr5w8z5466e9gK7ngPyNYxPbvW8tLG1dA/2RWARKQTqJD4bEN8Q0xpw02z5db5TUyqiW7T6uWkQxlgzIUssHIe1xKVoq/yx2G7WagE+JV71UwsEf4MBGn0gX9Sl9DwHNB+EI2FXNmiSI/xmy5YaaUQNPA+QtUkao72Zz3oRhJfygFXJOcUmsa1+1vocpOOfYbTMbW2HimAR0TF4+uTD9V9DBDrvgJi2kFAEZsD2VeUv+gHti3nSd7Qis01lM4d9PHnXGcrD6LgU1HHitDe6ss2XRJ3vVHzBM0SGHUZKPzsF6pu1JdGNZW53C/KHEb/YrgivN9tUKV3tTETSkYYsBqHLFTBzRWRGiOSQmdDCbXcrAfgzYtGgosvde6U8g+2saNGPYFYmrgYaGadvPEuhIYOfZ8t+jF3OYKxGoxtZopdBCOplM9xoKWCGBlKOKzY0rvkz3vM9LVa0MWFIP35dNCi4/IJKw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2718.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(4744005)(66946007)(2616005)(26005)(36756003)(38100700002)(38350700002)(316002)(4326008)(107886003)(7696005)(54906003)(5660300002)(52116002)(66556008)(1076003)(66476007)(6486002)(508600001)(8936002)(83380400001)(86362001)(2906002)(8676002)(186003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dtDj8Z2ddEMFxwFRCNO46TOFc?= =?utf-8?q?HetDjUlnFHhz9jmxSth3Ynm53HmEqDRM5BBnqvCxHdATvyiqGL+gpsCB?= =?utf-8?q?a59RAeTysPYswzZfSz7E4l6XHmP8nPc/3sWyEV/A7lFebTgvOuBxTV0y?= =?utf-8?q?f2PcXx7iJn3VYVYW8PoP7CbyQesGU8QODuR5zBnfEjSmV3X5nD7J3aFt?= =?utf-8?q?FICLUdnDhMViv4nHInnkT12woXKDvzlcZZhn/g4xCiOuAyw4OEiuexNb?= =?utf-8?q?FueqZP7nL+od5+PGcmapf6IUymu0vBOA+ppdvFOyEMUjdnmCIZtmeHxy?= =?utf-8?q?4Tsdfa1lgACRQQq2sROcaiHBSJvMAzRtTu+j5dTOmUixpqEKulXNh3lp?= =?utf-8?q?ptA7trk0Hr0nwjw7YdzLd2d0DUk46wPix8wIJGGGcaOGwGeQbw2lDRW2?= =?utf-8?q?VUOkZZG8vfMTS8uaHan8+VNXqDO94RZJNKVu23xkVTF5mM27grSvld+S?= =?utf-8?q?ByWflowKS5rZD4W8Xj2f7nMXCT0g6AH+ywvUDnMpQpWG6L4uH7DVGldn?= =?utf-8?q?uioVeK0oURqXpXHGY2J4TG9QgTi+fhRvXOgdK1W5tPr1Q2IGW6cEk9GA?= =?utf-8?q?2UbB6mi1CXdhKvjgNHyVFq7r/meAO2uxaQQzOp0fbktKaIs+3CO/L0nI?= =?utf-8?q?UuJkOrHenw/ZBLSdXJHWbebFmmqYQ67yisDAyvffYYLpp0Wp9G493vyf?= =?utf-8?q?hu2y6lnzU6JtD0QpZhvFVEVF57etv2ZIaOv/+UgVZeJYnJxi1+cbuvJ/?= =?utf-8?q?Zj8hftyaIHmrgnsZAL622rHkANjvYGluVY/66jmEgG8e/OFyMA0WI55d?= =?utf-8?q?X5hjQljUxpbYS7sPHRmp/orxuWG5hXR25ysV/yZcsr3AxC4BlgHwJgo0?= =?utf-8?q?UsuErKehk/Zn9UQ0gxcfrG4FIxuHMUOwsaj5NAOKI/PIp8I4iOGgk1FO?= =?utf-8?q?JjJ3UDICEQqLihbRT4OUpax52VyRFwxOWVVtgoz53iwBo74dvc6rNnTZ?= =?utf-8?q?FAaIDNyqdmj88JhvikpxxlqEo0xGK646/Uu+84A41CW0y4jYrtFiPWhY?= =?utf-8?q?EcVBSKlaIbRCMl21Hsw06sdDez/sNhIhLbqIMUCnJEnvcIpXuckmkcnc?= =?utf-8?q?g7+rxXpBlDEJyOFSvcOOTYLy3BFgGVwKHJ5+3k5+K/xo0dykSmwg4sJy?= =?utf-8?q?IZSCaOEW9j55bn7+0dCBfQNLD+w2rxNNeXbopWNIVu6WBhfHzEhDb+36?= =?utf-8?q?yovdT99i1x1+djg36IFwJc332Q8N1coHCCV6Cprl0ombdrkpJ9Isujyd?= =?utf-8?q?rvFaxcTbavPfaTmExXzLVhQ7pso/LtEXIxpSWuZBOeprGxCamncnoRqF?= =?utf-8?q?D5ZuRc3L4hyAPBPA92APupfd/hdl/Im?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31d99350-ba92-41a0-8d78-08d976b6c96a X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2021 13:02:48.9292 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZGV7SD0RApLDhyI8UlSsMvRDThTGpJvlW/V8QJOXyOj3XCMn+XdmQDyB0/2KzXv7X7dYMZi841UeH4e5r3TjIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4860 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller The new code is smaller. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/hif_tx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/wfx/hif_tx.c b/drivers/staging/wfx/hif_tx.c index fcce78bb3005..c5ab1c2e1e07 100644 --- a/drivers/staging/wfx/hif_tx.c +++ b/drivers/staging/wfx/hif_tx.c @@ -305,10 +305,7 @@ int hif_join(struct wfx_vif *wvif, const struct ieee80211_bss_conf *conf, return -ENOMEM; body->infrastructure_bss_mode = !conf->ibss_joined; body->short_preamble = conf->use_short_preamble; - if (channel->flags & IEEE80211_CHAN_NO_IR) - body->probe_for_join = 0; - else - body->probe_for_join = 1; + body->probe_for_join = !(channel->flags & IEEE80211_CHAN_NO_IR); body->channel_number = channel->hw_value; body->beacon_interval = cpu_to_le32(conf->beacon_int); body->basic_rate_set =