diff mbox series

[net-next,4/6,v8] net: dsa: rtl8366rb: Fix off-by-one bug

Message ID 20210928144149.84612-5-linus.walleij@linaro.org
State New
Headers show
Series RTL8366(RB) cleanups part 1 | expand

Commit Message

Linus Walleij Sept. 28, 2021, 2:41 p.m. UTC
The max VLAN number with non-4K VLAN activated is 15, and the
range is 0..15. Not 16.

The impact should be low since we by default have 4K VLAN and
thus have 4095 VLANs to play with in this switch. There will
not be a problem unless the code is rewritten to only use
16 VLANs.

Fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
Cc: Mauri Sandberg <sandberg@mailfence.com>
Cc: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

ChangeLog v7->v8:
- Collect Florian's review tag.
ChangeLog v6->v7:
- Collect Alvin's and Vladimir's review tags.
ChangeLog v5->v6:
- No changes just resending with the rest of the
ChangeLog v4->v5:
- Add some more text describing that this is not a critical bug.
- Add Fixes tag
ChangeLog v1->v4:
- New patch for a bug discovered when fixing the other issues.
 drivers/net/dsa/rtl8366rb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series


diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
index b565074b0462..bb9d017c2f9f 100644
--- a/drivers/net/dsa/rtl8366rb.c
+++ b/drivers/net/dsa/rtl8366rb.c
@@ -1515,7 +1515,7 @@  static int rtl8366rb_set_mc_index(struct realtek_smi *smi, int port, int index)
 static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan)
-	unsigned int max = RTL8366RB_NUM_VLANS;
+	unsigned int max = RTL8366RB_NUM_VLANS - 1;
 	if (smi->vlan4k_enabled)
 		max = RTL8366RB_NUM_VIDS - 1;