From patchwork Thu May 28 23:21:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kubecek X-Patchwork-Id: 218275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA20DC433DF for ; Thu, 28 May 2020 23:21:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE90E2084C for ; Thu, 28 May 2020 23:21:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437522AbgE1XV5 (ORCPT ); Thu, 28 May 2020 19:21:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:49300 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2437506AbgE1XVj (ORCPT ); Thu, 28 May 2020 19:21:39 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id A64D3AFED; Thu, 28 May 2020 23:21:37 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id C6732E32D2; Fri, 29 May 2020 01:21:37 +0200 (CEST) Message-Id: <6c672d7a5d3b598cb8c8de5b624db87ab67a0176.1590707335.git.mkubecek@suse.cz> In-Reply-To: References: From: Michal Kubecek Subject: [PATCH ethtool 06/21] selftest: omit test-features if netlink is enabled To: John Linville , netdev@vger.kernel.org Cc: Andrew Lunn , Oleksij Rempel Date: Fri, 29 May 2020 01:21:37 +0200 (CEST) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The test-features selftest is checking data structures passed to ioctl() syscall. Therefore a complete rework of the test framework will be needed to be able to perform an equivalent selftest for netlink interface. Until such framework is implemented, disable test-features when building ethtool with netlink support. Signed-off-by: Michal Kubecek --- Makefile.am | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 0f8465f7ada9..b3ffae52f1e9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -40,12 +40,16 @@ AM_CPPFLAGS += @MNL_CFLAGS@ LDADD += @MNL_LIBS@ endif -TESTS = test-cmdline test-features -check_PROGRAMS = test-cmdline test-features +TESTS = test-cmdline +check_PROGRAMS = test-cmdline test_cmdline_SOURCES = test-cmdline.c test-common.c $(ethtool_SOURCES) test_cmdline_CFLAGS = -DTEST_ETHTOOL +if !ETHTOOL_ENABLE_NETLINK +TESTS += test-features +check_PROGRAMS += test-features test_features_SOURCES = test-features.c test-common.c $(ethtool_SOURCES) test_features_CFLAGS = -DTEST_ETHTOOL +endif dist-hook: cp $(top_srcdir)/ethtool.spec $(distdir)