diff mbox series

[net,3/3] sh_eth: fix TRSCER mask for R7S9210

Message ID 75bbbe07-60c0-c556-41fa-8a4ddd117f5a@omprussia.ru
State Superseded
Headers show
Series Fix TRSCER masks in the Ether driver | expand

Commit Message

Sergey Shtylyov Feb. 28, 2021, 8:27 p.m. UTC
According  to the RZ/A2M Group User's Manual: Hardware, Rev. 2.00,
the TRSCER register has bit 9 reserved, hence we can't use the driver's
default TRSCER mask.  Add the explicit initializer for sh_eth_cpu_data::
trscer_err_mask for R7S9210.

Fixes: 6e0bb04d0e4f ("sh_eth: Add R7S9210 support")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>

---
 drivers/net/ethernet/renesas/sh_eth.c |    2 ++
 1 file changed, 2 insertions(+)

Comments

Geert Uytterhoeven March 4, 2021, 8:51 a.m. UTC | #1
On Sun, Feb 28, 2021 at 9:56 PM Sergey Shtylyov <s.shtylyov@omprussia.ru> wrote:
> According  to the RZ/A2M Group User's Manual: Hardware, Rev. 2.00,

> the TRSCER register has bit 9 reserved, hence we can't use the driver's

> default TRSCER mask.  Add the explicit initializer for sh_eth_cpu_data::

> trscer_err_mask for R7S9210.

>

> Fixes: 6e0bb04d0e4f ("sh_eth: Add R7S9210 support")

> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>


Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>


Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox series

Patch

Index: net/drivers/net/ethernet/renesas/sh_eth.c
===================================================================
--- net.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net/drivers/net/ethernet/renesas/sh_eth.c
@@ -782,6 +782,8 @@  static struct sh_eth_cpu_data r7s9210_da
 
 	.fdr_value	= 0x0000070f,
 
+	.trscer_err_mask = DESC_I_RINT8 | DESC_I_RINT5,
+
 	.apr		= 1,
 	.mpr		= 1,
 	.tpauser	= 1,