From patchwork Wed Jul 27 17:09:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 72907 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp424535qga; Wed, 27 Jul 2016 10:12:53 -0700 (PDT) X-Received: by 10.36.76.16 with SMTP id a16mr93187226itb.86.1469639569434; Wed, 27 Jul 2016 10:12:49 -0700 (PDT) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id z201si8278949itb.24.2016.07.27.10.12.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jul 2016 10:12:49 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSSLD-0004Kl-Ul; Wed, 27 Jul 2016 17:09:55 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bSSLD-0004KI-56 for xen-devel@lists.xen.org; Wed, 27 Jul 2016 17:09:55 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id 14/9E-01541-2EAE8975; Wed, 27 Jul 2016 17:09:54 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRWlGSWpSXmKPExsVysyfVTffhqxn hBrePaVgs+biYxYHR4+ju30wBjFGsmXlJ+RUJrBmzD29lL+jQqHj1bhJzA+M1+S5GLg4hgY2M EjNnfGGEcE4zSmxbuJy9i5GTg01AU+LO509MILaIgLTEtc+XwYqYBdoYJdbOnsoIkhAWCJB4s OgtM4jNIqAqceP1P7AGXgFnifMfT4DVSAjISZw8NpkVxOYUcJHouN4GViMEVDNn7z7WCYzcCx gZVjFqFKcWlaUW6RoZ6yUVZaZnlOQmZuboGhqa6OWmFhcnpqfmJCYV6yXn525iBPq4noGBcQf jrON+hxglOZiURHm5ns0IF+JLyk+pzEgszogvKs1JLT7EKMPBoSTBW/cSKCdYlJqeWpGWmQMM Npi0BAePkgjvBpA0b3FBYm5xZjpE6hSjopQ4rxxIQgAkkVGaB9cGC/BLjLJSwryMDAwMQjwFq UW5mSWo8q8YxTkYlYR554NM4cnMK4Gb/gpoMRPQ4uJYsMUliQgpqQbGE0bqG/g3qFhVsrDtSJ vOOef5pGq3/iZLyaVWc5MMD35dtPKw/YWF6xsC2oylXr7s6/CfttDvpqWL9qbH25aeExfIWLr 55MmdtxZ/mHh6afTeHM2jpT+W390U/j98W0OO0R+hWy9YXzu9/3nrIp9l9w+9R7GMCvcr7jTy 706Nfh6ktIpvwvTDr5RYijMSDbWYi4oTAQqmz2ZrAgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-4.tower-27.messagelabs.com!1469639391!55464211!2 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 57457 invoked from network); 27 Jul 2016 17:09:53 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-4.tower-27.messagelabs.com with SMTP; 27 Jul 2016 17:09:53 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FE6E2F; Wed, 27 Jul 2016 10:11:09 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.218.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D140E3F213; Wed, 27 Jul 2016 10:09:51 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Wed, 27 Jul 2016 18:09:38 +0100 Message-Id: <1469639378-9244-7-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1469639378-9244-1-git-send-email-julien.grall@arm.com> References: <1469639378-9244-1-git-send-email-julien.grall@arm.com> Cc: andre.przywara@arm.com, Julien Grall , sstabellini@kernel.org, steve.capper@arm.com, wei.chen@linaro.org Subject: [Xen-devel] [PATCH v2 6/6] xen/arm: arm64: Add Cortex-A57 erratum 834220 workaround X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" The ARM erratum applies to certain revisions of Cortex-A57. The processor may report a Stage 2 translation fault as the result of Stage 1 fault for load crossing a page boundary when there is a permission fault or device memory fault at stage 1 and a translation fault at Stage 2. So Xen needs to check that Stage 1 translation does not generate a fault before handling the Stage 2 fault. If it is a Stage 1 translation fault, return to the guest to let the processor injecting the correct fault. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- Changes in v2: - Add Stefano's reviewed-by --- docs/misc/arm/silicon-errata.txt | 1 + xen/arch/arm/Kconfig | 21 +++++++++++++++++++++ xen/arch/arm/cpuerrata.c | 9 +++++++++ xen/arch/arm/traps.c | 5 +++-- xen/include/asm-arm/cpuerrata.h | 1 + xen/include/asm-arm/cpufeature.h | 3 ++- 6 files changed, 37 insertions(+), 3 deletions(-) diff --git a/docs/misc/arm/silicon-errata.txt b/docs/misc/arm/silicon-errata.txt index 220f724..c9854c3 100644 --- a/docs/misc/arm/silicon-errata.txt +++ b/docs/misc/arm/silicon-errata.txt @@ -47,3 +47,4 @@ stable hypervisors. | ARM | Cortex-A53 | #819472 | ARM64_ERRATUM_819472 | | ARM | Cortex-A57 | #852523 | N/A | | ARM | Cortex-A57 | #832075 | ARM64_ERRATUM_832075 | +| ARM | Cortex-A57 | #834220 | ARM64_ERRATUM_834220 | diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index e26c4c8..871c243 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -142,6 +142,27 @@ config ARM64_ERRATUM_832075 If unsure, say Y. +config ARM64_ERRATUM_834220 + bool "Cortex-A57: 834220: Stage 2 translation fault might be incorrectly reported in presence of a Stage 1 fault" + default y + depends on ARM_64 + help + This option adds an alternative code sequence to work around ARM + erratum 834220 on Cortex-A57 parts up to r1p2. + + Affected Cortex-A57 parts might report a Stage 2 translation + fault as the result of a Stage 1 fault for load crossing a + page boundary when there is a permission or device memory + alignment fault at Stage 1 and a translation fault at Stage 2. + + The workaround is to verify that the Stage 1 translation + doesn't generate a fault before handling the Stage 2 fault. + Please note that this does not necessarily enable the workaround, + as it depends on the alternative framework, which will only patch + the kernel if an affected CPU is detected. + + If unsure, say Y. + endmenu source "common/Kconfig" diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c index 748e02e..a3e8dda 100644 --- a/xen/arch/arm/cpuerrata.c +++ b/xen/arch/arm/cpuerrata.c @@ -49,6 +49,15 @@ static const struct arm_cpu_capabilities arm_errata[] = { (1 << MIDR_VARIANT_SHIFT) | 2), }, #endif +#ifdef CONFIG_ARM64_ERRATUM_834220 + { + /* Cortex-A57 r0p0 - r1p2 */ + .desc = "ARM erratum 834220", + .capability = ARM64_WORKAROUND_834220, + MIDR_RANGE(MIDR_CORTEX_A57, 0x00, + (1 << MIDR_VARIANT_SHIFT) | 2), + }, +#endif {}, }; diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 83a30fa..13935e8 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -2388,12 +2388,13 @@ static inline bool hpfar_is_valid(bool s1ptw, uint8_t fsc) * HPFAR is valid if one of the following cases are true: * 1. the stage 2 fault happen during a stage 1 page table walk * (the bit ESR_EL2.S1PTW is set) - * 2. the fault was due to a translation fault + * 2. the fault was due to a translation fault and the processor + * does not carry erratum #8342220 * * Note that technically HPFAR is valid for other cases, but they * are currently not supported by Xen. */ - return s1ptw || (fsc == FSC_FLT_TRANS); + return s1ptw || (fsc == FSC_FLT_TRANS && !check_workaround_834220()); } static void do_trap_instr_abort_guest(struct cpu_user_regs *regs, diff --git a/xen/include/asm-arm/cpuerrata.h b/xen/include/asm-arm/cpuerrata.h index 5880e77..5e35b4f 100644 --- a/xen/include/asm-arm/cpuerrata.h +++ b/xen/include/asm-arm/cpuerrata.h @@ -41,6 +41,7 @@ static inline bool_t check_workaround_##erratum(void) \ #endif CHECK_WORKAROUND_HELPER(766422, ARM32_WORKAROUND_766422, CONFIG_ARM_32) +CHECK_WORKAROUND_HELPER(834220, ARM64_WORKAROUND_834220, CONFIG_ARM_64) #undef CHECK_WORKAROUND_HELPER diff --git a/xen/include/asm-arm/cpufeature.h b/xen/include/asm-arm/cpufeature.h index ac6eaf0..66e930f 100644 --- a/xen/include/asm-arm/cpufeature.h +++ b/xen/include/asm-arm/cpufeature.h @@ -38,8 +38,9 @@ #define ARM64_WORKAROUND_CLEAN_CACHE 0 #define ARM64_WORKAROUND_DEVICE_LOAD_ACQUIRE 1 #define ARM32_WORKAROUND_766422 2 +#define ARM64_WORKAROUND_834220 3 -#define ARM_NCAPS 3 +#define ARM_NCAPS 4 #ifndef __ASSEMBLY__