From patchwork Fri Feb 3 19:18:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 93302 Delivered-To: patch@linaro.org Received: by 10.140.20.99 with SMTP id 90csp738106qgi; Fri, 3 Feb 2017 11:21:01 -0800 (PST) X-Received: by 10.107.59.193 with SMTP id i184mr11378225ioa.86.1486149661943; Fri, 03 Feb 2017 11:21:01 -0800 (PST) Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id o93si4130909ioi.151.2017.02.03.11.21.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Feb 2017 11:21:01 -0800 (PST) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZjO7-0004BP-61; Fri, 03 Feb 2017 19:19:15 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZjO6-0004A1-Ab for xen-devel@lists.xen.org; Fri, 03 Feb 2017 19:19:14 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id A4/F4-02139-1B7D4985; Fri, 03 Feb 2017 19:19:13 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrGLMWRWlGSWpSXmKPExsVysyfVTXfj9Sk RBg8/MVos+biYxYHR4+ju30wBjFGsmXlJ+RUJrBl7f+gV/OSomLnmM1MD4zT2LkYuDiGBTYwS 5y91sUA4pxkltl1pZexi5ORgE9CUuPP5ExOILSIgLXHt82WwOLNAlMSdiztZQGxhAX+JV+cXs 4PYLAKqEud2XgezeQVcJB4fWgFmSwjISZw8NpkVxOYUcJX4fm4d2EwhoJrF7R0sExi5FzAyrG LUKE4tKkst0jW00EsqykzPKMlNzMzRNTQw1ctNLS5OTE/NSUwq1kvOz93ECPQvAxDsYGza7nm IUZKDSUmUt+jalAghvqT8lMqMxOKM+KLSnNTiQ4wyHBxKErwLQHKCRanpqRVpmTnAQINJS3Dw KInwrgRJ8xYXJOYWZ6ZDpE4xKkqJ8xqDJARAEhmleXBtsOC+xCgrJczLCHSIEE9BalFuZgmq/ CtGcQ5GJWHeXSBTeDLzSuCmvwJazAS0+OfjSSCLSxIRUlINjHxdr57xv1u4WYJRo/ZnpHfGB5 FyDWbJqps3J8Z5JL37f9z60//96c2H5PWvpr2VrjtTtjd1+9fHNk5V0gnzRA+wXly3MfP2gmm 7p/MIPRCNDPLKV9uW0CuZ58A5Q+rOjo09J//c2aG+YLF5TJZes1bEofKmuf7cwjuN2Oq9fS+v nzLb9RVTjhJLcUaioRZzUXEiAIF4hKtpAgAA X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-4.tower-206.messagelabs.com!1486149552!83329417!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.1.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 1106 invoked from network); 3 Feb 2017 19:19:12 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-4.tower-206.messagelabs.com with SMTP; 3 Feb 2017 19:19:12 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 41CDCAD7; Fri, 3 Feb 2017 11:19:12 -0800 (PST) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.218.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 82BC73F242; Fri, 3 Feb 2017 11:19:11 -0800 (PST) From: Julien Grall To: xen-devel@lists.xen.org Date: Fri, 3 Feb 2017 19:18:47 +0000 Message-Id: <1486149538-20432-4-git-send-email-julien.grall@arm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1486149538-20432-1-git-send-email-julien.grall@arm.com> References: <1486149538-20432-1-git-send-email-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org, shankerd@codeaurora.org Subject: [Xen-devel] [PATCH 2/7] xen/arm: acpi: Don't fallback on DT when user request ACPI X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" On ARM, when the user put 'acpi=force' Xen will use ACPI over DT. Currently, if Xen fails to initialize ACPI it will fallback on DT. This behavior makes difficult for a user to notice Xen didn't used ACPI has requested on platform where the firmware is providing both ACPI and DT. Rather than fallback on DT during a failure, panic when 'acpi=force'. Signed-off-by: Julien Grall --- I am wondering if we should do the same with acpi=on. So a user would notice directly if something went wrong with ACPI. Otherwise you would boot up to the prompt and barely notice that DT was used. --- xen/arch/arm/acpi/boot.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c index 889208a..65ef632 100644 --- a/xen/arch/arm/acpi/boot.c +++ b/xen/arch/arm/acpi/boot.c @@ -272,6 +272,11 @@ int __init acpi_boot_table_init(void) return 0; disable: + + /* Panic if the user has requested ACPI but Xen is able to initialize. */ + if ( param_acpi_force ) + panic("Unable to use ACPI"); + disable_acpi(); return error;