From patchwork Mon Feb 18 10:21:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 158584 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp2314748jaa; Mon, 18 Feb 2019 02:23:12 -0800 (PST) X-Google-Smtp-Source: AHgI3IZsFC2pSjy/dLhzfPkBsauy+/yRDYkDweYHx8AzDupq2un9xX7By9jUuyL59bCpPy+j0aTK X-Received: by 2002:a25:8008:: with SMTP id m8mr18937620ybk.35.1550485392390; Mon, 18 Feb 2019 02:23:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550485392; cv=none; d=google.com; s=arc-20160816; b=QLyT3eigZy7LXQq4KoEtWRxJb6rrj4zEHEeK526xMQuiam0eEaUcPisFKhD8N9q67H jAPQ7O2EUDqNryBZMmhWEMeFHlfLZX5VnNj7Hb7LZn/CpSBQUTlD6A4xmPLtClepaACV F8iXkq5LKensRoHewtG1eTh+lj22bHJBh+VgcUTCVXJ/m56De0P6M/Ju0Pdeh4atfu8H RMez5yKrv7tfiUcfW06keHWyLmg0U/9RoKKpE4MB9dPLwIpkEZVfg/z3AAHXDOb/24dw P7br9WBWzhBqnj+Bn/Hibn/bp15zBI3PWLtH0OOuCg4MRflM7y8OJIXh4HIT61zDwcpg VWbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:message-id:date:to:from; bh=6mII50447NklBnne+TO6NKu9oorVgpCbgkX1rP6nGZE=; b=UWPCztKgjN5WpB9zu2nJnWZt/sY/WAY/wWi2YBQoyv4vY928R+TMTIRgvigbWuQcj3 58YA/BDzkNdM/G3qYgt3bUT3YfOhXydWXxptr7cmafiduBjFuY0BmV5v1Dew3yS8hcmn hB9Iy4J6FdpKzLasl9iqLcB4psfMhfThM0GrB706QJ1WiHA0IPBft2P0G25Rl6uH5OOJ FeI7unJS/FJz2JtQ4RL3loq/WJZy9lgXgoByUABUfNsYte9NpHD/ORp4Dt9nJZ1/83Ad QU/CSpmj0dcvNWy/ZjlRPJFO/9MYViFxLhXqZ3ewG2qitxyo34SD2cMck8VNGq8YKgH9 S2oQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id k128si7161932ywa.131.2019.02.18.02.23.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Feb 2019 02:23:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gvg34-0002pY-JY; Mon, 18 Feb 2019 10:21:18 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gvg33-0002pT-7h for xen-devel@lists.xenproject.org; Mon, 18 Feb 2019 10:21:17 +0000 X-Inumbo-ID: ec3fa536-3366-11e9-bc90-bc764e045a96 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id ec3fa536-3366-11e9-bc90-bc764e045a96; Mon, 18 Feb 2019 10:21:15 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2655280D; Mon, 18 Feb 2019 02:21:15 -0800 (PST) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 15E483F720; Mon, 18 Feb 2019 02:21:13 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 18 Feb 2019 10:21:06 +0000 Message-Id: <20190218102106.32163-1-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 Subject: [Xen-devel] [PATCH for-4.12 v2] xen/arm: domain_build: Panic message should end with a newline X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, andrew.cooper3@citrix.com, Julien Grall , sstabellini@kernel.org MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Since commit 25eb5eec79 "xen: Fix inconsistent callers of panic()" all the panic message should end with a newline. Unfortunately, some commits pushed afterwards does not follow the rule. Modify the offending panic messages to avoid more inconsistency. Signed-off-by: Julien Grall Acked-by: Andrew Cooper Reviewed-by: Stefano Stabellini --- Cc: andrew.cooper3@citrix.com --- xen/arch/arm/domain_build.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index c92f8c6be1..d9836779d1 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -1580,7 +1580,7 @@ static int __init make_gic_domU_node(const struct domain *d, void *fdt) case GIC_V2: return make_gicv2_domU_node(d, fdt); default: - panic("Unsupported GIC version"); + panic("Unsupported GIC version\n"); } } @@ -2086,12 +2086,12 @@ void __init create_domUs(void) d = domain_create(++max_init_domid, &d_cfg, false); if ( IS_ERR(d) ) - panic("Error creating domain %s", dt_node_name(node)); + panic("Error creating domain %s\n", dt_node_name(node)); d->is_console = true; if ( construct_domU(d, node) != 0 ) - panic("Could not set up domain %s", dt_node_name(node)); + panic("Could not set up domain %s\n", dt_node_name(node)); domain_unpause_by_systemcontroller(d); }