From patchwork Mon Apr 22 16:49:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 162614 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp2801425jan; Mon, 22 Apr 2019 09:51:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqxiTqyrloVidmlzhPW+w2fEzhyUzideM6hdawCiEOKqMl1yzhLffn5XMewUcHATVqvXR061 X-Received: by 2002:a81:62c5:: with SMTP id w188mr16213530ywb.328.1555951883212; Mon, 22 Apr 2019 09:51:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555951883; cv=none; d=google.com; s=arc-20160816; b=Diz8lkYdpRylYDk1WLN7WU4ydwYoUw/bu1fECfv1FlqaekX7SIxETDLvdg/TG/sIPe 8lGpyFYAf/REX3HkpzxAanZEpcmtn7v+YBiFAo0wB6709k3iP2A6rg4CIgbHGe+KGSzf iTsh8C5g1AkDpUfX5TLtObejQJ1LOP45PAS+IEk5Fs9U1JqlOe7sd2YK21C5PMZ7G/5t h9A48SN6rAxXi1Ys3QuHhURc9Iyjfe8nEpqb/gj/RKGOrykSzpkuclEy3mwI3wY51td8 HLCPpHUTbdqzREf0D9nWLVcOmLKWcKAQ/LclsQWLosP0z5o5Rc/w+QDswIekJMN5KZL8 8xmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=G1r+Hl1PQSSb1OK2ietNjKme1goxhhtJivpZcD0sWCw=; b=ptP7so2CEVvBGNbnO/lkw75rN2XjpiDTNjWnIHurEutNo/+3i6gPBoWpKzSQ8lTpBl mjmFez+n0nDoDRAMzwJXlL09455Vnz2YCg2ECqg5OJ306byRRmWJn11TqBBjXGsUyEpv 7ORHQa1fAKIl+yxDQ0sDwOhw5VVycLVbuRO2xYbTNV6+r1piBIDitKUxZkYjLb7bbqXl htcFUn9pcKtA02SQv60cY3Cot/9x/RGBDEDQgYoIaiRnhqwaLsNEGGB7Rm4tQaax6i5r +HTE21BWiEM+uuAno6BVTwjgsaljSXDkgpFuO1ZyARKoOXCHUWJCgUtwUZeSesgMzUcW l2OA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id q3si10189917ybo.63.2019.04.22.09.51.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 09:51:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hIc8r-0004oM-Fw; Mon, 22 Apr 2019 16:50:05 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hIc8q-0004il-Nn for xen-devel@lists.xenproject.org; Mon, 22 Apr 2019 16:50:04 +0000 X-Inumbo-ID: accf1e7e-651e-11e9-8c13-179d71b0fcb1 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id accf1e7e-651e-11e9-8c13-179d71b0fcb1; Mon, 22 Apr 2019 16:50:03 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4583B15AB; Mon, 22 Apr 2019 09:50:03 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35D443F557; Mon, 22 Apr 2019 09:50:02 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 22 Apr 2019 17:49:26 +0100 Message-Id: <20190422164937.21350-10-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190422164937.21350-1-julien.grall@arm.com> References: <20190422164937.21350-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH 09/20] xen/arm64: head: Correctly report the HW CPU ID X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Oleksandr_Tyshchenko@epam.com, Julien Grall , sstabellini@kernel.org, Andrii_Anisov@epam.com MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR_EL1. So remove the zeroing and logic to check if the CPU is part of a uniprocessor system. Signed-off-by: Julien Grall Reviewed-by: Andrii Anisov --- xen/arch/arm/arm64/head.S | 6 ------ 1 file changed, 6 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index b957eb90fb..08094a273e 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -277,15 +277,9 @@ GLOBAL(init_secondary) mov x26, #1 /* X26 := skip_zero_bss */ common_start: - mov x24, #0 /* x24 := CPU ID. Initialy zero until we - * find that multiprocessor extensions are - * present and the system is SMP */ mrs x0, mpidr_el1 - tbnz x0, _MPIDR_UP, 1f /* Uniprocessor system? */ - ldr x13, =(~MPIDR_HWID_MASK) bic x24, x0, x13 /* Mask out flags to get CPU ID */ -1: /* Non-boot CPUs wait here until __cpu_up is ready for them */ cbz x22, 1f