From patchwork Tue Jul 23 21:35:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 169563 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp9377078ilk; Tue, 23 Jul 2019 14:37:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVvZRdac4l08+/DweClOaGG3qMGee1XyLK/2cDvHX3sS23ppUPue/kXkWejGSAZweUG10y X-Received: by 2002:a6b:cd86:: with SMTP id d128mr72564664iog.234.1563917857569; Tue, 23 Jul 2019 14:37:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1563917857; cv=none; d=google.com; s=arc-20160816; b=fK6mx2RZZcnzSsj21W3EsS5tS3iCzIroFVefs4gmjyQfY09zmbiaDx181H8tZ1YIMk mn+T/Hom0aUxmigkArIUAuIZC1nDKakHVXBpX0xmjeN+FyjD31Xy4nFmpTT4DIoxUF5z Jr2eVNOU07DmdRR0AZMDoWOpKNx3lPget7/+K9Crkt51tL62Bd0Onvbqf4Q3UKlxLucX Tg7AJ6E+3avkaiXtjrO+OyWfJBTmqZqKY/fYNeTjQMA4ryYJ+EEEkGuRfeNke22Uk+sw FVkzplufxm10kx+C+0uVcERIUvKqZrDJl2RxjPypqQozXccqMXJ/MW12JdBGmTOX58nf go+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=NUwQ4vdhc9XdyDsiKnbldzs/HJfPaeNVYo17KgVW3X4=; b=ClrL3VPNrWUeRaTZXwYONLpb8uk2r5Ls80aHoUlZ+7cy/3xM0hdTXN7KRJ1z5b5gt2 nFQb9loqPXjqrZiyD+pAcuWy88lhjG1GqwcV13xN03PGnnU1A0Xro+2Fxk+uPFHv5B08 tMdBv8APj5hR4HEFnei/7ovLsyQ+OeuxzElVuCfTKKGgiiq2dccGljWR9a/tzmIUbdm5 LRypWJ505MXum9GJ+fCRUztCkf7dqIs6NtLY0l3RGvNB2FwvtbplFyHY9tSe2G1o9CbV M7D9f9I5tXqYYfWBuwBBH7uMAyaxcsossKhOSGhi663e9//7x8Fz3OHag/nGHWIqifeo 9GaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id m18si64002229jaa.95.2019.07.23.14.37.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jul 2019 14:37:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hq2S8-0001x2-Tw; Tue, 23 Jul 2019 21:36:08 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hq2S6-0001vj-DQ for xen-devel@lists.xenproject.org; Tue, 23 Jul 2019 21:36:06 +0000 X-Inumbo-ID: e0536cd1-ad91-11e9-8980-bc764e045a96 Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id e0536cd1-ad91-11e9-8980-bc764e045a96; Tue, 23 Jul 2019 21:36:05 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9A9DB1596; Tue, 23 Jul 2019 14:36:05 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E84FA3F71F; Tue, 23 Jul 2019 14:36:04 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 23 Jul 2019 22:35:52 +0100 Message-Id: <20190723213553.22300-7-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190723213553.22300-1-julien.grall@arm.com> References: <20190723213553.22300-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH 6/7] xen/arm: vsmc: The function identifier is always 32-bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Arm64, the SMCCC function identifier is always stored in the first 32-bit of x0 register. The rest of the bits are not defined and should be ignored. This means the variable funcid should be an uint32_t rather than register_t. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Reviewed-by: Stefano Stabellini --- xen/arch/arm/vsmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c index f8e350311d..a36db15fff 100644 --- a/xen/arch/arm/vsmc.c +++ b/xen/arch/arm/vsmc.c @@ -220,7 +220,7 @@ static bool vsmccc_handle_call(struct cpu_user_regs *regs) { bool handled = false; const union hsr hsr = { .bits = regs->hsr }; - register_t funcid = get_user_reg(regs, 0); + uint32_t funcid = get_user_reg(regs, 0); /* * Check immediate value for HVC32, HVC64 and SMC64. @@ -286,7 +286,7 @@ static bool vsmccc_handle_call(struct cpu_user_regs *regs) if ( !handled ) { - gprintk(XENLOG_INFO, "Unhandled SMC/HVC: %08"PRIregister"\n", funcid); + gprintk(XENLOG_INFO, "Unhandled SMC/HVC: %#x\n", funcid); /* Inform caller that function is not supported. */ set_user_reg(regs, 0, ARM_SMCCC_ERR_UNKNOWN_FUNCTION);