From patchwork Thu Oct 31 15:09:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 178200 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp2980482ill; Thu, 31 Oct 2019 08:11:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqx1xFhAUo3F5tIaT1yoWDuZBUBB1qAKrwjHiENSB5aZ/zcbb54Kf2x5adfv8M+LOAb+FdVG X-Received: by 2002:a92:46d9:: with SMTP id d86mr6308192ilk.253.1572534691051; Thu, 31 Oct 2019 08:11:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572534691; cv=none; d=google.com; s=arc-20160816; b=kx/YfDe7lB3OidG/RfEANhPcoHp/64e43sIQoGWNZbZDC7QZDRDaSDzDSeUzUVC+J+ ZMh+NWaQrmWNteycJekPLEdWSXzToZUzflRduJi3v87XcO/bSG05i8AonDzWvlMgsm5O X0cmQob/fVRT/PpwWNL2ykAimBFzpBrEMRvJEo/3fDNR6qm4j2zMd/jt/sbN2O+5Hal9 Hx/GOUONEhg0wjwKOHcV64c+rx8T1sVUtQ2ff7Utiv9GBOV4DOFs+oFB8n37h9BIswWK u2xlWatJimVWLAvye35S9RYQarO0DVYkN99BR62kB2xfjxAAjcbcB6ZSYqyFZAjETcC+ /DtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=iTWkhzbTtgbyuyN9jrHHWTsSuwuvyelhG6KN7HFCEZ0=; b=ap1Vp6LMu3Wb6tKuoa+rgNr3YBUE4KcUTRtgNMlJMF4e/06UOXFm2mcrliv1Aoyae5 K49/oNKm4FQUwDizwnU3v+9g7yVZi+mniVBsVTXAyYJ0Ly9pW5vIBQyzxgjezgwpzALy 58A38B75bcTVSogFGDQSd7aViA7CFxyJHDy+MxqQ2LHVkN3+h+9EdlK6kFpNxQKhAi1n /B/tpbWYOnOL4EhynYEfC9Rw8oilS3gnGEyL2F4VFtfDjK5ihHTEFXfa2jlznDjY0dKW FQmezdEDmjBGFHdvW+VVLwUfdJllV+nYsBQ63ir4mepEYAxwnuGOlFjcpiAEgRzlKfqR tvVg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id q3si7774424ilb.65.2019.10.31.08.11.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 31 Oct 2019 08:11:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iQC5s-0007rg-CC; Thu, 31 Oct 2019 15:10:36 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iQC5r-0007qc-BV for xen-devel@lists.xenproject.org; Thu, 31 Oct 2019 15:10:35 +0000 X-Inumbo-ID: 7e9ba055-fbf0-11e9-954c-12813bfff9fa Received: from foss.arm.com (unknown [217.140.110.172]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTP id 7e9ba055-fbf0-11e9-954c-12813bfff9fa; Thu, 31 Oct 2019 15:09:55 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7BE5F8E6; Thu, 31 Oct 2019 08:09:55 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (unknown [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 922DB3F71E; Thu, 31 Oct 2019 08:09:54 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 31 Oct 2019 15:09:21 +0000 Message-Id: <20191031150922.22938-19-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20191031150922.22938-1-julien.grall@arm.com> References: <20191031150922.22938-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH for-4.13 v4 18/19] xen/arm: Update the ASSERT() in SYNCHRONIZE_SERROR() X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com, Volodymyr Babchuk , Julien Grall , Stefano Stabellini , Julien Grall MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The macro SYNCHRONIZE_SERROR() has an assert to check whether it will be called with Abort interrupt unmasked. However, this is only done if a given cap is not enabled. None of the callers will treat the abort interrupt differently depending on a feature. Furthermore, it makes more difficult to check whether SYNCHRONIZE_SERROR() is going to be called with abort interrupt unmasked. Therefore, we now require the abort interrupt to be unmasked regardless the state of the cap. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v3: - Add Stefano's acked-by Changes in v2: - Patch added --- xen/include/asm-arm/processor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/asm-arm/processor.h b/xen/include/asm-arm/processor.h index e9d2ae2715..aa642e3ab2 100644 --- a/xen/include/asm-arm/processor.h +++ b/xen/include/asm-arm/processor.h @@ -542,7 +542,7 @@ register_t get_default_hcr_flags(void); */ #define SYNCHRONIZE_SERROR(feat) \ do { \ - ASSERT(!cpus_have_cap(feat) || local_abort_is_enabled()); \ + ASSERT(local_abort_is_enabled()); \ asm volatile(ALTERNATIVE("dsb sy; isb", \ "nop; nop", feat) \ : : : "memory"); \