[3/3] setuptoools.bbclass: Do not use -pie with hardening

Message ID	20170602044153.9629-3-raj.khem@gmail.com
State	Accepted
Commit	dc1c16e9df365871b2c40998f63f304ffa610447
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; From: Khem Raj <raj.khem@gmail.com> To: openembedded-core@lists.openembedded.org Date: Thu, 1 Jun 2017 21:41:53 -0700 Message-Id: <20170602044153.9629-3-raj.khem@gmail.com> In-Reply-To: <20170602044153.9629-1-raj.khem@gmail.com> References: <20170602044153.9629-1-raj.khem@gmail.com> Subject: [OE-core] [PATCH 3/3] setuptoools.bbclass: Do not use -pie with hardening Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org
Series	[1/3] as-needed.inc: Compile pulseaudio with --as-needed \| expand [1/3] as-needed.inc: Compile pulseaudio with --as-needed [2/3] musl: Update to lates master [3/3] setuptoools.bbclass: Do not use -pie with hardening

Message ID

20170602044153.9629-3-raj.khem@gmail.com

State

Accepted

Commit

dc1c16e9df365871b2c40998f63f304ffa610447

Headers

Received-SPF: pass (google.com: best guess record for domain of
	openembedded-core-bounces@lists.openembedded.org designates
	140.211.169.62 as permitted sender) client-ip=140.211.169.62; 
From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Date: Thu,  1 Jun 2017 21:41:53 -0700
Message-Id: <20170602044153.9629-3-raj.khem@gmail.com>
In-Reply-To: <20170602044153.9629-1-raj.khem@gmail.com>
References: <20170602044153.9629-1-raj.khem@gmail.com>
Subject: [OE-core] [PATCH 3/3] setuptoools.bbclass: Do not use -pie with
	hardening
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: openembedded-core-bounces@lists.openembedded.org
Errors-To: openembedded-core-bounces@lists.openembedded.org

Series

[1/3] as-needed.inc: Compile pulseaudio with --as-needed | expand

Commit Message

Khem Raj June 2, 2017, 4:41 a.m. UTC

Fix build when PIE is turned on. It tries to build
.so file using -pie and -shared flags together because
its doing compile and link in same step CFLAGS and LDFLAGS
are combined and does not work, ending in errors e.g.

| /mnt/a/oe/build/tmp/work/cortexa7t2hf-neon-vfpv4-bec-linux-musleabi/python-pygpgme/0.3-r0/recipe-sysroot/usr/l
ib/Scrt1.o: In function `_start_c':
| /usr/src/debug/musl/1.1.16+gitAUTOINC+179766aa2e-r0/git/crt/crt1.c:17: undefined reference to `main'
| collect2: error: ld returned 1 exit status

This error while cryptic is due to the fact that we are
building a shared library but also pass -pie flag to the link
step after specify LDHSARED ( which is -shared linker flags )

we can not use -pie when doing shared libs. This is true for all the python
modules inheriting setup tools

Disable the pie flags thusly for all modules using setuptools since
this setting is done in setuptools makefiles which are then used
during module compiles

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/classes/setuptools.bbclass | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.13.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

diff --git a/meta/classes/setuptools.bbclass b/meta/classes/setuptools.bbclass
index 56343b1c73..7d0c5267d7 100644
--- a/meta/classes/setuptools.bbclass
+++ b/meta/classes/setuptools.bbclass
@@ -6,3 +6,5 @@  DISTUTILS_INSTALL_ARGS = "--root=${D} \
     --prefix=${prefix} \
     --install-lib=${PYTHON_SITEPACKAGES_DIR} \
     --install-data=${datadir}"
+
+SECURITY_CFLAGS = "${SECURITY_NO_PIE_CFLAGS}"