From patchwork Thu Mar 1 12:29:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ross Burton X-Patchwork-Id: 130177 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2736640edc; Thu, 1 Mar 2018 04:30:21 -0800 (PST) X-Google-Smtp-Source: AG47ELsMVUfCwFxIy41JgK08DPjld1541wsUiQdCsThGf2ZRerwksNl6P9dyuVPZKW/t8x9/GPYV X-Received: by 2002:a17:902:a60d:: with SMTP id u13-v6mr1770638plq.165.1519907420897; Thu, 01 Mar 2018 04:30:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519907420; cv=none; d=google.com; s=arc-20160816; b=nGFJDZxQ2h3tnIcAOMAeqgelvG9AFIzfpTuTibYPzkrbfp+YveIFBJlO+9o4JEnRdc SOMLgHaS5XrI0ccmYH+tl88TskQ1hGdzLtgxgbrTX+T4QzT99nRetVtHpGZgrf1m/9Mn JooQpxocFolxmcbzICz8YyzSxyNjqMOCssdJk4YdpS0Oef7/RaCYKcglk7H9iDKhrhPg uGscFgvwUuAstwMROAeczl/AnWg0CGH1Q6hUJc6x5m2m9R1Re4vMqq2MbdaNbEEGy6lK +RMDlG6jQ1WlRZpx8kWVs3WLdY3HxleAEdLj4HQz+T2S3zflfijkTqpxcDbxpaTehJZK Q0Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:message-id:date:to:from:dkim-signature :delivered-to:arc-authentication-results; bh=SIb0LZq+Kl+ov7+KLctPVj9QlmWY9uemj2EMnn0vc5o=; b=hHrxnKvpWPKo/8X/SmqcfloJ10rFb7FeOa5qlMGbBv8WU+LoncoY7p5Ku4yH67hapW WfejgYAB9ohvq4zvJbCMlYy+UXaO5b1PPea22CZF731ZwifF13w4GmlS3FZlUvfmo3gs vrIQ3leaQbVjICsBIXV4wE+nfEzAPuI4ZvTYDNX9LM7FABk/vfo9bYSlf61nH14+9tTw AHhQtViopjxbxml1oa+zTxx6eJiL42RGHBtBrtbrcmSrSjcaJkuC+c1u4YVSiGSaPreH Y5Oeg+VQuj/rKzLXHdkXEOnDlJfQo0eXAQ7iWUZG+T8usykZgzD0tgoYOPBZie2CTG2y YZRA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=Jaiyh5qd; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id e92-v6si3014418plb.82.2018.03.01.04.30.20; Thu, 01 Mar 2018 04:30:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel-com.20150623.gappssmtp.com header.s=20150623 header.b=Jaiyh5qd; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org Received: from layers.openembedded.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id ACE9078848; Thu, 1 Mar 2018 12:30:16 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by mail.openembedded.org (Postfix) with ESMTP id 8073271C9F for ; Thu, 1 Mar 2018 12:29:48 +0000 (UTC) Received: by mail-wr0-f194.google.com with SMTP id k9so5906968wre.9 for ; Thu, 01 Mar 2018 04:29:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id; bh=/80c2s6TXso1Jj33UgMM4QVX7Sfr203p35MeFoJOywQ=; b=Jaiyh5qdKhMdhj1ZK8aptaryBraWBHV2BlKQlr7x4YtFNlBoN/n2iR0dYHJgqzcJSv X+r9j8qsH2nsPqbt4rJ+SAMvslF3pZc4F9ZWLQCXjdhrVPMDoCPnc5kilW0puNPmI+cb Cxzii7JqT0QmWOSObXkEXReaUaV4uN5kZPzx4L8ntXcDVbR58WMsl3UXYy7n6AnT3Yj1 9srXj1NDadO8XhSocJW42j2T25/X3ZKGtXBiSG7u8b5Concen3i+GygSEDilVuC2R0se z5IeWEL0fg1XvdiR5WiZwCo/ZQA1KjXMyGWwIi1zFZySHI5OQ0DSLr5ly+VisKoGWs9K Ww/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=/80c2s6TXso1Jj33UgMM4QVX7Sfr203p35MeFoJOywQ=; b=Y3z9WA0DND1vmg/WSoGY0pHBPW6ObQnLpVlGm7VCKnjSycaPke0bv+cflyETQF5CV/ 2PLipncUb5hemCzLm4uUWZJH/g4gTTH2rX/6MDLApQvLDR1fc6onAw883HV2HLZ1egCv C8DA06PTvv8LpXjiYxX8N4xQRLNuFKBi8kcFVp6Ldaud8mH8AKBfPkMA1P0bIL/KJxs6 wnWjCGTa1M/TNLl4D/QMdMcsD1FjPMdrWBesbZEbkGFjHCMXpnTuHYjPDnx4Vuc+qISb COvqjyw/3wWTvy1F+Up7qTyt3Q43SnCpXo46Z/2zjm7vsbBtGQSeoyd+0TXC14jcZE1e Nnhg== X-Gm-Message-State: APf1xPAhGoGHSsa6HcAo5/KKr1qrU8YjiIv8VidNNHrMql0eI9IInPgX 9QbdfeIThVP+sBUnrn3WNckFhvGn X-Received: by 10.223.173.163 with SMTP id w32mr1683596wrc.204.1519907389084; Thu, 01 Mar 2018 04:29:49 -0800 (PST) Received: from flashheart.burtonini.com (35.106.2.81.in-addr.arpa. [81.2.106.35]) by smtp.gmail.com with ESMTPSA id y28sm3776679wrd.46.2018.03.01.04.29.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Mar 2018 04:29:48 -0800 (PST) From: Ross Burton To: openembedded-core@lists.openembedded.org Date: Thu, 1 Mar 2018 12:29:46 +0000 Message-Id: <20180301122946.7388-1-ross.burton@intel.com> X-Mailer: git-send-email 2.11.0 Subject: [OE-core] [PATCH] package.bbclass: fetch PRIVATE_LIBS twice as we iterate twice X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org The shlibs detection/handling iterates the package list twice, but PRIVATE_LIBS is only fetched in the first loop which means the second loop only considers the value set. Signed-off-by: Ross Burton --- meta/classes/package.bbclass | 3 +++ 1 file changed, 3 insertions(+) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass index e7e93a067a6..317c77585fc 100644 --- a/meta/classes/package.bbclass +++ b/meta/classes/package.bbclass @@ -1773,6 +1773,9 @@ python package_do_shlibs() { for pkg in packages.split(): bb.debug(2, "calculating shlib requirements for %s" % pkg) + private_libs = d.getVar('PRIVATE_LIBS_' + pkg) or d.getVar('PRIVATE_LIBS') or "" + private_libs = private_libs.split() + deps = list() for n in needed[pkg]: # if n is in private libraries, don't try to search provider for it